Commit Graph

148279 Commits

Author SHA1 Message Date
Benjamin Pasero
303416bcfa debt - check in stale lock file for packages (#296797) 2026-02-21 23:24:03 -08:00
Anthony Kim
8494e45e1f Allow ghostty terminal from external terminal osx, linux (#286983)
* Push changes from break

* comment

* Cleaner, still TODO

* todo

* todo

* Use --wait-after-command for ghostty

* Refactor so its cleaner on Mac for iterm vs. ghostty

* remove --working-directory from spawnTerminal

* Remove comment

* Tests

* More descriptive comment for na

* Ghostty for linux as well

* remove unused

* refactor better
2026-02-21 22:43:00 -08:00
Harald Kirschner
c760ee7f43 Update proposed API versioning instructions (#293291) 2026-02-22 05:03:57 +00:00
Peng Lyu
6c1efa9aaf improve handling of titleTemplate for proposed API (#296760) 2026-02-22 00:13:34 +00:00
Alexandru Dima
9c99e8fb20 Merge pull request #296709 from microsoft/alexd/comparable-sparrow
Fix ViewModel issue where all lines were hidden
2026-02-21 23:11:23 +01:00
Benjamin Pasero
beb0fcb0c5 sessions - allow to open editors in new window (#296701) 2026-02-21 13:49:14 -08:00
Sandeep Somavarapu
aa825dfa93 add logging (#296756)
* add logging

* feedback
2026-02-21 21:08:50 +00:00
Ladislau Szomoru
257a0cf20b GitService - more perf tweaks (#296759)
GitService - more tweaks
2026-02-21 21:00:20 +00:00
Benjamin Pasero
483dbd1fdd sessions - stop blocking the context menu on sessions (#296755) 2026-02-21 20:40:40 +00:00
Ladislau Szomoru
66e02a33c8 GitService - fix issue with opening a repository (#296752) 2026-02-21 20:20:42 +00:00
Alex Dima
f1d5b97061 Fix unit test 2026-02-21 13:47:41 +01:00
Alexandru Dima
bc0e092d53 Update src/vs/editor/test/common/viewModel/prefixSumComputer.test.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-21 13:10:56 +01:00
Alex Dima
fd182ab801 Protect event delivery 2026-02-21 11:40:43 +01:00
Alex Dima
3c5c4ba686 fix: safety check in _constructLines for 0 visible lines
When hidden area decorations drift via AlwaysGrowsWhenTypingAtEdges
stickiness, _constructLines(resetHiddenAreas=false) — triggered by
tab size or wrapping changes — can rebuild projections with all lines
hidden.

Extract _ensureAtLeastOneVisibleLine() shared by both _constructLines
and acceptVersionId.
2026-02-21 11:40:42 +01:00
Alex Dima
cb1391c68f Add unit test for overlapping hidden ranges 2026-02-21 11:40:42 +01:00
Alex Dima
2af23ffd29 Revert setViewport early return (aee9b1b3) since the root cause (0 visible lines) is now fixed at the source 2026-02-21 11:40:42 +01:00
Alex Dima
86dc9c4e38 fix: ensure at least one line remains visible after edits with hidden areas
When an edit (delete/undo) removes or merges the only visible line(s) into
hidden lines, the view model could end up with zero visible lines, causing
downstream crashes (e.g. 'Not supported' from HiddenModelLineProjection).

The safety check in acceptVersionId only caught the case where exactly 1
hidden line remained. Generalize it to detect when getViewLineCount() === 0
and minimally restore visibility by making just the first line visible,
preserving the caller's intended hidden areas as much as possible.
2026-02-21 11:40:42 +01:00
Alexandru Dima
1fd39ecd9e Update src/vs/editor/common/model/prefixSumComputer.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-21 11:40:24 +01:00
Alexandru Dima
f21433b98c Update src/vs/editor/test/common/viewModel/prefixSumComputer.test.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-21 11:40:11 +01:00
Benjamin Christopher Simmonds
cd9a8f3e8d Merge pull request #296555 from microsoft/benibenj/fresh-chinchilla
sessions feedback improvements
2026-02-21 10:01:18 +01:00
Benjamin Christopher Simmonds
367b0f3e4f Update src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackHover.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-21 09:45:22 +01:00
Benjamin Pasero
a42bcd7c49 sessions - hide sessions picker in aux windows (#296703) 2026-02-21 09:23:21 +01:00
Benjamin Pasero
c442c75023 sessions - tweaks to use of modal editors (#296698)
* sessions - tweaks to use of modal editors

* ccr

* ffs

* ffs

* ffs
2026-02-21 09:23:01 +01:00
Alex Dima
738f5e0e1b Merge remote-tracking branch 'origin/main' into alexd/comparable-sparrow 2026-02-21 09:13:48 +01:00
Alex Dima
9cb3ac3695 Fix ConstantTimePrefixSumComputer when the values are all zeroes 2026-02-21 09:13:12 +01:00
Benjamin Pasero
6e91d50e71 No way to open keybindings json from modal (fix #296682) (#296700) 2026-02-20 23:40:25 -08:00
Josh Spicer
405897eb11 customizations editor (#296680)
* ai customizations editor

* tidy

* tidy

* tidy
2026-02-20 19:10:46 -08:00
Peng Lyu
eeda773a67 terminal: support tab title templates for extension terminals (#296404)
* terminal: support tab title templates for extension terminals

* terminal: omit undefined tabTitle from profile quick pick

* refactor: rename terminal title properties to titleTemplate for consistency

* proposed api check.
2026-02-20 18:58:54 -08:00
Matt Bierner
78fba4c219 Merge pull request #296677 from mjbvz/dev/mjbvz/rainy-grouse
Adopt unified js/ts setting for diagnostic settings
2026-02-20 18:57:18 -08:00
Matt Bierner
2a0ce9055c Update extensions/typescript-language-features/src/tsServer/bufferSyncSupport.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-20 18:03:03 -08:00
Matt Bierner
851ed34c13 Fix ref 2026-02-20 17:55:27 -08:00
Matt Bierner
655ce6f07e Adopt unified js/ts setting for diagnostic settings
For #292934

Also renames validate.enable to `validate.enabled` to align with other settings
2026-02-20 17:54:24 -08:00
Tyler James Leonhardt
51e07b8403 bump the distro (#296672) 2026-02-20 17:50:09 -08:00
copilot-swe-agent[bot]
b506711b0d Remove gray background container for single editor buttons
Co-authored-by: jo-oikawa <14115185+jo-oikawa@users.noreply.github.com>
2026-02-21 01:41:14 +00:00
copilot-swe-agent[bot]
bb8e88443f Initial plan 2026-02-21 01:29:55 +00:00
Matt Bierner
42bb5a85ee Merge pull request #296582 from mjbvz/dev/mjbvz/graceful-tick
Make isUntitled as deprecated
2026-02-20 17:11:19 -08:00
Matt Bierner
dda93cf577 Merge pull request #296664 from mjbvz/dev/mjbvz/environmental-sparrow
Better grouping of js/ts settings
2026-02-20 17:10:41 -08:00
Tyler James Leonhardt
4968804d65 Allow returning a title in the Content Provider (#296659)
So that the title of a chat can be changed.
2026-02-20 17:01:16 -08:00
David Dossett
cca45c80c6 Remove checkmarks from chat-used-context-label, add hover chevron (#296621)
* Remove checkmarks from chat-used-context-label, add hover chevron

* thinking check fixes, confirmation widget fixes

* fix some tests and margin

* remove checkmarks from progress containers

* remove all checks and support in hooks and all other used context lists

* Add aria-hidden to decorative hover chevrons

---------

Co-authored-by: justschen <justchen@microsoft.com>
2026-02-20 16:51:34 -08:00
Matt Bierner
cf4d60558a Fix missing % 2026-02-20 16:49:49 -08:00
Matt Bierner
23a013aaee Better grouping of js/ts settings 2026-02-20 16:44:52 -08:00
Connor Peet
127ba17164 Merge pull request #296617 from microsoft/connor4312/cp-plugins-1
agent: add preliminary plugin support
2026-02-20 16:26:26 -08:00
Paul
bf1992d675 Fix claude agents not showing up in local chat dropdown (#296647) 2026-02-21 00:19:22 +00:00
David Dossett
91b2ea73d9 Model picker search input styling and separator improvements (#296645)
* Refine chat model picker menu behavior

* Model picker search input styling and separator improvements

* Remove filterPosition option, always place filter on top

* Remove filterInputClassName option and font-size override

* Fix separator always shown above Manage Models and update tests
2026-02-20 15:52:48 -08:00
Matt Bierner
7a05c7fb8a Merge pull request #296628 from mjbvz/dev/mjbvz/nuclear-dingo
Try cleaning up api around acquiring/loading/creating sessions
2026-02-20 15:50:30 -08:00
David Dossett
175a5fd9b7 Show attachments toolbar for implicit context in Ask mode and selections (#296630)
* Show attachments toolbar for implicit context in Ask mode and selections

* Fix keyboard focus for implicit context attachments
2026-02-20 15:45:02 -08:00
Sandeep Somavarapu
53a9e01687 remove creating session in beginning (#296638) 2026-02-20 23:36:25 +00:00
Megan Rogge
797e1c84ae add kb to navigate to next/previous question (#296633) 2026-02-20 23:13:44 +00:00
Ladislau Szomoru
b21a3cc7a3 GitService - add barrier for setting the delegate (#296631) 2026-02-20 23:08:10 +00:00
Megan Rogge
4f8f63604e ensure chat tip actions trigger chat setup (#296536)
* fixes #296487

* fix: handle unexpected errors in chat tip action
2026-02-20 23:00:29 +00:00