* Refactor hook execution
* Fix compilation: add IExtHostHooks import, remove unused IHookResult, inline ChatRequestHooks type
* Move hooks property to chatHooks proposal, sync DTS
* cleanup
* Remove dead hook execution code: proxy, RPC, output channel, progress events
All hook execution now happens in the extension via NodeHookExecutor.
HooksExecutionService is now a pure registry (registerHooks/getHooksForSession).
Removed:
- executeHook, setProxy, onDidHookProgress from service
- IHooksExecutionProxy, IHookProgressEvent, HookAbortError, formatHookErrorMessage
- hooksCommandTypes.ts, hooksTypes.ts (dead type files)
- mainThreadHooks proxy setup
- extHostHooksNode., extHostHooksWorker.
- ExtHostHooksShape. protocol
- IExtHostHooks DI registrations
- ChatHooksProgressContribution
- All associated test files
* Remove HooksExecutionService entirely
The service was only a registry for session hooks, but hooks are already
passed directly on the chat request DTO. The registerHooks/getHooksForSession
pattern was redundant.
* Restore modelName support in chatSubagentContentPart that was accidentally removed during merge
* Revert unrelated tabIndex change on chatSubagentContentPart
* Remove empty hooks ext host infrastructure
Delete IExtHostHooks, NodeExtHostHooks, WorkerExtHostHooks,
MainThreadHooks, ExtHostHooksShape, MainThreadHooksShape -
all were empty stubs after hook execution moved to extension.
* Remove mainThreadHooks import from extensionHost.contribution
* Fix DTS comments: env and timeoutSec are values, not implementation promises
* Try using esbuild to bundle our built-in extensions
Test switching to esbuild instead of webpack to bundle our buildin extensions. Setup so we can do this incrementally and starting with the markdown extension as a test
* Fix build ext media
* Fix .ts script name check
* Update comment
* Use ts for all scripts
* refactor layout and layout2d into base common
* support anchored quick pick
* wip: use anchored quick pick in scm
* almost there
* undo scm history view pane
* Chat - implement session picker in the chat panel title
* Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Port changes again, and clean things up
* Pull request feedback
* missing changes
* cleanup
* fix bad merge
* reduce complexity
* polish
* update title
* Adopt the anchor
* Fix compilation error
* Fix monaco editor check
* Enhance drag-and-drop functionality in QuickInput: add cursor style for no-drag state and enable/disable control
* Fix positioning bug
* fix change of behavior of layout2d
* Apply suggestion from @Copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Tyler James Leonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
- Added check in TerminalSandboxService to filter out '*' wildcard when building allowedDomains list for sandbox
- Sandbox runtime doesn't allow sole wildcard '*', but wildcards like '*.github.com' are OK
- Added comprehensive unit tests covering various scenarios including wildcards, combinations, and deduplication
Co-authored-by: jrieken <1794099+jrieken@users.noreply.github.com>
