Instead of moving TerminalSandboxService to the browser layer, extract
just the ITrustedDomainService interface and decorator into a new
contrib/url/common/trustedDomainService.ts. This allows the service to
be consumed from the common layer while keeping the implementation in
browser.
Co-authored-by: jrieken <1794099+jrieken@users.noreply.github.com>
Move TerminalSandboxService implementation from common to browser layer
to enable ITrustedDomainService injection. When allowTrustedDomains is
true, trusted domains from the Trusted Domains list are merged into the
sandbox's allowedDomains. Changes to trusted domains trigger sandbox
config refresh.
Co-authored-by: jrieken <1794099+jrieken@users.noreply.github.com>
* chat: polish queue/steering menu button
- Dropdown action that uses custom dropdowns to queue, steer, or send
immediately.
- Fix not being able to message with a pending tool call
- Config controls the default button action
* fix
* fix compile
<!-- Thank you for submitting a Pull Request. Please:
* Read our Pull Request guidelines:
https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests
* Associate an issue with the Pull Request.
* Ensure that the code is up-to-date with the `main` branch.
* Include a description of the proposed changes and how to test them.
-->
today when agent status and share are enabled, the share button is between both. this pr moves share button to left of command palette.
* Initial plan
* Fix F7 keybinding conflict by requiring accessibilityModeEnabled
Add CONTEXT_ACCESSIBILITY_MODE_ENABLED to the when clause for
chatEditor.action.showAccessibleDiffView so the F7 shortcut only
activates when screen reader mode is enabled. This prevents the
shortcut from conflicting with "Go to Next Symbol Highlight".
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
* feat(accessibility): Add Accessibility Help System for find/filter dialogs
This PR adds comprehensive accessibility help (Alt+F1) for all find and filter
experiences in VS Code, providing keyboard shortcuts, navigation instructions,
and context-specific guidance for screen reader users.
Infrastructure Changes:
- Extended AccessibleViewProviderId for find/filter contexts
- Added AccessibilityVerbositySettingId.Find configuration
- Updated FindWidget to accept configuration and accessibility services
New Accessibility Help Providers:
- editorFindAccessibilityHelp.ts: Editor find/replace dialog help
- terminalFindAccessibilityHelp.ts: Terminal find help
- webviewFindAccessibilityHelp.ts: Webview find help
- outputAccessibilityHelp.ts: Output panel filter help
- markersAccessibilityHelp.ts: Problems panel filter help
- searchAccessibilityHelp.ts: Search across files help
- replAccessibilityHelp.ts: Debug console filter help (modified)
Each provider implements IAccessibleViewContent with:
- Comprehensive keyboard shortcut documentation
- Context-specific navigation instructions
- Settings and options explanations
- Platform-specific shortcuts where applicable
Contribution Registrations:
- codeEditor.contribution.ts: Editor find/replace wiring
- terminal.find.contribution.ts: Terminal find wiring
- webview.contribution.ts: Webview find wiring
- output.contribution.ts: Output panel filter wiring
- markers.contribution.ts: Problems panel filter wiring
- search.contribution.ts: Search across files wiring
Closes#292367
* rm unused variables
* fix: return focus to Find dialog when closing accessible help
When accessible help (Alt+F1) is dismissed from the Find dialog,
focus now correctly returns to the Find or Replace input that was
focused when accessible help was invoked.
* fix: properly track last focused input for accessibility help focus restoration
* fix: make Find accessibility help work with all widget elements
* fix: use focusin event to track focus within Find widget
* fix some issues
---------
Co-authored-by: GitHub Copilot <github-copilot@example.com>
Co-authored-by: meganrogge <merogge@microsoft.com>
* fix: associate extHost lifecycle to window
* fix: skip the smoke test in remote
The reload scenario doesn't guarantee a proper cleanup of
the remote server via the test-resolver extension.
* fix: flaky condition
* chore: disable extension setup in remote
