* Start structuring the custom editor rename work
* Restore renamed / moved editors from backup
* Add back missing readonly
* Discard backup after using it
* Address feedback
* Remove console log
* Switch to using a map
* Delete used backups from the map
For #120675
This uses a script to add the override keyword to places that need it in the codebase
Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
* Improve passing of ArrayBuffers to and from webviews
Fixes#115807
* Serialize and restore typed arrays too
This also makes it so that if you pass the same ArrayBuffer twice in an object, we use a single object on the receiver side too
* Fix spelling
* Require VS Code 1.56+
* Add an untitled document data property
* Dispose of the model passed back
* Fix layer problem
* Add untitledDocumentData to untitled notebooks
* Fix compilation errors
* Switch to using VS Buffer
* Fix threading the untitled document data back through
* Prevent save dialog on untitled reopen with
* Change ignore save setting
* Change setting name and abide by preserve focus
* Add unit test
* Switch to js doc comments
* Consolidate calculating the untitled value, and added test
- Move protocol types into protocol
- Hold off on combining the options objects until serialization
- Add explicit converstions instead of using `...`
- Make a few methods take property bags to help avoid passing arguments in wrong order
Fixes#106547
This switching the working copy resource for custom editors to use an encoded path instead of the resource's original path. This fixes a few problems:
- Fixes a bug where two resources with the same path (but different schemes or authorities) would be considered the same
- Fixes a bug where windows style paths (`c:\path`) would cause issues. This is the root cause of #106547
- Fixes a bug where the viewType was used as the raw authority. If the view type contains invalid characters, this would have caused issues
Fixes#105670
Previously our webview commands assumed that webviews were always going to be in an editor. This is no longer true with webview views.
To fix this, I've added an `activeWebview` to the `IWebviewService`. This tracks the currently focused webview.
* Add to WorkingCopyCapabilities enum to reflect usage.
The capabilities field was being used with a value of 0 in a few places that implemented the IWorkingCopy interface. This inconsistency wasn't picked up by the compiler because the value in the enum was specified as `1 << 1` and not as `2`. This changes the value to be specified as `2` (for better type checking) and makes the 0 to use the new enum value.
* some polish on top
Co-authored-by: Maksym Taran <maksym.taran@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
