Commit Graph

255 Commits

Author SHA1 Message Date
Jackson Kearl
4f870afa58 Enforce node boundaries in places where it matters (#53192)
* Enfoce node boundries in places where it matters

* Flip defualt emmet includeBoundries to true

Explicitly set getNode's include boundries where needed

* Remove defualt papameter

* Add update image boundry tests

* Add tests for bondries on some of the tag actions

* Rest of tag tests
2018-06-29 13:40:38 -07:00
Ramya Achutha Rao
f200964ed5 Fix Select next/item bug when cursor is at tag boundary 2018-06-27 21:48:05 -07:00
Ramya Achutha Rao
c3ad978982 Escape $ when wrapping Fixes #52640 2018-06-22 14:57:03 -07:00
James
b7e6e04666 fix #51768 (#51849) 2018-06-21 17:36:25 -07:00
Joao Moreno
8a3ffed0ab vsts: report smoketest results 2018-06-12 17:37:53 +02:00
Joao Moreno
4dc738593b complete integration test results 2018-06-12 17:24:23 +02:00
Jackson Kearl
0e97f85c39 Make Emmet: "update image size" consistant with "follow link" (#51630) 2018-06-11 11:46:06 -07:00
Jackson Kearl
21c02bad2e Enable emmet to function inside script templates. #51180 (#51256) 2018-06-06 14:14:24 -07:00
Jackson Kearl
cc84951f1e Allow Emmet "Go to matching pair" to work inside script tags (#51173)
* Allow Emmet "Go to matching pair" to work inside script tags

* Refactor template script detection and node extraction.

* Futher refactoring of Emmet template identification logic.

* Emmet: select entire script tag when unable to idnetify an inner element

* Remove redundant nullity check
2018-06-05 17:00:39 -07:00
Ramya Achutha Rao
90581c7f94 Dont trigger emmet for # in selectors Fixes #49269 2018-05-30 17:04:28 -07:00
Heldenkrieger01
30bcdffcb3 Fix #49777 - Emmet balance In after balance out should go back to initial selection and not first child (#49996)
* Update Emmet - balance.ts

* Cover all cases
2018-05-29 17:29:30 -07:00
Jean Pierre
7f274127ff Fix for #49138 (#49501)
* Fixes #49138

* Updated comment

* Renaming variables for readability
2018-05-13 20:31:50 -07:00
Ramya Achutha Rao
aaf7b29625 Dont treat => as possible tag Fixes #48887 2018-05-11 14:44:20 -07:00
Ramya Achutha Rao
979efb6b76 Allow ! as css abbreviation in property value Fixes #49214 2018-05-11 14:24:12 -07:00
Ramya Achutha Rao
57d9f26123 Disable live preview of wrap feature when multiple selections in same line #49138 2018-05-06 16:54:41 -07:00
Ramya Achutha Rao
0b634c4a87 Use specific document filters for file and untitled 2018-04-26 11:29:43 -07:00
Ramya Achutha Rao
79a2512769 Emmet: Allow css completions in style tag/attribute, html completions in script tags with html type 2018-04-22 21:49:56 -07:00
Ramya Achutha Rao
c314388da2 Move emmet from html extenstion to emmet extension 2018-04-22 21:49:56 -07:00
Ramya Achutha Rao
cfb6059563 Refactoring few emmet unit tests 2018-04-19 17:26:47 -07:00
Ramya Achutha Rao
efb3aefd99 temporary disabling failing tests 2018-04-13 18:03:30 -07:00
Ramya Achutha Rao
34adcb749a Dont depende on workspace settings for tests 2018-04-13 16:26:07 -07:00
Ramya Achutha Rao
e6b61067f2 Validate surrounding text before providing emmet completions in jsx/xml Fixes #47612 2018-04-10 16:14:56 -07:00
Ramya Achutha Rao
a786ed344e Cannot assign to read only property in nested settings #47316 2018-04-09 14:38:03 -07:00
Gus Hurovich
1b4886dda9 Adding setting for disabling partial parsing in stylesheets (#46979)
* Adding setting for disabling partial parsing in stylesheets

* Added description
2018-03-30 11:24:54 -07:00
Gus Hurovich
e252da3861 Adding tests for stylesheets partial parsing (#46977) 2018-03-29 17:48:32 -07:00
Ramya Rao
2de91fdce5 Css partial parse refactoring (#46894)
* Refactor parsePartialStylesheet

* More refactoring

* To avoid errors, parse line comments char by char and no when getting to previous line.

* Revert "To avoid errors, parse line comments char by char and no when getting to previous line."

This reverts commit f353dba4c7.

* Fix for inline comments inside block comments
2018-03-28 18:12:07 -07:00
Gus Hurovich
95b0cffe72 Fix for #46745 (#46788)
* Fix for #46745

* If { found in selector, don't partial parse.
Adding sanity checks
2018-03-27 18:32:46 -07:00
Ramya Achutha Rao
c2dc46c1ce Offset is relative to position when finding comment 2018-03-27 12:28:20 -07:00
Ramya Achutha Rao
c07abc03f7 Avoid parsing file when abbr is invalid #43470 2018-03-27 12:12:22 -07:00
Ramya Achutha Rao
f5b569b633 Use partial parsing for stylesheets for Emmet command #43470 2018-03-27 09:51:19 -07:00
Ramya Achutha Rao
65e502e8ef Remove unused variables 2018-03-26 21:19:35 -07:00
Ramya Achutha Rao
2792b8f437 Skip emmet inside comments in stylesheets when running the command 2018-03-26 20:47:09 -07:00
Ramya Achutha Rao
4f10555e3c Skip emmet inside comments in stylesheets #46434 2018-03-26 18:30:37 -07:00
Gus Hurovich
91416ffab8 Stylesheet partial parse (#46376)
* First draft at partial parsing of css for emmet

* Partial parsing of stylesheets for Emmet

* Addressing feedback

* Refactoring and fixing little bug

* Liitle fix

* Equals are now equals

* We don't want emmet in selectors

* Skip comments when preparsing

* Addressing feedback, refactoring and cleaning up code.

* Update endPosition only if not eof

* Use function to find closing comment

* Don't check more than 5000 characters back
2018-03-26 18:14:28 -07:00
Ramya Achutha Rao
871e610848 Respect selfClosingStyle when joining tags Fixes #44417 2018-03-26 15:05:04 -07:00
Ramya Achutha Rao
7db6419d78 Avoid re-parsing for emmet completions when triggered for incomplete completions 2018-03-26 13:33:38 -07:00
Ramya Achutha Rao
e7ce1f53ea Do not lookahead when extracting css abbreviations Fixes #46452 2018-03-23 17:38:38 -07:00
Jean Pierre
af21dc7925 Fix for #46106 (#46309) 2018-03-22 14:19:53 -07:00
Gus Hurovich
a716373aaa Adding Live Preview for Wrapping Individual Lines with Abbreviation (#45453)
* Adding Live Preview to wrapIndividualLinesWithAbbreviation

* Refactoring

* Re-arranging code
2018-03-13 21:34:52 -07:00
Ramya Achutha Rao
fa6a57bf47 Fix emmet tests 2018-03-13 00:07:05 -07:00
Ramya Achutha Rao
6d5739d3ec Remove obsolete code as html emmet completions are now coming from html extension 2018-03-12 23:47:09 -07:00
Ramya Achutha Rao
9d578694d0 Validate position for emmet using best guess fixes #45634 2018-03-12 23:39:38 -07:00
Ramya Achutha Rao
b7cf44841a Remove obsolete code as html emmet completions are now coming from html extension 2018-03-12 23:39:25 -07:00
Gus Hurovich
16b91c78f4 Emmet: when wrapping, skip lines with no characters selected (#45224)
* When wrapping using Emmet, don't consider lines with no characters selected.

* Adding unit tests

* Adding support for multicursors in wrapIndividualLinesWithAbbreviation

* Moving check in multicursor wrapIndividualLines

* Make sure when expanding several abbreviations with different snippets that the edits are applied in reverse order.
2018-03-09 16:49:07 -08:00
Gus Hurovich
2e746d8118 Emmet - Wrap with abbreviation with live preview (#45092)
* Revert "Fix for Emmet's wrap with abbreviation inserting extra spaces (#43345)"

This reverts commit 7420a04c64.

* Adding ability for emmet to wrap with abbreviation in real time.

Currently it's only working for single cursor.

* Fixes to wrap in real time:

- Removed flickering when typing abbreviation
- Removed tabstops
- Fixed bug when wrapping multiline text

* Fixes to a few issues.

- Added checks for not reverting previews more times than needed, that was causing extra text to be deleted.
- Fixed issue when wrapping nodes with multiple level of indentation.
- Removed all the undo commands. Now all the logic of going back to the original state is handled by revertPreview.

* Ammend for previous revert

* Reapplying reverted commit, fixing the bug for this branch's version

Refactoring some of the code, now a single object contains the current and original ranges, as well as the original content to wrap

* Adding multicursor support

* Renaming, refactoring and other stuff

* More refactorings

* More renaming and refactoring

* Replacing placeholders when previewing, simplifying the extracting of preceeding whitespace, added a check for validity of expandedtext on each selection.

* More refactoring

* Adding a comment.

* Readding test removed by mistake.

* Refactoring

* Carefully reverting changes in yarn.lock

* carefully but right
2018-03-06 17:11:07 -08:00
Ramya Achutha Rao
6e1574671a Use copy of config object to avoid making changes to the readonly objects 2018-03-05 10:22:01 -08:00
Ramya Achutha Rao
4392d2efff Trigger emmet in js files on ! Fixes #43841 2018-03-02 16:22:07 -08:00
Ramya Achutha Rao
c16869d804 Revert move of emmet to css extension Fixes #44840 2018-03-01 12:59:47 -08:00
Gus Hurovich
7420a04c64 Fix for Emmet's wrap with abbreviation inserting extra spaces (#43345)
* Fixing trailing spaces in expansion

* Emmet - Fixing extra spaces when wrapping with abbreviation

* Avoid fetching tag if there's no need to ezpand again

* Replacing several 'indexof's with regexp

* Making regexp for tagname stricter. Removing unnecessary check.

* Removing extra call to expand.

* tiny changes

* tinitiny changes
2018-02-14 17:08:44 -08:00
Ramya Rao
00f2d8ed71 Get emmet completions from css extension (#41652)
* Get emmet completions from html,css extensions

* Resolve extensionsPath, use emmet results even if empty

* Support css abbr with :

* Refactoring

* Add some basic emmet tests

* Refactoring

* More tests
2018-02-12 21:40:10 -08:00