Johannes Rieken
e51ef85bcb
Revert "allow $openUri to accept a URI and string, adopt consumer but keep the API as is"
...
This reverts commit 544b0abf5b
2019-11-15 10:29:29 +01:00
Johannes Rieken
544b0abf5b
allow $openUri to accept a URI and string, adopt consumer but keep the API as is
2019-11-15 10:28:03 +01:00
Matt Bierner
8079ff0001
Rename resolveExternalUri to asExternalUri
...
#81131
2019-09-30 14:22:47 -07:00
Benjamin Pasero
f0b99530c8
debt - implement window events and focus tracking
2019-09-26 08:13:58 +02:00
Matt Bierner
a62b7dabe7
Make resolveExternalUri return just a plain uri instead of a disposable result
...
For #81131
We had trouble coming up with cases where extensions could actually reliably dispose of the resolved uri
2019-09-23 10:58:21 -07:00
Matt Bierner
a817a588c7
Moving resolve uri logic into openerService
...
- Add a resolveExternalUri function to the opener service. This service already has to know how to resolve external uris so it makes sense that the function lives there
- Move the tunneling logic for desktop into window.ts
- Make result of resolve disposable
2019-09-20 17:17:42 -07:00
Matt Bierner
6710df4460
Allow tunneling when clicking on links in the terminal
...
Fixes #76175
2019-09-20 17:17:42 -07:00
Matt Bierner
93ba04b2b0
Move extractLocalHostUriMetaDataForPortMapping up to tunnel service
2019-09-20 17:17:42 -07:00
Matt Bierner
6a94ca4699
Delegate to embedder when resolving if one exists
2019-09-18 18:30:16 -07:00
Matt Bierner
27bac598cc
Basic implementation of resolveExternalUri
2019-09-18 18:20:26 -07:00
Benjamin Pasero
d5026ed3fb
fix #79453
2019-08-20 11:01:07 +02:00
Benjamin Pasero
ba69d8dccc
open exter - move into opener service
2019-08-14 08:33:50 +02:00
Johannes Rieken
4259b43f70
Revert "fix double encoding issue, https://github.com/microsoft/vscode-azure-account/issues/142 "
...
This reverts commit 781e61bf56
2019-07-08 09:56:49 +02:00
Matt Bierner
ae2cc878f8
Using DisposableStore in mainThread class
...
#74250
2019-07-02 16:37:35 -07:00
Matt Bierner
0358d08196
Re-use extractLocalHostUriMetaDataForPortMapping for openUri
2019-06-21 17:43:08 -07:00
Johannes Rieken
781e61bf56
fix double encoding issue, https://github.com/microsoft/vscode-azure-account/issues/142
2019-06-19 11:53:12 +02:00
Johannes Rieken
078da2bca6
This partially reverts "extends Disposable" changes
2019-06-06 16:01:15 +02:00
Matt Bierner
6b7b5c0e0c
Extend lifecycle/Disposable in more places instead of re-implementing it
...
`lifecycle/Disposable` includes some important fixes that can help catch common programming mistakes
2019-06-05 15:41:46 -07:00
Johannes Rieken
2335966361
use encodeURI on non-encoded uri when 'leaving' vscode, https://github.com/Microsoft/vscode/issues/25852
2019-04-17 14:11:53 +02:00
Matt Bierner
80a2614355
Only try tunneling openExternal when we actually need to
2019-04-15 15:28:03 -07:00
Matt Bierner
07f2fecd98
More webview ports
2019-04-10 11:47:11 +02:00
Johannes Rieken
c514d9e783
move mainThread[W], #70319
2019-03-19 17:37:07 +01:00
