Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 10:08:49 +01:00
Code Issues Packages Projects Releases Wiki Activity
50,020 Commits 3,657 Branches 358 Tags
e7a5f9a5e2e9a06d3265d42e599499f4116a8bb9
Commit Graph

3549 Commits

Author SHA1 Message Date
Matt Bierner
e7a5f9a5e2 Remove the vscode-core-resource scheme 
This is no longer required and complicates loading of resources. Use the standard `vscode-resource` scheme instead
 2019-06-12 11:17:59 -07:00
Johannes Rieken
1ad12b24a6 allow extension resources in editor insets 2019-06-12 18:09:34 +02:00
Sandeep Somavarapu
92fed79878 #74846 Dispose internal commands 2019-06-12 16:49:10 +02:00
Johannes Rieken
34c1f859cf remove gc-signals, heapservice, and mainThreadHeapService, #74846 2019-06-12 16:20:49 +02:00
Joao Moreno
08bb5a13c0 use toInternal2 
related to #74846
 2019-06-12 15:19:44 +02:00
Benjamin Pasero
7bc29bf67c debt - fix command alias (#75242) 2019-06-11 10:02:50 +02:00
Benjamin Pasero
eabd2c51a4 fix #69334 2019-06-11 09:54:48 +02:00
Peng Lyu
63672ffaa7 Merge pull request #74930 from microsoft/rebornix/commentreactions 
Comment Reaction API
 2019-06-10 10:36:21 -07:00
Matt Bierner
1e9fae2fba Partial fix for ExtHost CodeLenses registering commands after they have already been disposed of 
For #75105

This change ensures that we do not try registering a command while resolving a code lens. However it does not fix the issue where we can end up trying to invoke a command that has already been disposed of
 2019-06-07 18:26:19 -07:00
Matt Bierner
f8c8531e78 Merge pull request #75048 from mjbvz/add-lifecyle-for-code-actions 
Replace heapservice with lifecycle for code actions
 2019-06-07 10:28:05 -07:00
Johannes Rieken
5f91328fb1 fix layer breaker with credentials service, #74997 2019-06-07 12:02:42 +02:00
Matt Bierner
b4a00ca33f Replacing heapservice with lifecycle for code actions 
Part of #74846

Code Actions can use commands internally, which must be disposed of. We were previously using the heap service for this but this will not work for the web. Add a custom lifecycle instead
 2019-06-06 22:12:56 -07:00
Benjamin Pasero
eddc3f4a23 status - fix empty extension 2019-06-06 18:38:42 +02:00
Johannes Rieken
078da2bca6 This partially reverts "extends Disposable" changes 2019-06-06 16:01:15 +02:00
Johannes Rieken
2cd36100c4 Revert "Update more places where we are using an IDispoable[]" 
This reverts commit 869e5921d8.
 2019-06-06 15:31:23 +02:00
Benjamin Pasero
12fb60ec2e status - make id/name a static thing that cannot change 2019-06-06 10:27:07 +02:00
Benjamin Pasero
8a97df9520 status - change to id/name instead of category 2019-06-06 10:12:27 +02:00
Benjamin Pasero
943b78238b paper cut - offer a menu to control visibility of status bar entries 2019-06-06 07:36:06 +02:00
Peng Lyu
cae0668a0e reactions handler 2019-06-05 21:08:41 -07:00
Matt Bierner
bd39f3d7a1 Revert disposing of emitter change for extHostQuickOpen since it was breaking integration tests 2019-06-05 19:30:04 -07:00
Matt Bierner
a1c5ded681 Remove n-arg version of dispose 
This overload was not heavily used and added complexity
 2019-06-05 15:41:46 -07:00
Matt Bierner
6b7b5c0e0c Extend lifecycle/Disposable in more places instead of re-implementing it 
`lifecycle/Disposable` includes some important fixes that can help catch common programming mistakes
 2019-06-05 15:41:46 -07:00
Matt Bierner
88e7b22359 Use clearer name 2019-06-05 15:41:46 -07:00
Matt Bierner
a6ea8be992 Make sure we dispose of emitters in a few more places 
Emitters should be disposed of properly in order to help prevent leaks
 2019-06-05 15:41:45 -07:00
Matt Bierner
2c8de04126 Fix merge error related to disposables 2019-06-05 15:41:45 -07:00
Matt Bierner
0b4d3cd604 Remove use of IDisposable[] in a few more places 2019-06-05 15:41:45 -07:00
Matt Bierner
869e5921d8 Update more places where we are using an IDispoable[] 
Either extend `Disposable` or use a readonly `DispoableStore`
 2019-06-05 15:41:45 -07:00
Alex Ross
f3086a6e11 Remove sync fs use in tasks 
Fixes #70577
 2019-06-05 17:10:13 +02:00
Waldir Pimenta
f3e4e47164 Fix spelling of the example abbreviation (e.g.) 2019-06-05 16:00:26 +02:00
Christof Marti
3460fb97b0 Avoid __nodeRequire() (#74398) 2019-06-05 12:50:43 +02:00
Benjamin Pasero
01423e458d debt - move status message into notification status 2019-06-05 11:38:54 +02:00
Johannes Rieken
6a4467da59 for completions use CommandsConverter.toInternal2, #74846 2019-06-05 09:38:49 +02:00
Johannes Rieken
a73b4236b0 properly keep resolved code lens command, #74846 2019-06-05 09:38:49 +02:00
Johannes Rieken
35643d80e0 add lifecycle to code lens, #74846 2019-06-05 08:52:31 +02:00
Rachel Macfarlane
83ef31e6a2 Correctly set extensionId on comment threads 2019-06-04 11:50:47 -07:00
Johannes Rieken
6f1da34c2e debt - decouple webviews from code insets, move things to /browser/-layer, change inset api proposal to push style, re #66418 2019-06-04 12:31:18 +02:00
Peng Lyu
039b3e0a1a Merge pull request #74688 from microsoft/rebornix/fix#74641 
Fix #74641. Update viewzone afterline when position changes.
 2019-06-03 13:45:04 -07:00
Johannes Rieken
042efb5696 don't freeze vscode.env when running tests, #74121 2019-06-03 12:07:30 +02:00
Rachel Macfarlane
0284236851 Fix #74668, old comment API not adding comments 2019-05-31 12:00:24 -07:00
Peng Lyu
c042dabe2b Fix #74641. Update viewzone afterline when position changes. 2019-05-31 10:27:56 -07:00
Johannes Rieken
59794815ce when adding contributed keybindings check if a command with enablement-clause exists 2019-05-31 12:39:40 +02:00
Matt Bierner
483e48d875 Fix sorting of source code actions being reversed 
Fixes #73344
 2019-05-30 11:30:45 -07:00
Rachel Macfarlane
2185280ed5 Update commentThread/context and comment/context contribution descriptions, fixes #74552 2019-05-29 09:59:36 -07:00
Johannes Rieken
5cfeefdaa9 remove vscode.env.remoteAuthority API, #74188 2019-05-29 10:33:48 +02:00
Johannes Rieken
a429fd1356 refine remoteAuthority-api, #74188 2019-05-28 18:00:07 +02:00
Johannes Rieken
034165ac67 don't cache provider results when request was cancelled, #74446 2019-05-28 12:15:53 +02:00
Johannes Rieken
6526507326 💄 remove unused kind-property from SelectionRange 2019-05-27 17:04:40 +02:00
Johannes Rieken
6a1574e21e add vscode.env.remoteAuthority-api, #74188 2019-05-27 11:51:08 +02:00
Alex Dima
022835ea42 Connect to the remote extension host 2019-05-24 18:33:29 +02:00
Daniel Imms
93f93d0961 Merge remote-tracking branch 'origin/master' into tyriar/72518_runInBackground 2019-05-24 06:16:37 -07:00