Commit Graph

4287 Commits

Author SHA1 Message Date
Matt Bierner 5ec2e40b21 Fixing webview getting disposed after rename
For #83961
2019-11-25 22:38:02 -08:00
Matt Bierner d4ab1fcda5 Fixes more node 12 typing errors (#85420)
* Fixes more node 12 typing errors

For #82514

* Remove Symbol.toStringTag usage for now

* Reverting a few fixes that are not comptible with current node typings

* Revert one more use of StringDecoder

Must wait until we actually pick up the new typings
2019-11-25 19:30:21 -08:00
Matt Bierner 85d3ccfb9e Fix custom editor redo 2019-11-25 15:44:25 -08:00
Matt Bierner 750f28769d Sync custom editor edits
If multiple instances of the same  custom editor are opened for the same resource, the edit stack should be shared between them. This matches how we work with text files
2019-11-25 15:44:25 -08:00
Matt Bierner f3d70dbf92 Working on sharing models for same custom editor 2019-11-25 15:44:25 -08:00
Matt Bierner b52f1c7dae Trying to hook up background to implement custom editor rename 2019-11-25 15:44:25 -08:00
Matt Bierner ffe3749d5a Working on hooking up custom editor saveAs 2019-11-25 15:44:25 -08:00
Johannes Rieken b04c6f9e2e update API command for #85533 2019-11-25 17:06:16 +01:00
Johannes Rieken 9227460df4 don't over-encode, do try to decode, fixes #85521 2019-11-25 16:58:54 +01:00
Matt Bierner 9b89cca38e Working on hooking up revert properly for custom editors 2019-11-22 15:18:01 -08:00
Matt Bierner e4fc57dcd2 Don't convert json edit data tostring 2019-11-21 20:09:56 -08:00
Matt Bierner 7d120c2d3e Use chaining 2019-11-21 20:09:56 -08:00
Andre Weinand b2e2e78c88 make '${file}' equivalent to TextDocument.fileName 2019-11-21 13:26:38 +01:00
Alex Dima acd7df1459 Use ILogService instead of console (#84283) 2019-11-21 10:14:31 +01:00
Matt Bierner 4cc8710a38 Add CodeAction.disabled
For #85160
2019-11-20 17:10:00 -08:00
SteVen Batten 8eaf2a3742 rename splitview panels to panes (#85166)
* rename splitview panels to panes

* rename files

* customViewPane
2019-11-20 10:59:22 -08:00
Andre Weinand e38b49b5a3 restructure variable resolver 2019-11-20 17:36:09 +01:00
Alex Ross 9dcd33183c Finalize tree view title API
#84466
2019-11-20 10:26:20 +00:00
Daniel Imms d630afbbb0 Fix strictFunctionTypes in extHostTerminalService
Part of #81574
2019-11-19 11:13:59 -08:00
Daniel Imms 96f91be3fa Merge pull request #84181 from solomatov/pty_bug
Fix bug with hanged pseudoterminal
2019-11-19 10:57:31 -08:00
Johannes Rieken eff2320473 check timeout on extension host, blame extension when exceeded, #43768 2019-11-19 12:36:42 +01:00
Johannes Rieken 839719d489 simplify AsyncEmitter usage 2019-11-19 12:11:19 +01:00
Johannes Rieken 094fd80e20 adding configurable timeout, #43768 2019-11-19 11:37:36 +01:00
Alexandru Dima 9cfb2fd998 Reduce memory usage: Do not cache TextDocument.lineAt (#84940) 2019-11-19 10:53:57 +01:00
Matt Bierner 2f253d2ee8 Fixing a few more strict function type errors
For #81574
2019-11-18 15:35:11 -08:00
Konstantin Solomatov 7a18410412 Merge remote-tracking branch 'upstream/master' into pty_bug 2019-11-18 14:39:49 -08:00
Andre Weinand 7a89ac693b Make debugging independent from node APIs; fixes #85076 2019-11-18 23:03:00 +01:00
Matt Bierner 8bbe3157f0 Trying to hook up basic save for custom editors 2019-11-18 11:27:45 -08:00
Christof Marti 8031c495a6 Add option to skip sorting QuickPick items (#73904) 2019-11-18 17:09:31 +01:00
Peter Elmers e9c0aeb8b0 Add optional sortByLabel to QuickPick to control whether to re-sort items when query changes
Summary:
Address issue #73904 by adding an optional `sortByLabel` to the QuickPick class which determines whether the picker re-sorts the result list when the user types in the input field.

If true, the picker applies a sort to order results by the index of the first appearance of the input in the label.

For backwards compatibility, this field is true by default.

https://github.com/microsoft/vscode/issues/73904

Test Plan:
attached video shows behavior both before and after

{F167292605}

note: there aren't any existing tests on what happens when the query input changes in the QuickPick

Reviewers: dalongi, ericblue, hchau

Reviewed By: ericblue

Differential Revision: https://phabricator.intern.facebook.com/D16203434

Signature: 16203434:1562878837:5413e3852f2bd04c8e81b9fe5c4a08127dfe3b65
2019-11-18 17:09:29 +01:00
Daniel Imms 8848a0df2a Merge branch 'master' into pty_bug 2019-11-18 07:19:36 -08:00
Sandeep Somavarapu 0282585dd7 Fix #83171 2019-11-18 15:04:08 +01:00
Johannes Rieken c977eb647e tweak events and add some jsdoc, #43768 2019-11-18 14:20:41 +01:00
Johannes Rieken 6d541cae40 simpler edits collection, #43768 2019-11-18 14:02:42 +01:00
Johannes Rieken 6536592dac allow workspace edit in all will-events, #43768 2019-11-18 13:54:12 +01:00
Alexandru Dima 47dfc2debf Avoid having very small delta areas 2019-11-18 11:34:13 +01:00
Alexandru Dima 22ff01e6ff Fix issue when areas with 0 tokens would be used for delta encoding 2019-11-18 09:41:10 +01:00
Alexandru Dima 41be9a6142 Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-18 08:59:14 +01:00
Benjamin Pasero 9727eb6050 untitled - fix save with associated file path 2019-11-18 07:57:48 +01:00
Daniel Imms 649ef05dfb Fix ws 2019-11-17 12:55:10 -08:00
Daniel Imms f329ef3753 Merge dimensions into awaiting object 2019-11-17 12:54:38 -08:00
Daniel Imms 6d7f763548 Only set _extensionTerminalAwaitingStart when deferred start is needed 2019-11-17 12:52:17 -08:00
Daniel Imms 1004d51605 Merge branch 'master' into pty_bug 2019-11-17 12:35:57 -08:00
Daniel Imms c3e3b16899 Merge branch 'master' into cleanup_ext_host_terminals 2019-11-17 12:29:21 -08:00
Benjamin Pasero 00688bf051 working copies - properly implement save, saveAs, saveAll (#84672) 2019-11-17 17:44:57 +01:00
Matt Bierner 27a33ee6fe Hook up very basic undo/redo for webview editors
For #77131
2019-11-15 18:21:46 -08:00
Matt Bierner 7ac686d6cc Working on hooking up undo/redo for custom editors 2019-11-15 15:53:25 -08:00
Alexandru Dima ca81ca47db More changes for #81574 2019-11-15 18:02:35 +01:00
Benjamin Pasero 72c2f506de working copy - introduce first save/revert semantics (#84672) 2019-11-15 15:36:55 +01:00
Johannes Rieken 261ef3e7e6 Merge pull request #84812 from microsoft/joh/opener
OpenerService supporting URI and URL
2019-11-15 15:31:38 +01:00