Commit Graph

1574 Commits

Author SHA1 Message Date
Matt Bierner e81aceaa07 Merge pull request #226541 from mjbvz/involved-gopher
Remove allowImportingTsExtensions from created tsconfigs
2024-08-24 14:18:44 -07:00
Matt Bierner e348be6b66 Remove allowImportingTsExtensions from created tsconfigs
Fixes #226108
2024-08-24 14:00:35 -07:00
Matt Bierner 89f2077c35 Merge pull request #226485 from mjbvz/informal-echidna
Enable ATA on web by default again
2024-08-23 13:30:54 -07:00
Matt Bierner bedf9f4ab7 Enable ATA on web by default again
For #182791

Enabling for further testing
2024-08-23 13:14:54 -07:00
Andrew Branch 7b357dd3a5 [typescript-language-features] Add autoImportSpecifierExcludeRegexes preference 2024-08-21 12:10:36 -07:00
Matt Bierner aeb66cd959 Merge pull request #209293 from iisaduan/organize-imports-settings
add settings for typescript's organizeImports to the settings interface
2024-08-16 14:38:53 -07:00
Matt Bierner ddbe321368 Remove presets for now
https://github.com/microsoft/typescript/issues/59579
2024-08-16 13:01:03 -07:00
Kat Marchán d751e4324d stop AutoInstallerFs from thrashing forevermore and fix typings installer (#225648)
stop AutoInstallerFs from thrashing forevermore
2024-08-15 18:48:29 -07:00
Matt Bierner c3fdd34df5 Fix commit character list
We were modifying the default commit character array, which ended up making it thousands of elements long
2024-08-13 14:36:56 -07:00
Matt Bierner 4a4c36209f Remove old jsdoc link handling (#225529)
This code was used when TS Server didn't have support for `@link`. I think we can remove it now
2024-08-13 14:23:40 -07:00
Matt Bierner a116536a91 Remove TS 3.x feature gates
We see very, very low usage of these old TS versions. We also don't actively test them or fix bugs for them
2024-08-13 11:12:10 -07:00
Matt Bierner aefef1e336 Add more telemetry for global TS plugins (#225143)
* Add more telemetry for global TS plugins

Log the hashed name of the global TS plugins so we can correlate issues to them

* Remove trailing comma
2024-08-08 19:18:46 -07:00
Gabriela Araujo Britto 6cbbd1012a [typescript-language-features] fix diagnostics telemetry property name (#225079)
fix diagnostics telemetry property name
2024-08-08 11:52:15 -07:00
Matt Bierner b7e421b734 Fix arguments for create tsconfig/jsconfig (#224990)
Fix arguments for create tsconfig/jsconfig

Fixes #224989

Adds typings too to prevent this again
2024-08-06 16:04:21 -07:00
Matt Bierner 4a532e3376 Use trace logger for ATA file systems (#224892)
Makes enabling logging easier and more consistent
2024-08-05 15:59:10 -07:00
Matt Bierner a1572d3b7a Try to fix typings perf issues on web (#224640)
Try to fix ata perf issues on web

For #182791

With this change, we now make a single call to the package manager per root instead of per package. This simplifies the code and should be better for perf

Still seeing a bunch of errors in the console but TS typing is working ok. Needs more exploration for ATA
2024-08-02 14:21:22 -07:00
Matt Bierner fd5f15a2b3 Don't watch in-memory resources (#224535)
Fixes #221583
2024-08-01 17:22:31 -07:00
Anees Ahee 7d0a6b8a0a Fix missing "Restart TS Server" command in Command Palette (#223433)
Update TypeScript context keys when tab groups changed

Co-authored-by: Matt Bierner <matb@microsoft.com>
2024-07-30 14:33:33 -07:00
Gabriela Araujo Britto 6a33b7a382 [typescript-language-features] Use commit characters from tsserver when available (#223541)
use commit characters from tsserver when available
2024-07-29 13:57:03 -07:00
Matt Bierner a105ce80a3 Bump web TS version (#223552) 2024-07-24 15:21:17 -07:00
Matt Bierner 7d59bab235 Add telemetry on how often server crashes are potentially due to TS service plugins (#223551)
Add telemetry on how often server crashes are potentially due to TS server plugins

Simple flag which tracks if plugins are enabled/disabled
2024-07-24 15:20:38 -07:00
Matt Bierner ea0d7033cf Properly gate type acquisition on web (#223403)
For #221299

Make sure we don't register the file system at all in these cases
2024-07-23 15:12:34 -07:00
Matt Bierner febad5e489 Handle empty edits for TS paste (#222109)
Should use default paste in this case. Talking with TS if this should be handled differently from the server but worth adding the workaround for now
2024-07-18 12:34:03 -07:00
Matt Bierner 6eb023ca6f Fix version for web TS (#221992) 2024-07-17 14:41:02 -07:00
Gabriela Araujo Britto 14cf5001ec [typescript-language-features] Add diagnostics performance telemetry (#220127)
* WIP

* invalidate diagnostics in range

* check whether should use region based diagnostics

* add ts-expect-errors

* make region opt off by default

* bump to expected 5.6

* update comments to refer to 5.6

* make region diagnostics on by default for insiders

* add telemetry for diagnostics performance

* add file line count

* remove comment

* use block on case

* add ts-expect-error

* declare interface earlier in file

* address review comments
2024-07-12 17:03:45 +00:00
Matt Bierner 9469c82f9f Don't allow insiders users to report issues with TS plugins enabled (#219902)
Seeing far too many users not reading the warning/issue text before reporting issues. These reports are rarely actionable
2024-07-04 01:12:04 +02:00
Gabriela Araujo Britto 878af0771b [typescript-language-features] Region-based semantic diagnostics for TypeScript (#208713)
* WIP

* invalidate diagnostics in range

* check whether should use region based diagnostics

* add ts-expect-errors

* make region opt off by default

* bump to expected 5.6

* update comments to refer to 5.6

* make region diagnostics on by default for insiders
2024-06-19 15:12:57 -07:00
Matt Bierner d662a014f4 Make pasting canceling ongoing geterr requests (#216089)
Should speed up pasting
2024-06-19 10:22:00 -07:00
Matt Bierner 61eba45dc4 Don't register js/ts paste provider if setting is off (#216168) 2024-06-17 15:14:59 -07:00
Matt Bierner 94274c47b8 Skip interrupting geterr in automatic cases (#215389)
Quick fixes already don't interrupt `geterr` requests so this likely won't slow down the automatic lightbulb
2024-06-12 14:29:41 -07:00
Matt Bierner b7e5750fa9 Restrict copy/paste with imports to TS 5.6+ (#215386)
Also skips when the copied file is the same as the paste file
2024-06-12 22:20:46 +02:00
Matt Bierner df2861b737 Pick up TS 5.5 for builtin ts extension (#214170)
For #214169
2024-06-03 21:07:18 +02:00
Matt Bierner b1ecfe96b5 Don't use shell for spawning node (#213960)
Fixes #204678
2024-05-30 17:08:47 -07:00
Alexandru Dima 8f78098b37 Ensure inline chat is started with a good initial selection (#213860) 2024-05-29 15:59:54 -07:00
Matt Bierner d0d79c231f Fix js/ts cross code block intellisense (#213726)
We need to register support for the backing copilot scheme too, not just the panel scheme in core
2024-05-28 13:43:20 -07:00
Benjamin Pasero 2188b46e88 ts - enable use code watcher by default (#213450) 2024-05-25 12:48:33 +02:00
Matt Bierner 934af755c4 Hook up prototype paste with imports for JS/TS (#204665)
* Hook up prototype paste with imports for JS/TS

For https://github.com/microsoft/TypeScript/pull/57262 but with proposed changes to ts protocol

* Support new api

* Update
2024-05-24 21:57:30 +02:00
Matt Bierner fb7f5a9a83 Disable web TS type acquisition (#213412)
We're waiting on some perf improvement for upstream types installer before turning this on everywhere
2024-05-24 21:51:41 +02:00
Matt Bierner 85fe2e2daf Update for latest code mapper proposal (#213256) 2024-05-22 22:10:07 +02:00
Matt Bierner 001b81c683 Disable VS Code file watching for yarn pnp (#213238)
Disable VS Code file watching on yarn pnp
2024-05-22 18:43:55 +02:00
Walker Boyle 3bda9ff4f7 fix: tsserver no longer crashes when log path includes spaces (#212752) 2024-05-21 18:01:17 +00:00
Matt Bierner daec93b827 Disable web ata for safari (#212726) 2024-05-14 11:12:28 -07:00
Robo 5216c04428 chore: update to electron 29 (#209818)
* chore: update electron@29.1.0

* chore: update typings to 20.x

* chore: bump electron@29.1.5

* ci: fix crash in compiling extensions-ci

* chore: disable .d.ts check for build/

$ ../node_modules/.bin/tsc -p tsconfig.build.json
node_modules/@types/chokidar/index.d.ts:21:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/@types/chokidar/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

21 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
                ~~~~~~~~~

node_modules/chokidar/types/index.d.ts:8:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/chokidar/types/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

8 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
               ~~~~~~~~~

Found 2 errors in 2 files.

Errors  Files
     1  node_modules/@types/chokidar/index.d.ts:21
     1  node_modules/chokidar/types/index.d.ts:8

Refs https://github.com/paulmillr/chokidar/commit/a0f9e09f64ce7ae70cc6ae1f5615f65cb35f532f

* chore: update core types

* temp: fix layer validation

* chore: update nodejs checksums

* ci: use latest v20 LTS for missing node-gyp

Refs https://github.com/npm/cli/commit/eacec5f49060d3dfcdc3c7043115619e4bb22864

* ci: define LIBCPP_HARDENING_MODE

* ci: fix crash in vscode-web-min-ci

* chore: update rpm deps-list

* chore: bump tree-sitter-typescript@0.20.5

* chore: bump electron@29.3.0

* chore: bump electron@29.3.1

* chore: update rpm deps-list for x86_64

* ci: disable io_uring UV backend on linux

* ci: disable io_uring backend for oss as well

* chore: update typings to 20.x

* ci: add TODO for io_uring workaround

* chore: bump distro

* chore: update preinstall node version checks

* chore: update @types/gulp

Refs https://github.com/microsoft/vscode/issues/212442

* ci: disable io_uring in more test suites
2024-05-11 01:20:28 +09:00
Matt Bierner a4643b0ee0 Enable web type acquisition by default for js/ts (#212370)
* Enable web type acquisition by default for js/ts

Fixes #182791
Fixes #172887

* Cleanup
2024-05-09 20:09:49 +02:00
Matt Bierner 268c20f317 Suppress semantic errors in js/ts notebook cells (#212367)
Fixes #212366
2024-05-09 10:20:21 -07:00
Matt Bierner 59a90a6dab Pass along autoImport setting on TS file settings (#211803) 2024-05-01 12:23:30 -07:00
Matt Bierner 431afbe459 Log trigger reason in TS refactor telemetry (#211652) 2024-04-30 11:27:07 -07:00
Matt Bierner bc278dfe7c Fix workspace symbol search (#211681)
For #211672
2024-04-29 17:54:50 -07:00
Matt Bierner c1cc1a902d Remove most <type> assertions in TS ext (#211648)
These can easily hide typing errors
2024-04-29 18:23:51 +02:00
Matt Bierner 5d25f31b7e Re-register TS sort/remove unused commands (#210984)
Fixes #210728

Removed these as I thought they were unused
2024-04-22 20:16:38 -07:00