Commit Graph
124157 Commits
Author SHA1 Message Date
Connor Peet 709db7827f editor: include lane in GUTTER_GLYPH_MARGIN hover events
Also fixes handling of testing clicks and margin hovers which were not
aware of multiple lanes. Hover messages are now shown correctly and
tests no longer run if e.g. a breakpoint decoration on the same line is
clicked.

Note sure if this was the best way to do this, let me know.
2024-01-10 15:39:38 -08:00
Connor Peet 24963b3812 editor: fix decoration lane assignment with word wrap 2024-01-10 15:39:38 -08:00
Peng LyuandGitHub ebd680e7e8 Merge pull request #202191 from microsoft/rebornix/proposed-hummingbird
Restore focus back to cell when chat widget is dismissed
2024-01-10 15:32:11 -08:00
Matt BiernerandGitHub 8f32885359 Use markdown engine to enable/disable smart paste (#202192)
Fixes #188863
Fixes #188958
Fixes #188868

This is more reliable than using the regular expressions. However the regular expressions are still needed for inline elements
2024-01-10 14:32:58 -08:00
Rob Lourens 05548e8124 More type fixes, remove unneeded 'kind' 2024-01-10 19:28:57 -03:00
rebornix 112ffbd4c9 Merge remote-tracking branch 'origin/main' into rebornix/proposed-hummingbird 2024-01-10 14:21:58 -08:00
Rob Lourens 4aca61d43b Fix 2024-01-10 19:20:29 -03:00
rebornix 7ca79f837f Restore focus back to cell when chat widget is dismissed 2024-01-10 11:50:24 -08:00
rebornix c83486e790 Add generate button to notebook toolbar 2024-01-10 11:44:53 -08:00
rebornix 4bac474bf6 Update widget layout 2024-01-10 11:42:44 -08:00
Rob Lourens 518fd1e0de Merge chat variables proposal into chatAgents2 proposal 2024-01-10 16:42:29 -03:00
rebornix 89ccca8cfc Allow notebook customize widget toolbar 2024-01-10 11:41:22 -08:00
Matt BiernerandGitHub 0bb69da87c Add new smartWithSelection option for markdown links (#202183)
This becomes the new default while `smart` always smartly pastes, even with no selection
2024-01-10 20:01:52 +01:00
Johannes RiekenandGitHub 115155df62 Add test that asserts stream is done when the request is done (#202184)
test that asserts stream is done when the request is done

manifests fixing https://github.com/microsoft/vscode-copilot/issues/3345
2024-01-10 10:48:10 -08:00
Benjamin PaseroandGitHub 53d7995f47 ENOSPC though no workspace (fix #201923) (#202180) 2024-01-10 10:46:33 -08:00
Connor PeetandGitHub 7dab57d216 ensureNoDisposables leaked in base/common code (#202175)
* ensureNoDisposables leaked in base/common code

* more
2024-01-10 19:28:26 +01:00
Matt BiernerandGitHub 39e866b964 Pick up latest markdown-it-katex (#202178) 2024-01-10 19:04:33 +01:00
Connor PeetandGitHub f5952f92c0 monaco: improve handling of glyph margins (#202102)
* monaco: improve handling of glyph margins

In my previous PR #202048, I added another glyph margin lane. However
I didn't realize in some cases the support I added was incomplete since
the rendering code did not fully handle an unbounded number of lanes.

Also, I noticed in existing issues with hover and click handling because
some parts of VS Code still assume there's at most a single glyph widget
visible. It is hard to determine which glyph widget is interacted with
without checking what classes are applied to the glyph element, which
is what most existing code does. And we probably shouldn't do that in
e.g. the MouseHandler to determine what glyph is being clicked on.

So in this PR I added a `GlyphMarginLanesModel` that contains the
information necessary for rendering. I also want to expose it in a place
that the MouseHandler or MouseTarget can get at, but I wasn't sure the
best way to do that, any suggestions @alexdima?

Implementation-wise I opted for a flag Uint8Array. A 1024 line file with
decorations on the last line, it would take 384 bytes to hold decoration
positions. I also tried out a Range array based implementation, but I
think this is faster (for cases where there are lots of decorations)
and much simpler, in exchange for higher memory usage in edge cases
(very long files with decorations near the end.)

* allow lanes to be persisted to avoid jumping bp icons
2024-01-10 09:07:40 -08:00
Connor PeetandGitHub 6fced49205 testing: update testingActiveProfile proposal to final implementation (#202116)
* testing: update testingActiveProfile proposal to final implementation

* update tests
2024-01-10 18:07:15 +01:00
Benjamin PaseroandGitHub 1e9f0887fb window - push down static method to base (#202162) 2024-01-10 16:03:25 +01:00
Benjamin PaseroandGitHub 74da22bb03 ENOSPC though no workspace (fix #201923) (#202161) 2024-01-10 15:49:48 +01:00
Benjamin PaseroandGitHub b6d977789e Screen cheese when reloading with a notebook in a floating window (fix #201832) (#202159) 2024-01-10 15:48:23 +01:00
Johannes RiekenandGitHub 8ffbf09e31 Clear edit queue when request errors, tweak Queue/Limiter, tests (#202157)
* don't drag targetWindow all the way across all the layers

* add `ILimiter#clear`, add tests and define onDrain and clear behaviour

* fix compilo

* Queue/Limit - clarify onDrain timing, make sure it fires only once, add whenIdle

* chat - clear edit queue on error, adopt whenIdle

* add test to ensure progress edit stream stop on being cancelled
2024-01-10 15:27:09 +01:00
Benjamin PaseroandGitHub ff7dcf2974 zoom - fix some issues (#202158) 2024-01-10 15:25:42 +01:00
Benjamin PaseroandGitHub fc3df618cb workspace.fs.delete useTrash option is not respected (fix #201742) (#202156) 2024-01-10 15:22:40 +01:00
Louis LazarisandGitHub 89eb2de093 Corrected CSS Hover Documentation text (#202142) 2024-01-10 13:42:16 +00:00
Louis LazarisandGitHub 314c9891c3 Fixed some CSS terminology (#202125) 2024-01-10 12:44:25 +00:00
Sandeep SomavarapuandGitHub 572198c07d add more logging (#202139) 2024-01-10 10:33:49 +01:00
Sandeep SomavarapuandGitHub ba2f50ca50 fix #71846 (#202132) 2024-01-10 09:27:19 +01:00
Johannes RiekenandGitHub ad68ddc7aa allow to set/configure ariaLabel for IButton (#202127)
fixes https://github.com/microsoft/vscode/issues/201527
2024-01-10 13:19:44 +05:30
Sandeep SomavarapuandGitHub dd7a20db89 fix #142478 (#202126) 2024-01-10 08:39:00 +01:00
Sandeep SomavarapuandGitHub 6bf996da2b adopt ensureNoDisposablesAreLeakedInTestSuite (#202121)
#200091 adopt ensureNoDisposablesAreLeakedInTestSuite
2024-01-10 07:32:20 +01:00
Connor PeetandGitHub ea77026ab9 Merge pull request #166202 from gayanper/wait_for_breakpoint
Add support for breakpoint dependencies
2024-01-09 22:29:02 -08:00
Connor Peet 207197a5e5 one more place 2024-01-09 16:54:55 -08:00
Connor Peet a308dde7c6 wait to resume until breakpoint is set, align vocabulary 2024-01-09 16:51:19 -08:00
Connor Peet c116ed3234 Merge remote-tracking branch 'origin/main' into pr/gayanper/166202-1 2024-01-09 16:32:10 -08:00
Ladislau SzomoruandGitHub c973ec7673 SCM - fix border radius for checkout/sync actions (#202106) 2024-01-09 14:40:39 -08:00
Henning DieterichsandHenning Dieterichs ad18bb00ce Fixes #199351 2024-01-09 23:40:26 +01:00
Matt BiernerandGitHub 35579c0b57 De-prioritize markdown link paste in code blocks (#202109) 2024-01-09 14:27:28 -08:00
Henning DieterichsandGitHub 05dfba857a Adopts #199291 for SCM view changes. (#202077) 2024-01-09 22:28:08 +01:00
Henning DieterichsandHenning Dieterichs 0a284dde18 Introduces _workbench.openMultiDiffEditor 2024-01-09 22:13:18 +01:00
Megan RoggeandGitHub a3445c68a0 handle alerts in audio cue service, add List Alerts command and settings (#201833)
* massive refactor
2024-01-09 21:03:19 +01:00
Connor PeetandGitHub 801d79e284 Merge pull request #202048 from microsoft/connor4312/test-coverage-decorations-1
testing: add initial editor decorations
2024-01-09 11:20:46 -08:00
Ronak JainandGitHub c1bc5415f8 Fix tsserver crashing when using custom node path (#201966)
* use quotes in spawned process name

* Use JSON stringify to handle quotes as well
2024-01-09 11:02:53 -08:00
Aleksandr KondrashovandGitHub eae814bef6 Update IExplorerView interface (#201992) 2024-01-09 18:06:59 +00:00
Alex RossandGitHub a6659cb883 API feedback for comment reactor (#202098)
Part of #201131
2024-01-09 09:41:54 -08:00
Raymond ZhaoandGitHub fb84f3bcfb test: skip flaky Settings editor smoke test (#202097) 2024-01-09 18:16:42 +01:00
Sandeep SomavarapuandGitHub 5b1893b24b fix #195150 (#202093) 2024-01-09 17:55:55 +01:00
dependabot[bot]GitHubdependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
9c2e81f9f6 Bump follow-redirects from 1.15.3 to 1.15.4 in /extensions/github-authentication (#202055)
Bump follow-redirects in /extensions/github-authentication

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.15.3...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-09 08:53:01 -08:00
Alexandru DimaandGitHub 4ec14ee326 Fix constant expression (#202092) 2024-01-09 17:48:53 +01:00