Commit Graph
124157 Commits
Author SHA1 Message Date
Logan RamosandGitHub e2f7dc558d Adopt ensureNoDisposablesAreLeakedInTestSuite in my tests (#200153)
* Adopt ensureNoDisposablesAreLeakedInTestSuite in my tests

* Update eslint
2023-12-06 17:35:42 +01:00
Benjamin PaseroandGitHub ec2c8e18c4 workspaces - discard untitled workspace based on setting (#200154) 2023-12-06 17:34:28 +01:00
Aiday Marlen Kyzy bc286f4913 removing logs 2023-12-06 16:42:50 +01:00
Isidor NikolicandGitHub 626122ea97 Merge pull request #197729 from Flanker32/update-java-workspace-tags
Update java workspace tags
2023-12-06 15:32:28 +00:00
Johannes RiekenandGitHub 97dd8691d8 sequentialize event handling for text document content events (#200149)
fixes https://github.com/microsoft/vscode/issues/179711
2023-12-06 16:29:26 +01:00
Benjamin PaseroandGitHub a187ad1ca3 end - adopt more ensureNoDisposablesAreLeakedInTestSuite (#200145) 2023-12-06 16:01:23 +01:00
Aiday Marlen Kyzy 29d7057198 review changes 2023-12-06 15:49:39 +01:00
Logan RamosandGitHub 32f7261976 Bump distro (#200143) 2023-12-06 15:45:34 +01:00
Benjamin PaseroandGitHub f068e42b73 Allow to swap left and right hand side in diff editor (fix #20958) (#200138) 2023-12-06 14:56:41 +01:00
Aiday Marlen Kyzy 74177787a4 adding parentheses 2023-12-06 14:17:37 +01:00
Alexandru DimaandGitHub 16c93d6f5f Merge pull request #198559 from hickford/highlight
highlight whole line when word wrap enabled
2023-12-06 14:08:19 +01:00
samhanic c210448601 CLI update extension review fixes 2023-12-06 13:54:02 +01:00
Alex Dima 1bfc2adbad Simplify logic 2023-12-06 13:53:36 +01:00
Aiday Marlen Kyzy 88e857430c refactoring the content hover ts file 2023-12-06 13:43:10 +01:00
Henning DieterichsandHenning Dieterichs 46e43573e4 Fixes #182087 2023-12-06 13:21:20 +01:00
Aiday Marlen KyzyandGitHub e241358e6a Merge branch 'main' into aiday/checkingEffectiveLineCount 2023-12-06 13:05:11 +01:00
Aiday Marlen Kyzy 6fc4a88d85 placing on one line 2023-12-06 13:01:06 +01:00
Henning DieterichsandHenning Dieterichs 6d1f607c6d Fixes #178259 2023-12-06 12:49:13 +01:00
Aiday Marlen Kyzy 4654615a98 placing the check before the effective line number is increased 2023-12-06 12:39:26 +01:00
Johannes RiekenandGitHub acf3fc61ea delay _savePartSplash further, fixes https://github.com/microsoft/vscode/issues/170825 (#200126) 2023-12-06 12:29:05 +01:00
Aiday Marlen Kyzy 5afabd2da9 setting the hover settings in an interface 2023-12-06 12:27:54 +01:00
cffff4c0da Fix locking groups with aux windows (#200039)
* Aux Locking

* 💄

* 💄

* unlock last group

* 💄

* 💄

* unlock from editor parts

* 💄

* .

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-12-06 12:23:18 +01:00
Aiday Marlen Kyzy 40e68b7fde refactoring hover.ts file 2023-12-06 12:22:42 +01:00
Johannes RiekenandGitHub 3056f52f92 add failing/skipped test for https://github.com/microsoft/vscode/issues/191070 (#200125)
* fix --dev option of unit tests fyi @joaomoreno

* fix timing issue when getting line, add failing/skipped test for https://github.com/microsoft/vscode/issues/191070
2023-12-06 12:16:49 +01:00
Benjamin PaseroandGitHub 5455d20ce1 debt - adopt ensureNoDisposablesAreLeakedInTestSuite in more tests (#200116)
* debt - adopt `ensureNoDisposablesAreLeakedInTestSuite` in more tests

* .

* .

* .
2023-12-06 12:09:11 +01:00
Benjamin SimmondsandGitHub 52ca689ee7 ensureNoDisposablesAreLeakedInTestSuite (#200115)
* ensureNoDisposablesAreLeakedInTestSuite

* 💄
2023-12-06 11:51:56 +01:00
Benjamin PaseroandGitHub 7ef3fef402 debt - relax product.json type (#200122) 2023-12-06 11:35:51 +01:00
Justin ChenandGitHub 4693a093c7 Revert: Allow non-AI actions on empty lines (#200097)
reverting ai only code actions on empty lines
2023-12-06 11:13:08 +01:00
Benjamin PaseroandGitHub 38267ff797 Add the option to skip the prompt to save the workspace config (fix #187794) (#200114)
* wip

* .

* .
2023-12-06 10:08:16 +00:00
Aiday Marlen KyzyandGitHub aec249e46b Merge pull request #200042 from microsoft/aiday/keepHoverOpenWhenAltKeyPressed
Keep the hover open when the alt key is pressed
2023-12-06 10:33:51 +01:00
Tyler James LeonhardtandGitHub 5196dddde0 Low hanging fruit of onboarding to ensureNoDisposablesAreLeakedInTestSuite (#200100)
ref https://github.com/microsoft/vscode/issues/200091
2023-12-05 21:53:40 -08:00
Chapman Pendery dc097a8354 refactor: xterm suggestion addon into terminalContrib
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
2023-12-05 20:06:52 -08:00
Chapman PenderyandGitHub f6994ee8d9 Merge branch 'main' into fix/terminal-suggestion-positioning__accept-completions 2023-12-05 19:40:02 -08:00
Chapman Pendery ff08ba7712 fix: unused import
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
2023-12-05 19:26:58 -08:00
Flanker-MSFT 37b7701535 Simplify the list of libraries for java workspace tagging 2023-12-06 10:15:29 +08:00
Tyler James LeonhardtandGitHub 42b9e86467 Add quick-chat to grooming notebook (#200094) 2023-12-06 00:34:58 +01:00
Connor PeetandGitHub 2ee5518dec debug: fix incomplete range in disassembly goToInstructionAndOffset (#200093)
Fixes #197770
2023-12-05 15:21:08 -08:00
Connor PeetandGitHub 6605df0f11 debug: fix toolbar min y position (#200090)
This was inverted a couple iterations ago during a refactor it looks like.

Fixes #200005
2023-12-05 23:54:52 +01:00
Chapman PenderyandGitHub c9079bf7b6 Merge branch 'main' into fix/terminal-suggestion-positioning__accept-completions 2023-12-05 14:49:31 -08:00
Chapman Pendery 69f334db0f fix: feedback by disabling suggestions during accepted completion
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
2023-12-05 14:48:48 -08:00
4da18252cd fix: feedback
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
2023-12-05 14:45:19 -08:00
Connor PeetandGitHub 16c469a671 eng: add a lint rule for ensureNoDisposablesAreLeakedInTestSuite (#200089)
Adds a lint rule that ensures ensureNoDisposablesAreLeakedInTestSuite
is called in suites. It grandfathers in existing files that were lacking
the call entirely.

This PR also includes manual fixes to files that used the function
already but were missing it in one or more suites, which the lint rule
detects.
2023-12-05 14:35:27 -08:00
Henning DieterichsandHenning Dieterichs 4728954baa Fixes #178245 2023-12-05 23:14:19 +01:00
Benjamin PaseroandGitHub 56fda3234c Windows: "Reopen" after crash does not work with 1 window opened (fix #199960) (#200075) 2023-12-05 14:13:44 -08:00
Connor PeetandGitHub 0d42a76e2f debug: fix call resolveDebugConfigurationWithSubstitutedVariables with redirected type (#200080)
* cli: allow reading exec server token from env variable

* debug: fix call resolveDebugConfigurationWithSubstitutedVariables with redirected type

Fixes #188979
2023-12-05 14:05:26 -08:00
Megan RoggeandGitHub 0ca618d59d Merge pull request #200086 from microsoft/merogge/activity-bar-left
update focus on left/right arrow
2023-12-05 15:25:25 -06:00
netconandGitHub 703e21214e fix: workbench.editorAssociations not work in workbench configurationDefaults (#194087) 2023-12-05 22:21:18 +01:00
meganrogge 4a7480c147 update focus on left/right arrow 2023-12-05 15:10:00 -06:00
Connor PeetandGitHub cc62bd1ddd cli: allow reading exec server token from env variable (#200079) 2023-12-05 21:38:10 +01:00
Daniel ImmsandGitHub 88defdf993 Merge pull request #200076 from microsoft/tyriar/179483
Respect early returns from pre-existing bash debug traps
2023-12-05 12:08:09 -08:00