It seems like this event fires in Codespaces... my _guess_ is that Codespaces basically overwrites all the settings from settings sync which causes this event to fire.
It's surprising to me that this event fires even though the value hasn't changed.
I can't repro this with the test resolver, and I also cant have Codespaces use Code - OSS, so we'll just have to see how this goes.
This _should_ do the trick though.
Fixes https://github.com/microsoft/vscode/issues/223508
Fixes#213209
I believe that chat editors are potentially being leaked when progressive rendering ends due to `contentParts` being set without also being disposed of
Also fixes the wrong selection potentially being used
Fixes#217835
#171066 introduced a fix for applying PATH prefix on macOS login shells that resolved#99878. However it had little issues for each shell implementation.
This PR contains the following fixes:
`bash` fix:
- Add missing `:` separator in the path setter to avoid path corruption
- Add missing quotes to avoid path interpretation
`zsh` fix:
- Add missing `:` separator in the path setter to avoid path corruption
- Add missing quotes to avoid path interpretation
- Move patching outside of `.zprofile` check as clean macOS install doesn't include this file, nevertheless PATH patching should still happen
`fish` fix:
- use `set -gx PATH` instead of `fish_add_path` as the latter has no effect on updating the path if entries already exist in it. Which is the case for some extensions, like [`vscode-micromamba`](https://github.com/mamba-org/vscode-micromamba) which modify process environment and after login shell rc processing path entries end up in the end.
* Make space for tree sitter
* Add the tree sitter wasm file
* Very naive tree-sitter syntax highlighting for html, with a layer breaker
* Update tree when content changes
* WIP for making abstract tokens class
* Handle theme changes
* Replace entire text model value with parse callback
* Perf improvements
* Add tree-sitter-typescript
* Add typescript + better initial parsing
* Refactor into tree parsing service and fix flaw in parse callback
* Remove things that aren't the parser service
* Add yielding
* Remove changes that aren't required for PR
* Remove more file changes
* Reduce yield to 50 ms
* Fix incremental parsing
* Try update node-abi
* Revert "Try update node-abi"
This reverts commit df28801e31.
* Update text buffer chunk api
* fix build
* Remove tree-sitter dependency
* Adopt new, as yet unpublished, `@vscode/tree-sitter-wasm` package
* Use published `@vscode/tree-sitter-wasm` package
* Break `TreeSitterTree` and `TreeSitterParserService` into better pieces
and:
- document the order of editor changes
- use service injection where `TextModel` is constructed
* Fix tests
* Remove unneeded import
* Fix missing tree-sitter-wasm in web and remote
* Make package.jsons match
* Add @vscode/tree-sitter-wasm to web loader config
* Try using importAMDNodeModule
* PR feedback
* Add race condition test for changing language while loading language
* Use same timeout
* Queue content changes
* Remove override dispose
* Move queue into TreeSitterTree
---------
Co-authored-by: Peng Lyu <penn.lv@gmail.com>
dependabot[bot]
Josh Spicer
Connor Peet
Tyler James Leonhardt
Megan Rogge
Daniel Imms
Alex Ross
Henning Dieterichs
Ladislau Szomoru
Robo
Sandeep Somavarapu
Matt Bierner
Rob Lourens
Raymond Zhao
Anton Matosov
Joyce Er
Caleb Brose
Andrea Mah