Commit Graph
124157 Commits
Author SHA1 Message Date
RoboandGitHub a556eb6abb chore: bump electron@25.8.2 (#193798)
* chore: bump electron@25.8.2

* chore: bump distro
2023-09-22 15:51:59 +01:00
John MurrayandGitHub 4b015f4f73 Merge branch 'main' into pink-bedbug 2023-09-22 15:20:07 +01:00
Ladislau SzomoruandGitHub ea742d0a3c SCM - keep file selection when switching between view modes (#193808) 2023-09-22 15:09:39 +01:00
Sandeep SomavarapuandGitHub 20212f2b7b overlay gear on profile icon (#193806) 2023-09-22 15:08:24 +01:00
João MorenoandGitHub 537c380c16 fixes #193088 (#193807) 2023-09-22 15:08:02 +01:00
Alex RossandGitHub 4f06571588 Extension development:Frequent calls to _onDidChangeTreeData.fire(), resulting in memory leakage (#193799)
Fixes #193421
2023-09-22 15:06:57 +01:00
Ladislau SzomoruandGitHub 96e7244093 SCM - fix file decoration for Tree mode (#193779) 2023-09-22 15:06:28 +01:00
gjsjohnmurray 1fe24f62a1 Hide launcher on Run and Debug title bar when debugging 2023-09-22 15:05:23 +01:00
Johannes RiekenandGitHub b7fad0df6d Revert "Copilot-based TS refactors" 2023-09-22 16:05:04 +02:00
Johannes RiekenandGitHub 0aecb586f4 Merge pull request #192602 from sandersn/ai-codefixes
Copilot-based TS refactors
2023-09-22 15:44:53 +02:00
Ladislau SzomoruandGitHub f6ad9f7685 SCM - refactor getChildren(), add Refresh action (#193805) 2023-09-22 14:35:48 +01:00
Sandeep SomavarapuandGitHub e88e309ab5 adopt ensureNoDisposablesAreLeakedInTestSuite (#193803)
#190503 adopt ensureNoDisposablesAreLeakedInTestSuite
2023-09-22 14:35:41 +01:00
Ulugbek Abdullaev 6702a6627e refactor(mapped edits): clean up selection context creation 2023-09-22 14:57:04 +02:00
Ulugbek Abdullaev 39dc875c4e Merge branch 'main' into ulugbekna/implement-code-mappers-context 2023-09-22 14:43:25 +02:00
João MorenoandGitHub 2a691f77e4 screencast mode: look for commands in command registry (#193797)
fixes #188938
2023-09-22 13:42:16 +01:00
Sandeep SomavarapuandGitHub d488158485 pass store to disposableTimeout (#193796)
#193613 pass store to disposableTimeout
2023-09-22 13:34:25 +01:00
Johannes RiekenandGitHub 0d82bc6da0 Merge pull request #193787 from microsoft/joh/legal-snake
keep inlineChat.contribution purely registrations of stuff
2023-09-22 14:17:49 +02:00
RoboandGitHub 9a1c96245e fix: respect values from --disable-features flag (#193795) 2023-09-22 13:01:59 +01:00
47003fa3ee editors - exempt for navigation commands from being hidden (#193778)
* editors - exempt for navigation commands from being hidden

* add and use collections.ts#intersection

---------

Co-authored-by: Johannes <johannes.rieken@gmail.com>
2023-09-22 13:17:30 +02:00
Alex RossandGitHub 0e7747550f active editor has commenting range is true even when it should not be (#193788)
Fixes #193716
2023-09-22 12:55:31 +02:00
39b74422de editor tab accessibility across tab bars (#193776)
* wip

* tab focus across tab bars supported

* 💄

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-09-22 12:17:21 +02:00
Johannes 3b28b7303d keep inlineChat.contribution purely registrations of stuff 2023-09-22 11:57:46 +02:00
Ulugbek Abdullaev 5547de51db mapped edits: update code around the command _executeMappedEditsProvider 2023-09-22 11:54:58 +02:00
Johannes 98f0259912 chore - move isInteractiveEditorOptions into its type 2023-09-22 11:51:11 +02:00
Alex RossandGitHub f4761fe652 Show next/previous commenting range in command palette (#193782) 2023-09-22 10:45:16 +01:00
Sandeep SomavarapuandGitHub 685987d23a fix #192266 (#193781) 2023-09-22 10:45:02 +01:00
Sandeep SomavarapuandGitHub feed93f995 fix width (#193777) 2023-09-22 10:30:55 +01:00
Rebecca DoddandGitHub b8e8db96fa Update info-needed label name in contributing doc (#182528) 2023-09-22 10:23:57 +01:00
Benjamin PaseroandGitHub c72447e8d8 Cannot read properties of null (reading 'b') (fix #193773) (#193774) 2023-09-22 09:48:12 +01:00
Benjamin SimmondsandGitHub aa88e1829d Don't show TAB_LAST_PINNED_BORDER color when all tabs are pinned (#193762)
* #193687

* dont show tab border when all sticky
2023-09-22 10:41:20 +02:00
Johannes RiekenandGitHub ffc6fdea8f Merge pull request #193767 from microsoft/joh/disgusted-dolphin
WorkbenchToolBar allows to configure exemption from overflow logic
2023-09-22 10:12:03 +02:00
Johannes b7ab7290d9 WorkbenchToolBar allows to configure exemption from overflow logic
fixes https://github.com/microsoft/vscode/issues/193723
2023-09-22 09:51:51 +02:00
gjsjohnmurray f8c1fcaa30 Correct the CLI helptext for --profile 2023-09-22 08:46:17 +01:00
Benjamin PaseroandGitHub e7b10fc717 editors - further improve isFirst and isLast and add test for sticky: true with index (#193760) 2023-09-22 09:34:28 +02:00
Benjamin PaseroandGitHub f92ee6faeb debt - move away from generic groups accessor name (#193707)
debt - move away from generic `accessor` name
2023-09-22 09:19:10 +02:00
Benjamin PaseroandGitHub 2cd6bbdb73 [Accessibility] ctrl+k, ctrl+shift+n does not open actionable notification items (fix #193715) (#193758) 2023-09-22 07:37:57 +01:00
Ladislau SzomoruandGitHub 54fc6334f5 Git - fix file decoration for history item changes (#193755) 2023-09-22 07:27:26 +01:00
Rob LourensandGitHub b1ecf6f7bc Add decorations for variables in rendered chat requests (#193745)
* Use parsed chat request in model and renderer

* Fix using variables with the chat parser

* Test snapshot

* Add test

* Update test snapshots
2023-09-22 08:19:41 +02:00
Justin ChenandGitHub 444399e23b Lets issues of the "don't know" variety be filed from the issue reporter. (#193733)
makes string value not null
2023-09-21 22:31:10 -04:00
Connor PeetandGitHub 280c840f87 cli: support setting the --parent-process-id in command shell (#193735) 2023-09-21 15:12:02 -07:00
Matt BiernerandGitHub e2bd761d52 Adopt ensureNoDisposablesAreLeakedInTestSuite (#193736)
For #190503
2023-09-21 15:09:19 -07:00
Connor PeetandGitHub 31067371f2 eng: fix snapshot tests in macos webkit for real? (#193734)
Second attempt at this, which should work. Stop trying to use
exposeFunction, which seems to work poorly on macOS webkit in CI, and
just run a server with HTTP endpoints to do the "RPC."

Reuses Alex's "yaserver" module that we were already using for other
tests. Uses a secure random prefix for security in each run.
2023-09-21 22:48:21 +01:00
Connor Peet f92db2f96e cli: fix renamed self-update name, cleanup old binaries
Fixes #192948
2023-09-21 14:37:33 -07:00
Connor Peet 4fa7137b05 cli: add more details if untar fails
For #192647
2023-09-21 14:37:33 -07:00
Tyler James LeonhardtandGitHub d5c2817e69 Use email for label & use label to group results in Account menu (#193727)
So, when you make a new session in the Microsoft Identity stack, depending on the scopes you pass in you might get:
* A token with a name & email
* A token with just a name
Additionally, Microsoft has like 3-4 concepts of essentially an "id" but depending on what you're trying to access, you might get a different value.

This historical behavior leads to 2 awkward things:
1. The account menu shows two accounts, one with name & email, one with just email.
2. The account menu shows two of the same accounts, but their underlying id is different

So, to fix this, we're just gonna lean on the labels. In other words, if there are two accounts that share the same label, then they will be grouped together.

The previous behavior was hurting the Azure Account folks and the Q# folks and with this change, I believe they both should be happy.

Interestingly enough, when I inherited this code, it use to do this, but I changed it to use the id as that seemed "more correct"... so it a way, this is reverting a change I did a while back.

Fixes https://github.com/microsoft/vscode/issues/184218
2023-09-21 14:09:25 -07:00
Aaron MungerandGitHub f5e97242d0 Merge pull request #193729 from microsoft/aamunger/flakyTest
skip flaky test
2023-09-21 13:41:21 -07:00
Megan RoggeandGitHub 384201f38a Merge pull request #193706 from microsoft/merogge/task-status-test
task terminal status test take 2 adoption of ensure no disposables are leaked
2023-09-21 13:23:27 -07:00
meganrogge 5064b1153c gramatically correct 2023-09-21 12:59:55 -07:00
Aaron Munger 150d09b37b skip flaky test 2023-09-21 12:57:28 -07:00
meganrogge 95675fae4f use mutable disposable, rm dispose func 2023-09-21 12:16:18 -07:00