Commit Graph
124157 Commits
Author SHA1 Message Date
Johannes 2361631753 some ensureNoDisposablesAreLeakedInTestSuite work 2023-09-05 21:33:52 +02:00
meganrogge a18893966c use shift for linux 2023-09-05 15:26:18 -04:00
Tyler James LeonhardtandGitHub 2ab25fade7 Match on description as well (#192227)
Fixes https://github.com/microsoft/vscode/issues/192077
2023-09-05 21:00:53 +02:00
Johannes 690b7acc1f make shouldInlineSubmenu more important 2023-09-05 20:44:44 +02:00
Hamir MahalandGitHub d069adfb6d Merge branch 'main' into feat/copy-command-and-output-in-integrated-terminal 2023-09-05 11:37:14 -07:00
Matt BiernerandGitHub 37c4f18caf Pick up latest TS to build VS Code (#192219) 2023-09-05 20:34:58 +02:00
Matt BiernerandGitHub 9d0779ad5b Restore default paste fallback (#192218)
Fixes #192196
2023-09-05 20:22:22 +02:00
Johannes 2a85f13d74 undo removeSession part 2023-09-05 20:08:43 +02:00
Johannes 69056ae87d Merge branch 'main' into joh/normal-hummingbird 2023-09-05 20:02:56 +02:00
Johannes c20fd46cfa WIP - CC debug 2023-09-05 20:01:26 +02:00
Daniel ImmsandGitHub fb2928d970 Merge pull request #192215 from microsoft/tyriar/xerothermic-gibbon
Add separator to test output
2023-09-05 10:54:23 -07:00
b29799c8cb List widget onInput cleanup (#191882)
* code cleanup

* cleanup part 2

* Apply suggestions from code review

---------

Co-authored-by: João Moreno <mail@joaomoreno.com>
2023-09-05 19:51:14 +02:00
Daniel ImmsandGitHub 7ef481c93f Merge pull request #192214 from microsoft/tyriar/disposable_leaks
Return an optional DisposableStore from leak fn
2023-09-05 10:45:45 -07:00
Daniel ImmsandGitHub bf605359b0 Add separator to test output
This fixes terminal link detection
2023-09-05 10:40:00 -07:00
Daniel Imms 03a98986ec Return an optional DisposableStore from leak fn
Part of #190503
2023-09-05 10:35:34 -07:00
Daniel Imms 3f791694da Return an optional DisposableStore from leak fn
Part of #190503
2023-09-05 10:28:45 -07:00
Hamir Mahal 33d24efb39 feat: copy command and output in integrated term 2023-09-05 10:26:49 -07:00
Hamir Mahal 36960dc437 chore: changes from formatting on save 2023-09-05 10:22:53 -07:00
Rob LourensandGitHub 7ead2078eb Merge pull request #192117 from lukaszsamson/fix-event-name
Fix invalid match on `exited` DAP event
2023-09-05 10:20:57 -07:00
Daniel Imms 368f5d88c6 XtermTerminal leaks 2023-09-05 10:14:42 -07:00
Matt BiernerandGitHub 43495ec026 Add unbalancedBracketScopes for markdown (#191844)
Fixes #191843
2023-09-05 10:08:30 -07:00
Daniel Imms 4f8773173b Xterm addon leaks 2023-09-05 09:31:16 -07:00
Daniel Imms 2e4a770fd5 Leak terminalStatusList.test.ts 2023-09-05 09:24:24 -07:00
Daniel Imms 201ef05304 Leak protection in terminal service test 2023-09-05 09:19:40 -07:00
Daniel Imms 6f033d17ee Leak in terminal instance/proc manager 2023-09-05 08:49:18 -07:00
Connor PeetandGitHub 37aed2e103 eng: replace Event.chain with Event.chain2 (#192202)
Followup from #192026

Removes the original leak-prone implementation of Event.chain and
replaces it with `chain2` which only requires disposable of the
resulting listener.
2023-09-05 17:19:22 +02:00
Johannes RiekenandGitHub 28b5195242 Merge pull request #192007 from microsoft/joh/wandering-jay
fix https://github.com/microsoft/vscode/issues/187779
2023-09-05 17:05:09 +02:00
Johannes RiekenandGitHub d697093f82 Merge pull request #192200 from microsoft/joh/wilful-cougar
chore - avoid duplicate imports
2023-09-05 17:04:48 +02:00
Daniel Imms 67b8cf6e1e Leak coverage in more terminal unit tests 2023-09-05 08:01:34 -07:00
Daniel Imms e501709a2f Fix leaks in command detection capability test 2023-09-05 07:48:10 -07:00
Johannes d52c8b0f33 chore - avoid duplicate imports 2023-09-05 16:46:40 +02:00
Daniel Imms b960702d03 Some easy leak files 2023-09-05 07:43:43 -07:00
Daniel Imms cc7c052e7c RequestStore test leaks
Part of #190503
2023-09-05 07:38:31 -07:00
Connor PeetandGitHub a3d328a65c testing: fix most disposable leaks in testing, tree (#192026)
This fixes disposable leaks in the testing tests. These tests also
encompass tree views. One big source of leaks I found was `Event.chain`:
technically, every step in the chain is an IDisposable and needs to be
disposed. However, this is very noisy and unergonomic.

As an alternative, I introduce a very small `chain2` implementation
which only requires disposing the resulting event listener, like an
ordinary emitter. It doesn't support debouncing, though it could we if
want it to; there was only a single usable of the chained `debounce`
method in our codebase.

For #190503
2023-09-05 07:19:43 -07:00
meganrogge 2312fcc442 tweak comment 2023-09-05 10:15:28 -04:00
meganrogge c8123491a9 clean up, make sure all cases work 2023-09-05 10:11:22 -04:00
Johannes RiekenandGitHub d187d50a48 Merge pull request #192155 from microsoft/joh/corporate-canid
Update playwright
2023-09-05 15:50:32 +02:00
Megan RoggeandGitHub 54475f4ff7 Merge branch 'main' into merogge/rm-tab-focus-mode 2023-09-05 09:10:24 -04:00
Aiday Marlen Kyzy 278fd2b2a1 removing redundant function 2023-09-05 14:20:47 +02:00
Aiday Marlen Kyzy 7efab94202 cleaning the code 2023-09-05 14:11:05 +02:00
Alexandru DimaandGitHub 01d832c077 Merge pull request #192187 from microsoft/alexd/innovative-unicorn
Only recreate decorations for changed markers
2023-09-05 13:58:29 +02:00
Aiday Marlen Kyzy 79773c8b1f using instead two attributes per dom node 2023-09-05 13:55:47 +02:00
Johannes RiekenandGitHub 137b724984 Merge branch 'main' into joh/corporate-canid 2023-09-05 13:50:57 +02:00
Aiday Marlen Kyzy 4409d5b2da fixing bugs 2023-09-05 12:42:57 +02:00
Aiday Marlen Kyzy a42bf3ad42 writing some generic methods in order to extract the relevant information 2023-09-05 12:13:53 +02:00
Alex Dima 9c04ba42a8 Fixes #159555: Only recreate decorations for changed markers 2023-09-05 11:58:10 +02:00
Johannes ba3bc87570 unskip test 2023-09-05 11:53:37 +02:00
Aiday Marlen Kyzy ea267b48b0 using different methods for the line and the line number. We do not want to jump on clicking on the line number in the sticky gutter. 2023-09-05 11:52:01 +02:00
Johannes 8f4d4d4bad workaround browser bug, fix browser test debugging 2023-09-05 11:47:13 +02:00
Alex Dima 5463b416d2 Move marker creation to MarkerDecorations 2023-09-05 11:13:44 +02:00