* Don't use `remoteCredentialsService` when client specified a `secretStorageProvider`
This is a temporary fix for https://github.com/microsoft/vscode/issues/190537
until we clean up the last of the CredentialsService (which should be in debt week in Sept).
If the client embedder declared a secretStorageProvider, they likely don't want the old credentialsProvider to go over the remote connection... so we use an in-memory provider instead.
Fixed https://github.com/microsoft/vscode/issues/190537
* remove stale comment
This adds buttons to the right of the chat box. These buttons were previously on the quick pick's titlebar, but in order to have a smooth transition between Command Palette and Quick Chat we wanted to move away from the title bar.
Initially the direction was to make `TerminalLinkManager` more general
and use it explicitly in detached terminals.
But I ended up getting nudged in the direction of making terminalContribs
work with detached terminals instead. All the link detection logic is
in terminalContrib which is a layer that can't be imported from the main
terminal code. And it also depends on the raw xterm instance, which we
don't want to expose to callers, so I wouldn't want to have the caller
manually do something like new `TerminalLinkManager(deatchedXterm.raw, ...)`
So that made me think I should either make a new contrib system for
detached terminals, or allow existing contribs to signal that they
could run for detached terminals too. In the PR, I did the latter.
* inline chat: fix leaks found in testing
Fixes some leaks I found while looking at https://github.com/microsoft/vscode/pull/190444, by adding ensureNoDisposablesAreLeakedInTestSuite to the suite.
I don't have a dev setup for inline chat, so I have not tested this beyond running tests and verifying the fix
* eng: cleanup some leaks around around editors and workbenchInstantiationService
I added a disposable leak tracker to a test that used `workbenchInstantiationService`.
This fixes the baseline leaks and some extra leaks with that function.
* fix build
* rm too-eager leak checker
* remove forgotten busy loop
Benjamin Pasero
Daniel Imms
Tyler James LeonhardtandGitHub
Raymond ZhaoandGitHub
Megan RoggeandGitHub
meganrogge
Joyce ErandGitHub
Joyce ErandGitHub
Aaron MungerandGitHub
Connor PeetandGitHub
hsfzxjyandGitHub
lucasMariozaandGitHub
Aiday Marlen Kyzy
