Commit Graph
124157 Commits
Author SHA1 Message Date
Daniel Imms 1391e9a686 Add workspace id to terminal logs
Fixes #187080
2023-07-06 12:41:03 -07:00
Daniel Imms d630142d45 Add AcceptDetachInstanceReply impl and add ts assert for future 2023-07-06 12:24:18 -07:00
Daniel Imms ab08a18321 Use const enum for all remote terminal requests
Part of #187176
2023-07-06 12:12:56 -07:00
Daniel ImmsandGitHub 57ae321b9d Merge pull request #187177 from microsoft/tyriar/186935
Add IPtyHostService
2023-07-06 12:02:20 -07:00
Daniel Imms 0d1bc0818c Clean up pty services 2023-07-06 11:45:42 -07:00
Daniel Imms 074121ee30 Remove now unneeded optional checks 2023-07-06 11:42:22 -07:00
Daniel Imms ed59e75f3d Add IPtyHostService
This is a new service which extends IPtyService and provides additional methods
on the process that manages the connection to the pty host:

- IPtyService: Talk to the pty host, this may be direct via a message port of via
  the main/server procs.
- IPtyHostService: Talk to the pty host management interfaces on the main/server
  procs. These are no longer available as optional methods on IPtyService to be
  clear about where they happen (eg. getProfiles).

Fixes #186935
2023-07-06 11:35:45 -07:00
Megan RoggeandGitHub 440bade772 Merge pull request #187159 from microsoft/merogge/build-task99
clear workspace tasks promise when supported executions change
2023-07-06 11:20:36 -07:00
Raymond ZhaoandGitHub c067a3bf81 chore: bump semver 7 dependencies (#187171) 2023-07-06 20:18:02 +02:00
Connor PeetandGitHub ccbcba53e6 debug: shut down debug sessions if an extension host goes away (#187169)
Fixes #184552
2023-07-06 20:04:59 +02:00
Joyce ErandGitHub 078d0fd6e3 Fix capitalization in survey notification (#187168) 2023-07-06 20:00:48 +02:00
rebornix 001615e0b6 No need for additional readonly and missing file check. 2023-07-06 10:29:50 -07:00
Aaron MungerandGitHub 0daeaf508c Merge pull request #187070 from microsoft/aamunger/notebookInfoRegistration2
just use the extension property to know if an editor needs to be registered
2023-07-06 09:59:22 -07:00
meganrogge 4f1df73b95 when supported executions change, make sure to unset the promise so they get re-evaluated 2023-07-06 09:23:11 -07:00
Aaron MungerandGitHub f5f7127f8f Merge branch 'main' into aamunger/notebookInfoRegistration2 2023-07-06 08:03:10 -07:00
Alex RossandGitHub 56f97a454f Merge pull request #187096 from microsoft/tyriar/187076
Fix several pty host lifecycle issues on remotes
2023-07-06 16:36:06 +02:00
Daniel ImmsandGitHub 535da9308b Merge pull request #187144 from microsoft/Tyriar-patch-1
Create commands/codespaces_issue.yml
2023-07-06 07:29:36 -07:00
Daniel ImmsandGitHub e1021bf70d Create codespaces_issue.yml 2023-07-06 07:14:31 -07:00
meganrogge 42e9acc5a8 no need to explicitly get workspace tasks as they're always refreshed now 2023-07-06 07:11:18 -07:00
Daniel ImmsandGitHub 94cfd18b28 Merge pull request #187083 from SvanT/main
Dispose `TerminalWordLinkDetector` listeners
2023-07-06 06:59:59 -07:00
Svante BobergandGitHub 663539163b Merge branch 'main' into main 2023-07-06 08:26:22 +02:00
Marshall Roch 4223cc994e fix [object Object] in invalid decorator warning
when there's an invalid decorator, you get a warning like this:

```
[warning] INVALID decoration from extension '[object Object]': Error: The decoration is empty
```

as is done elsewhere in this file, should use `extensionId.identifier.value` to get a string
2023-07-05 21:52:27 -04:00
Bhavya UandGitHub 6c8cdf325e Remove galleryExtension check when initializing remote menu (#187109)
Remove galleryExtension check
2023-07-06 02:35:13 +02:00
Tyler James LeonhardtandGitHub 609e636933 Also check for secret storage provider before using old API (#187105)
This allows a nice migration path for web environments:
1. Embedder implements a secret storage provider in addition to the credentials provider they already have
2. Wait a release or 2
3. Remove the credentials provider from the embedder

Once all known embedders do number 1, we can delete the `_oldMainThreadSecretState` entirely.
2023-07-06 10:19:33 +10:00
dependabot[bot]GitHubdependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
c9073ad0c8 Bump semver from 7.3.7 to 7.5.3 in /extensions/css-language-features (#187107)
Bumps [semver](https://github.com/npm/node-semver) from 7.3.7 to 7.5.3.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-semver/compare/v7.3.7...v7.5.3)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-06 01:54:58 +02:00
dependabot[bot]GitHubdependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
9618e4fa2a Bump semver from 7.3.8 to 7.5.3 in /build/npm/gyp (#186809)
Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.3.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-semver/compare/v7.3.8...v7.5.3)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-05 16:29:55 -07:00
dependabot[bot]GitHubdependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
6fa852f87a Bump semver from 7.3.5 to 7.5.3 in /remote (#185981)
Bumps [semver](https://github.com/npm/node-semver) from 7.3.5 to 7.5.3.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-semver/compare/v7.3.5...v7.5.3)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-05 16:29:29 -07:00
Bhavya UandGitHub 99494a7a29 Show busy indicator in remote menu when initializing. (#187018)
* Show progress bar in remote indicator when initializing

* Remove placeholder change
2023-07-05 16:14:40 -07:00
Tyler James LeonhardtandGitHub 322bc2d7d8 Have getCurrentAuthenticationSessionInfo take in a secretStorageService (#187092)
To start the migration process, we have `getCurrentAuthenticationSessionInfo` take in a `secretStorageService` and also replaces the `LocalStorageCredentialProvider` with a `LocalStorageSecretStorageProvider`.

After this goes in we can then update all embedders (vscode.dev, github.dev, Codespaces, vscode-web-test?) and replace ICredentialProvider usages with ISecretStorageProviders and then once we do that, we can get rid of a bunch of code!
2023-07-06 00:09:01 +02:00
Connor PeetandGitHub c7d219b53f testing: make running tests open the results view instead of explorer (#187100)
Closes #153068
2023-07-05 23:55:10 +02:00
Connor PeetandGitHub 856bc1e28d testing: property make double click go to test (#187099)
Fixes #183835
2023-07-05 23:38:29 +02:00
Connor PeetandGitHub 753fdf8420 testing: fix inconsistent action name (#187098)
Fixes #186370
2023-07-05 23:34:38 +02:00
Raymond ZhaoandGitHub 26a45ba4d3 fix: adjust widget overflow styling (#186951)
Fixes microsoft/vscode-pull-request-github#4973
2023-07-05 14:31:37 -07:00
Daniel Imms 3d6d83950e Don't spawn pty host on getDefaultSystemShell or refreshIgnoreProcessNames 2023-07-05 14:15:59 -07:00
Daniel Imms f409c06e47 Clean up trace logs 2023-07-05 14:13:15 -07:00
Andrea MahandGitHub b540ba7b27 Unexpected link highlighting in search editor (#187091)
Fixes #180813
2023-07-05 23:11:27 +02:00
Daniel Imms 72fb36496c Fix pty host lazy spawning
Fixes #187076
2023-07-05 14:10:18 -07:00
Michael LivelyandGitHub 406d3d5cf5 fix #186651 -- notebook action tab border only on icon, not label (#187085)
fix #186651
2023-07-05 14:08:37 -07:00
Connor PeetandGitHub 55d8d97b45 testing: fix default size of inline peek diff (#187072)
* testing: fix default size of inline peek diff

Fixes #185331

* rm unused import
2023-07-05 14:06:38 -07:00
Daniel Imms 0c3fb42a1e Disable seamless relaunch on Windows/remote/ConPTY
The fast process spawn, kill, spawn was causing problems on remotes

Fixes #187084
2023-07-05 13:46:59 -07:00
meganrogge 075cf4ac2b getWorkspaceTasks 2023-07-05 13:38:53 -07:00
Sandeep SomavarapuandGitHub 1157e96e24 adopt atomic write for userdata (#187038)
* #180695 - adopt atomic write for userdata

* check if fsp has atomic write

* fix tests
2023-07-05 13:29:34 -07:00
Connor PeetandGitHub d58f304c06 fix: gutter testing spinner icon broken due to line height (#187081)
Getting the "wobble" entirely out was annoying. I initially assumed the countainer had to be either an odd or dimension for flexbox to center the icon, but this seemed to not be sufficient. For example, a line height of 36 and 40 were wobble-free, but 38 was not.

So instead take a sledgehammer at spinning icons and center them with a transform position.

Fixes #183269
2023-07-05 13:25:29 -07:00
Megan RoggeandGitHub bbed10d8ba Merge pull request #187069 from microsoft/merogge/task-build
wait for task system info before running any task
2023-07-05 12:49:31 -07:00
Daniel Imms 2210138059 . 2023-07-05 12:45:57 -07:00
Daniel Imms 86a4dad4a6 Improve name of pty host connection request 2023-07-05 12:26:00 -07:00
Daniel Imms 592302766f Don't automatically start up pty host in remote 2023-07-05 12:25:05 -07:00
Daniel Imms 9922b1cb8a Improve logging of pty host startup/reconnection 2023-07-05 12:23:57 -07:00
Daniel Imms ce3f06b9db Bring local terminal reconnect changes to remote
Part of #187076
2023-07-05 12:23:30 -07:00
Svante Boberg bd915931bd Dispose TerminalWordLinkDetector listeners 2023-07-05 21:08:19 +02:00