Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-01 21:54:52 +01:00
Code Issues Packages Projects Releases Wiki Activity
124,157 Commits 4,958 Branches 386 Tags
e81aceaa07bab1ccdc94deae04168c8bd062f0de
Commit Graph
124157 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Aiday Marlen Kyzy e05a47d001 taking into account the last rendering position of the active session 2023-06-09 10:08:56 +02:00
Tomer Chachamu 9639108f77 Fix review comments 2023-06-09 09:00:18 +01:00
Aiday Marlen Kyzy aa4daa451c Change to the code after review 2023-06-09 09:58:39 +02:00
Tyler James Leonhardt 8833810738 Improve QuickPickList perf by having a single emitter (#184678) 
ListElements get created every time a quickpick is shown and then they're each disposed because they have a checked event emitter...

This change instead uses a single emitter that gets passed in to each ListElement... making ListElement not need to be a disposable.

Follow up from https://github.com/microsoft/vscode/pull/184661#issuecomment-1583657200
ref https://github.com/microsoft/vscode/issues/184615
 2023-06-09 08:43:26 +02:00
aamunger 3767249655 select previous output to be replaced correctly 2023-06-08 21:51:18 -07:00
Tyler James Leonhardt db6bcdf309 Improve performance of QuickPickList (#184661) 
Highlights:

* remove Object.assign [usage](https://github.com/microsoft/vscode/blob/76ec379410c009cdfdde52fc00e89c97bf745e3c/src/vs/platform/quickinput/browser/quickInputList.ts#L92)
* remove [extra reduce
](https://github.com/microsoft/vscode/blob/76ec379410c009cdfdde52fc00e89c97bf745e3c/src/vs/platform/quickinput/browser/quickInputList.ts#L593)
* `show-checkboxes` that can be [moved out of reduce](https://github.com/microsoft/vscode/blob/76ec379410c009cdfdde52fc00e89c97bf745e3c/src/vs/platform/quickinput/browser/quickInputList.ts#L553) and computed once
* move [saneLabel & other sane things](https://github.com/microsoft/vscode/blob/76ec379410c009cdfdde52fc00e89c97bf745e3c/src/vs/platform/quickinput/browser/quickInputList.ts#L535) into ListElement to compute there using Lazy
* remove regex newline replacement with `labelEscapeNewLines`

NOTE: that last bullet means new lines will now be rendered as `⏎` instead of just a space. I see this as an improvement but we'll see if anyone complains. If they, do it's easy to bring back the old behavior while keeping the perf gains in this PR (they'd be computed lazily)

Lowlights:

I attempted to remove [onChecked in ListElement](https://github.com/microsoft/vscode/blob/76ec379410c009cdfdde52fc00e89c97bf745e3c/src/vs/platform/quickinput/browser/quickInputList.ts#L587) for one big emitter... but I don't think this is possible given these other usages:
* [In the QuickInputAccessibilityProvider](https://github.com/microsoft/vscode/blob/dd2441f7ba44e0aa46bd52005e4f8066d72fc3d7/src/vs/platform/quickinput/browser/quickInputList.ts#L1012) to inform if the element is checked
* [In the renderElement](https://github.com/microsoft/vscode/blob/dd2441f7ba44e0aa46bd52005e4f8066d72fc3d7/src/vs/platform/quickinput/browser/quickInputList.ts#L174) that updates the actual checkbox item

Fixes #184615
 2023-06-08 17:10:43 -07:00
Aaron Munger addb0791ac Use the output limit for the warmup calls (#184624) 
* re-use the output limit where applicable

* put limit in the viewmodel
 2023-06-08 16:41:41 -07:00
Megan Rogge 0e06e43656 Merge pull request #184641 from microsoft/merogge/editor-h 
use `AccessibleView` for editor accessibility help menu
 2023-06-08 18:15:32 -05:00
Connor Peet 49535d6a04 build: fix missing param for build (#184660) 2023-06-09 01:10:08 +02:00
Daniel Imms 43f343069b Merge pull request #184656 from microsoft/tyriar/xterm_5_2 
xterm@5.2
 2023-06-08 15:27:56 -07:00
Ladislau Szomoru 2cccaaee8a Git - Close Repository command should be disabled when there is only one repository opened (#184637) 2023-06-08 15:19:10 -07:00
Michael Lively 34bde274c1 debt - remove field when no attachments present (#184630) 2023-06-09 00:18:46 +02:00
Daniel Imms 773edabc84 xterm@5.2 2023-06-08 15:05:55 -07:00
meganrogge e5a9e630f1 rm standalone service 2023-06-08 15:35:43 -05:00
Megan Rogge 79f3509a44 Merge branch 'main' into merogge/editor-h 2023-06-08 15:25:23 -05:00
meganrogge 1b3a0bcaa1 get it to work 2023-06-08 14:54:21 -05:00
Tyler James Leonhardt dd2441f7ba Polish Sovereign Cloud support (#184634) 
* Use `@azure/ms-rest-azure-env` as official reference of endpoints
* Allow better configuration of custom clouds (these are new so it is ok to change the settings without migration)

Also clean up:

* querystring -> URLSearchParams (getting rid of a package dependency in the web)
* handle `workbench.getCodeExchangeProxyEndpoints` in one place
 2023-06-08 12:39:29 -07:00
Benjamin Pasero 1ea4242445 Notebook cannot be "Saved As" in empty profile (fix #184631) (#184632) 2023-06-08 21:04:42 +02:00
Andrea Mah 867f4ec164 bump ripgrep to 1.15.4 (#184625) 2023-06-08 20:07:23 +02:00
Connor Peet 8ddee2d272 testing: navigate to test on double click (#184626) 
Fixes #183835
 2023-06-08 20:01:57 +02:00
meganrogge 8af0a84670 wip 2023-06-08 12:56:12 -05:00
Connor Peet 6f568d087d cli: ensure code tunnel service is headless on windows (#184621) 
Fixes #184058
 2023-06-08 10:50:44 -07:00
Simon Siefke 68fdecfdc1 fix setTimeout leak in search view (#184537) 
fixes https://github.com/microsoft/vscode/issues/184536
 2023-06-08 10:08:18 -07:00
meganrogge 6b2b7e1884 Merge branch 'main' into merogge/editor-h 2023-06-08 11:02:01 -05:00
Ladislau Szomoru 908b24de44 GitHub - branch protection uses silent auth (#184609) 2023-06-08 17:59:26 +02:00
Connor Peet 991e5bdc4d fix: only use action toggled title when toggle state is on (#184611) 
Fixes #182066

cc @rebornix it looks like you added this code initially :)
 2023-06-08 17:58:21 +02:00
Daniel Imms fef218690d Merge pull request #184608 from microsoft/tyriar/183958 
Exclude query strings from detected local links
 2023-06-08 08:53:18 -07:00
Daniel Imms 911d1c0eab Merge pull request #184413 from microsoft/tyriar/184331 
Adopt EnvironmentVariableCollection in git ext
 2023-06-08 08:52:35 -07:00
Megan Rogge f2c53000fb Merge pull request #184435 from microsoft/merogge/accessibleView 
Create `AccessibleView`, use it for terminal and chat accessibility help menus
 2023-06-08 10:51:20 -05:00
Andrea Mah b7b2a8032c vscode.workspace.findFiles doesn't work with no workspaces open (#181951) 
Fixes #181583
 2023-06-08 08:47:27 -07:00
Johannes Rieken be966265ca IE to IC renames for API implementation but no changes to proposed API yet (#184605) 2023-06-08 10:45:01 -05:00
Daniel Imms 8ffaf6b7cc Exclude query strings from detected local links 
This was already happening on Windows, but now on Linux and macOS the ? will be
not allowed in any detected file path

Fixes #183958
 2023-06-08 08:30:39 -07:00
Ladislau Szomoru fbdddfde42 Git - upgrade which dependency (#184607) 2023-06-08 17:28:14 +02:00
meganrogge f8969daf91 Merge branch 'main' into merogge/accessibleView 2023-06-08 10:27:42 -05:00
meganrogge e6a59df1ad editor 2023-06-08 10:25:43 -05:00
Aiday Marlen Kyzy 631e85caf5 Merge branch 'aiday/internalIssue4344' into aiday/positioningInlineChat 2023-06-08 17:05:28 +02:00
Aiday Marlen Kyzy 13e2176f85 resetting the code as it was 2023-06-08 17:01:51 +02:00
Aiday Marlen Kyzy 72d20c98c3 renaming from with to given in the function name 2023-06-08 16:51:19 +02:00
Aiday Marlen Kyzy 73baf5f098 cleanin the code 2023-06-08 16:48:36 +02:00
Aiday Marlen Kyzy c3bd33203d checking that there is enough available space before doing the indentation 2023-06-08 16:33:38 +02:00
yshaojun 1621d38072 fix: cursor not visible at column 1 in mergeEditor(#183736) 2023-06-08 22:23:19 +08:00
Aiday Marlen Kyzy bc18e1b188 Merge pull request #184596 from microsoft/aiday/migratingCSSandLabelsIEtoIC 
Migrating the IE CSS variables and labels to IC
 2023-06-08 16:02:34 +02:00
Aiday Marlen Kyzy e06c6058a4 Merge pull request #184595 from microsoft/aiday/furtherLabelMigration 
Migrating the labels from IE to IC
 2023-06-08 16:01:02 +02:00
Keval ed835d2f85 FIX: conflict actions bar overlapping Complete Merge button fixed 2023-06-08 19:05:14 +05:30
Aiday Marlen Kyzy d3692b2a98 changes from review 2023-06-08 15:14:19 +02:00
Aiday Marlen Kyzy 169c0ed296 extracting the showing into a separate code 2023-06-08 15:02:14 +02:00
Aiday Marlen Kyzy 7dafe5df1d renaming the CSS variable names and the labels from interactive editor to inline chat 2023-06-08 14:41:41 +02:00
Alex Ross 8505eb1fd6 showOpenDialog with filter set doesn't show relevant dotfiles (#184592) 
Fixes #182730
 2023-06-08 14:41:10 +02:00
Aiday Marlen Kyzy f40ccebbce migrating the labels from IE to IC 2023-06-08 14:32:49 +02:00
Aiday Marlen Kyzy 094052c1e2 initial commit 2023-06-08 14:23:51 +02:00