Commit Graph

124157 Commits

Author SHA1 Message Date
Daniel Imms db23b5c7c3 Fix @xterm/headless not working on browser (it's compiled for node) 2024-07-03 04:41:33 -07:00
Daniel Imms 502b5628b1 Fix eslint rule suppressions in terminal/
Fixes #219708
2024-07-03 04:08:45 -07:00
Alex Ross 9255a27d88 Try out new YAML grammar (#219833)
* Try out new YAML grammar
Part of #180523

* Pull in other/plain update
2024-07-03 12:13:46 +02:00
Ladislau Szomoru 5c3b102d73 SCM - remove duplicate check code (#219826)
SCM - remove duplicate check
2024-07-03 10:26:06 +02:00
Johannes Rieken 65df72b152 Merge pull request #219816 from tisilent/configureSnippet-addLanguageIcon
Add Icons.
2024-07-03 09:54:17 +02:00
João Moreno e2af3117bf use unofficial 1espt (#219824) 2024-07-03 09:48:33 +02:00
Peng Lyu facf5e0650 Fix import. 2024-07-02 21:46:11 -07:00
tisilent 4b261a6d99 Add Icons. 2024-07-03 11:47:59 +08:00
Connor Peet 6ab3a15691 testing: simplify tests when actioning gutter items (#219809)
This adds a function to "simplify" tests by preferring to pass parent
items rather than child items when running tests via test gutter
decorations, when all children have been included. For https://github.com/microsoft/vscode-python/issues/21151
2024-07-02 17:07:12 -07:00
Eleanor Boyd 57fb6a2d7a Merge branch 'main' into rainy-dragonfly 2024-07-02 16:08:27 -07:00
eleanorjboyd 39c4f66a46 add current group as menu context 2024-07-02 16:00:01 -07:00
Matt Bierner e3d7449068 Fix a few more linting errors (#219803) 2024-07-02 23:34:46 +02:00
Simon Siefke 0cdc9b3341 fix: memory leak in extension tabs (#219726) 2024-07-02 19:25:39 +00:00
Raymond Zhao 139fa9d01c chore: use ip-address instead of ip (#219760) 2024-07-02 21:14:02 +02:00
eleanorjboyd 33efeef884 additions 2024-07-02 10:58:47 -07:00
Benjamin Christopher Simmonds ff6e9b259c Remove console.log (#219715)
remove console.log
2024-07-02 19:19:49 +02:00
Benjamin Pasero a375a9bb4f Multi tab: cannot drop multiple tabs into separate workspace window (#219671)
(fix #212885)
2024-07-02 18:40:07 +02:00
Connor Peet cacaccb42f net: gracefully disconnect better from remote (#218972)
* net: gracefully disconnect better from remote

This adds in a step to gracefully disconnect (send a "disconnect"
message and then await the flush) before closing the workbench. In some
cases, like Remote - SSH, sending messages is more async than others. In
the exec server connection we handle a `zlib.flate` stream to compress
data to and from the VS Code server, and its API is asynchronous, so
this lets us ensure the stream is drained before giving the go-ahead
to close up shop

This lifecycle phase is a little awkward and I ended it putting it
directly in the lifecycle service: we don't want to do this in
`onWillShutdown` because some contributions want to save data to the
remote workspace, and if shutdown is vetoed it would leave a broken
state. But `onDidShutdown` is synchronous and already depended upon by
several other points, and changing that also felt a bit risky.

cc @alexdima

Refs #211462, will require some small adoption in Remote - SSH to close.

* undo unrelated change

* add priority to joiners

* some cleanup

* cleanup

* tweaks

* `runWithFakedTimers`

* comment

* 💄

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2024-07-02 08:56:00 -07:00
Ladislau Szomoru 48e40d3c8e SCM - 💄 adopt observable in working sets (#219701) 2024-07-02 16:32:59 +02:00
Ladislau Szomoru 3c7cbd264e Git - include unstaged changes when amending a commit and smart commit is enabled (#219675) 2024-07-02 14:50:50 +02:00
João Moreno c395df82fb bump node-gyp once again 2024-07-02 14:12:39 +02:00
Benjamin Christopher Simmonds c57f7bbe78 fixes #213334 (#219669)
fixes 213334
2024-07-02 12:33:13 +02:00
Ladislau Szomoru c1f025d79f SCM - 💄 use editor placeholder instead of custom solution (#219662) 2024-07-02 12:13:39 +02:00
Benjamin Christopher Simmonds 4fb0b15298 Fix issue with clicking between active tabs (#219651)
* fix #213160

* cleanup

* 💄
2024-07-02 11:10:11 +02:00
Johannes Rieken b5c96d96ca debt - remove defaultImplicitVariables from agents and remove variable resolvers for inline chat (editor, notebook) (#219659) 2024-07-02 11:09:55 +02:00
Henning Dieterichs ad50f01dc1 Enables advanced hot reloading in monaco playground server. 2024-07-02 10:45:59 +02:00
Henning Dieterichs 0a16d3c1be Allows multiple hot reload handlers to participate 2024-07-02 10:45:30 +02:00
Ole c77c717e90 Support comments on Markup cells.
Fixes #214332.
2024-07-02 10:33:49 +02:00
Ole c2e17e2337 Refactoring: Extract shared fields of CodeCellLayoutInfo and MarkupCellLayoutInfo.
#214332.

Some layouting tasks, like soon layouting comments, should not have to deal with this distinction. I am extracting the fields that are already shared into an interface that other code can use without differentiating.

I am not yet actually moving their computation into a separate file, as that will require some small behavior changes.
2024-07-02 10:32:40 +02:00
Henning Dieterichs 0cc941e893 Fixes placeholder placement issues 2024-07-02 10:27:03 +02:00
Ole a3d69a6977 Refactoring: Move the computation of the commentOffset into the cell layouting function.
#214332.

The cellComments should not have to know about outputs. The reason this is undesirable is that these exist only for code cells, not for markup cells - and I would like to make cellComments work for markup cells as well.
2024-07-02 09:52:41 +02:00
Ole 9664fa5b79 Refactoring: Avoid repeating all layout properties in restoreEditorViewState.
This way it is easier to see what is not actually kept the same, and harder to forget to add a property when adding one.
2024-07-02 09:46:17 +02:00
João Moreno 3ad2eb18b5 bump node-gyp in build/npm/gyp (#219647) 2024-07-02 09:43:59 +02:00
Henning Dieterichs 01b9e01112 Fixes mangling issue in CI 2024-07-02 09:11:19 +02:00
Rob Lourens 42b3bac02e Dispose some child InstantiationServices (#219607)
#212879
2024-07-02 01:01:01 +02:00
Rob Lourens 0db947b90c Small chat renderer cleanup (#219597) 2024-07-01 15:52:12 -07:00
Robo a02f3c923d cli: restrict pkg config search directory to sysroot (#219572) 2024-07-01 19:59:38 +02:00
Henning Dieterichs 3652f9c8b3 Repairs hot reload for monaco editor playground. 2024-07-01 19:47:59 +02:00
Henning Dieterichs 01a77403bf Fixes wrapInReloadableClass* functions. 2024-07-01 19:46:18 +02:00
Henning Dieterichs 013b1861dc Fixes potential leak 2024-07-01 19:40:01 +02:00
Henning Dieterichs cf3e2a4e81 Fixes #211403 2024-07-01 19:35:00 +02:00
Benjamin Pasero 327279994e debt - update path.ts to node.js 20.x (#219560)
first cut update
2024-07-01 18:30:08 +02:00
Henning Dieterichs db7e8f1f1d Disables wrapInReloadableClass (#219555) 2024-07-01 08:32:55 -07:00
Sandeep Somavarapu 2601618162 fix #219336 (#219553)
fix #219336 (#219337)

* fix #219336

* fix owner
2024-07-01 16:37:47 +02:00
Benjamin Christopher Simmonds 473e348591 Improve compact badge display (#219552)
Show up to 3 characters in compact badge
2024-07-01 16:31:26 +02:00
Henning Dieterichs b213c86284 Extracts hot reload utilities, makes placeholderText contribution hot reloadable 2024-07-01 16:16:06 +02:00
Benjamin Pasero af5cf640d8 🆙 "@playwright/test": "^1.45.0" (#219324) 2024-07-01 12:23:41 +02:00
Martin Aeschlimann 4c69ceba2f rename editor.collapsedText to foldPlaceholderForeground (#219338)
rename vscode-editor-collapsedText
2024-07-01 12:13:03 +02:00
Benjamin Pasero d65fd5ba2e nls follow up debt work (#219265) 2024-07-01 11:44:19 +02:00
Johannes Rieken 376a7f73ed Merge pull request #218896 from microsoft/joh/debt/inlineChatAgentAndCommands
let inline chat use default command and agent completions
2024-07-01 11:30:34 +02:00