Commit Graph

124157 Commits

Author SHA1 Message Date
Johannes Rieken 1c967bb7c6 fix leaking listeners, track dispoable workbench contributions (#214301)
* fix leaking listener

https://github.com/microsoft/vscode/issues/214234

* track disposable workbench contribution and dispose them on shutdown fyi @bpasero

https://github.com/microsoft/vscode/issues/214234

* fix leaking listener

https://github.com/microsoft/vscode/issues/214234
2024-06-05 08:38:34 +02:00
Sandeep Somavarapu 539e22e69a adopt to new vsce-sign (#214300) 2024-06-05 08:27:14 +02:00
Connor Peet 337a8f18da userActivity: maintain user activity while there's progress in the window (#214264)
Fixes #211064
2024-06-05 07:08:11 +02:00
Joyce Er ee56498a56 refactor: remove includeSymbols from quick access (#214288) 2024-06-04 17:39:23 -07:00
Alexandru Dima f5f105b0d8 Fixes #207802 (#214284) 2024-06-04 17:34:36 -07:00
Alexandru Dima 0d833112df Reduce casts (#211878) (#214282) 2024-06-04 16:59:38 -07:00
Peng Lyu 0ec39fa2d0 Re #212879. track child instantiation service for notebooks (#214281) 2024-06-05 00:42:42 +02:00
Peng Lyu 90a47ca3d8 Re #211878. Fix unsafe type assertions for notebooks (#214280) 2024-06-05 00:37:20 +02:00
Alexandru Dima f8558ae979 Fixes #207445 (#214266)
* Fixes #207445

* Fix problem with disposing
2024-06-05 00:31:05 +02:00
Connor Peet 9e5acb365e eng: dispose child instantiation service instances in debug and testing (#214279)
Refs #212879
2024-06-05 00:29:20 +02:00
Remco Haszing a131a88231 Replace removeChild with remove (#213465)
* Replace removeChild with remove

This replaces most uses of `parent.removeChild(child)` with
`child.remove()`.

The two are almost equivalent. The only difference is that
`parent.removeChild(child)` throws if the given node is not a child of
the parent, whereas `child.remove()` never throws. There is no noticable
performance difference. The only reason to use `removeChild` is to
support Internet Explorer, but that’s no longer supported by Monaco
editor.

* Fix broken CSP hash

The script content changed, so the sha256 hash changed too.

* Update src/vs/editor/browser/config/charWidthReader.ts

Co-authored-by: Logan Ramos <lramos15@gmail.com>

---------

Co-authored-by: Logan Ramos <lramos15@gmail.com>
2024-06-05 00:21:08 +02:00
Connor Peet 5ca72043a3 debug: support 'source' in group output events (#214278)
Fixes #212304
2024-06-04 15:20:52 -07:00
Francisca Carneiro f93c5bc0c5 Fix #182308: Pressing PageUp in the search panel no longer causes the layout to change. (#213067)
Bug (previous behavior):
    1.Press Ctrl+Shift+F to open the search panel.
    2.Enter any text into the search input.
    3.Press PageUp/PageDown.
    4.The layout shifts to the right, hiding the line that indicates the current tab in the activity bar.

Solution:
When search results are displayed, pressing PageUp or PageDown now moves the cursor to the start or end of the search input, respectively. This is achieved by assigning specific functionality to these keys, overriding their default behavior of moving through the page.

Testing:
A smoke test was implemented to assess the fix. The test involves entering text into the search editor, pressing the PageUp and PageDown keys, and checking for any changes in the activity bar's layout.
2024-06-04 15:13:40 -07:00
Connor Peet 4af0c6a8f4 testing: fix confusing line decorations when hovering over line numbers (#214275)
Fixes #212585
2024-06-04 23:18:21 +02:00
Henning Dieterichs ad4f719bd5 Inline completions refactoring (#214272) 2024-06-04 14:02:31 -07:00
Megan Rogge d9148b110e mute terminal hint color (#214173)
fix #213647
2024-06-04 13:55:17 -07:00
Megan Rogge 55fdf62594 dispose terminal hint decoration on config change (#214178) 2024-06-04 13:54:56 -07:00
Connor Peet 8d662c804b testing: fix new test runs are not collapsible (#214271)
Fixes #212875
2024-06-04 13:36:21 -07:00
Connor Peet 42fe841df7 testing: ensure run all runs everything, use consistent profile for re-runs (#214260)
* testing: ensure run all runs everything, use consistent profile for re-runs

Fixes #212628

* fixup

* fix compile
2024-06-04 22:10:41 +02:00
Alexandru Dima 4d465ecade Avoid leaking disposables (#214234) (#214268) 2024-06-04 12:26:07 -07:00
Alexandru Dima ef849e41ee Fixes #207457 (#214267) 2024-06-04 21:18:19 +02:00
Daniel Imms cba48d8efe Merge pull request #214263 from microsoft/tyriar/api_fix
Fix typo in shell integration api docs
2024-06-04 11:53:20 -07:00
Daniel Imms 63f7354682 Merge pull request #214259 from microsoft/tyriar/213694
Remove CommandDetectionCapability.hasInput
2024-06-04 11:50:59 -07:00
Connor Peet 447099bc5e testing: fix "Run Tests" explorer option does not discover tests before trying to run (#214261)
Fixes #212342
2024-06-04 20:49:48 +02:00
Daniel Imms c42ce37dc8 Fix typo in shell integration api docs 2024-06-04 11:34:27 -07:00
Daniel Imms 30e78576e7 Support for OSC52 clipboard access
Fixes #193508
2024-06-04 11:32:59 -07:00
Daniel Imms c330f7468f Merge pull request #214258 from microsoft/tyriar/214234
Register some listeners
2024-06-04 11:09:55 -07:00
Daniel Imms 201adc0103 Remove CommandDetectionCapability.hasInput
Fixes #213694
2024-06-04 10:59:32 -07:00
Daniel Imms 932303ba65 Register some listeners
Part of #214234
2024-06-04 10:52:59 -07:00
Daniel Imms db894f6d6c Add example usage to exitCode
Part of #145234
2024-06-04 10:45:33 -07:00
Sandeep Somavarapu a4aa0a330d more profile editor improvements (#214255) 2024-06-04 19:31:20 +02:00
Aaron Munger 6378dbe3cc dont calculate element dimensions before styles are loaded (#214249)
* dont calculate element dimensions before styles are loaded

* remove unused import
2024-06-04 10:03:08 -07:00
Alex Ross 04a79b6ea6 Add API proposal to reveal a comment thread (#214251)
Fixes #167253
2024-06-04 10:00:49 -07:00
Connor Peet aef8e26d88 serve-web: fix SECRET_KEY_MINT_PATH does not honour server-base-path (#214250)
Fixes #212369
2024-06-04 09:57:17 -07:00
Andrea Mah 25ce414a16 Merge pull request #214190 from microsoft/andreamah/issue214189
should not use `max_int` as default for for `maxResults`
2024-06-04 09:00:18 -07:00
Henning Dieterichs 430451db35 Merge pull request #214241 from microsoft/hediet/b/sophisticated-canid
Fixes #214049
2024-06-04 17:21:56 +02:00
Henning Dieterichs 7e64cba5a1 Fixes #214049 2024-06-04 17:03:16 +02:00
Henning Dieterichs 3bb57eb6ef improves obsCodeEditor helper (#214215)
* improves obsCodeEditor helper
2024-06-04 16:17:50 +02:00
Alexandru Dima 0fba8ea5f4 Fixes #207433 (#214233) 2024-06-04 15:56:57 +02:00
Alexandru Dima 8a474b4d16 Fixes #207423 (#214232) 2024-06-04 15:53:39 +02:00
Ladislau Szomoru 75142169cf Engineering - update winget configuration file (#214228)
* Engineering - update winget configuration file

* Fix the version number
2024-06-04 15:27:50 +02:00
Ladislau Szomoru 463c55397c SCM - fix timing issue with setting context keys (#214229) 2024-06-04 15:23:10 +02:00
Ladislau Szomoru 7994fdb1ce SCM - fix input theming (#214225) 2024-06-04 05:31:35 -07:00
Alex Ross d674a83b12 Comment text cut off in comments panel (#214212)
Fixes #212956
2024-06-04 14:11:14 +02:00
Aiday Marlen Kyzy a790cb6a7e Refactoring the contentHoverController.ts file (#214214)
refactoring the content hover controller file
2024-06-04 12:36:10 +02:00
Ladislau Szomoru 3aba04042a SCM - 💄 remove the use of a sequencer (#213997)
* Revert "SCM - all calls from extHostSCM to mainThreadSCM should use a sequencer to ensure that the source control object is created (#213792)"

This reverts commit 24dd222ff2.

* Initial implementation

* Pull request feedback

* Revert unnecessary change

* Use map of barriers instead

* 💄 rename
2024-06-04 12:26:26 +02:00
Johannes Rieken d02c5b0807 Merge pull request #214144 from microsoft/joh/intense-heron
Use `esModuleInterop` flag, adopt star-imports
2024-06-04 12:22:54 +02:00
Aiday Marlen Kyzy c46c45742e Store minRebuildRromLine field so sticky scroll is ultimately correctly rerendered (#213916)
* adding changes

* on this branch we have all the other changes

* using the next rebuild from line variable

* adding changes

* polishing the code
2024-06-04 11:06:21 +02:00
Benjamin Pasero 3f40253059 Merge branch 'main' into joh/intense-heron 2024-06-04 09:28:53 +02:00
Benjamin Pasero 00f0f260b9 esm - remove graceful-fs (#214164)
* esm - remove `graceful-fs`

This module was used to patch `fs`, which is not supported in ESM. Besides, it makes us behave different from standard node.js that has meanwhile evolved from the time where `graceful-fs` was created.

* update comment

* update comment

* use more `fs.promises`

* 💄
2024-06-04 09:27:08 +02:00