Commit Graph

124157 Commits

Author SHA1 Message Date
Matt Bierner 4c296be787 Pick up latest ts for building VS Code 2024-08-12 11:17:00 -07:00
Megan Rogge 2e0584a810 revert #225297 (#225416) 2024-08-12 11:08:03 -07:00
Tyler James Leonhardt a8b2cef91c Adopt error template and some minor tweaks to error rendering (#225426)
NOTE: For this to get lit up, this PR needs to go in in MSAL-node: https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/7247
2024-08-12 20:05:04 +02:00
gjsjohnmurray 1da3bb3712 Fix bad capitalization (#225429) 2024-08-12 18:56:57 +01:00
Connor Peet 7dde0a7943 eng: fix --run path in electron tests not working (#225422)
I assume this broke with some of the ESM work, but I have no idea how it was working before. This should be a better fix.
2024-08-12 18:58:54 +02:00
Daniel Imms 65d1afaf4e Merge pull request #225412 from microsoft/tyriar/npm_arch
Update node-pty, use right binary on arm64
2024-08-12 08:19:10 -07:00
Alexandru Dima d1dc00ab3a Remove workspace setting (#225407) 2024-08-12 16:49:38 +02:00
Daniel Imms 22f65157a4 Update node-pty, use right binary on arm64
Fixes #225355
2024-08-12 07:48:17 -07:00
Benjamin Pasero d0857f8ec9 linux - support for window control overlay (#225306) 2024-08-12 15:49:56 +02:00
Aleksei Gusev 1b401f6108 fix: merge.toggleActiveConflict as shortcuts (#225320)
Fixes #225319

When Merge Editor's actions are assigned to keyboard like this:

```json
[
    {
        "key": "ctrl+g a",
        "command": "merge.toggleActiveConflictInput1",
        "when": "isMergeEditor"
    },
    {
        "key": "ctrl+g b",
        "command": "merge.toggleActiveConflictInput2",
        "when": "isMergeEditor"
    },
    {
        "key": "ctrl+g ctrl+a",
        "command": "merge.acceptAllInput1",
        "when": "isMergeEditor"
    },
    {
        "key": "ctrl+g ctrl+b",
        "command": "merge.acceptAllInput2",
        "when": "isMergeEditor"
    },
]
```

Any of such action changes the state of the merged editor so diff range
becomes locked, i.e. even if a cursor is moved to another diff range the
actions target the locked one. If focus is changed the merge editor
returns to a normal state. This behavior is only reproducible if all the
actions are performed with keyboard because mouse clicking and calling
the actions from the command pallette changes the focus and everything
works correctly.
2024-08-12 13:35:58 +00:00
Henning Dieterichs 692ef95051 Refactors code and fixes memory leak. Fixes #224943. 2024-08-12 12:05:33 +02:00
Don Jayamanne b60fe002f5 Dispose Notebook DiffEditor ViewModels (#225369)
* Dispose Notebook DiffEditor ViewModels

* Fix tests
2024-08-12 17:38:19 +10:00
João Moreno ef656d3f1d increase CG timeout (#225373) 2024-08-12 09:31:43 +02:00
Don Jayamanne df9800f93d Support viewing whitespace diff in nb diff viewer 2024-08-12 10:57:06 +10:00
Daniel Imms 3909bef4e4 Merge pull request #225353 from microsoft/tyriar/225043_2
Switch runOnEnter default to ignore
2024-08-11 09:34:45 -07:00
Daniel Imms ed3fc25441 Merge pull request #225351 from microsoft/tyriar/221351
Fix max line context allowed when detecting links
2024-08-11 09:34:28 -07:00
Megan Rogge 7c2663f1a7 provide way to adjust table column size via keyboard (#225081) 2024-08-11 08:35:27 -07:00
Daniel Imms b39244cc66 Switch runOnEnter default to ignore
Fixes #225043
2024-08-11 08:18:43 -07:00
Daniel Imms dabc7bee87 Fix max line context allowed when detecting links
Fixes #221351
2024-08-11 08:15:08 -07:00
Daniel Imms 4b78857fd9 Merge pull request #225336 from microsoft/tyriar/225330
Pause terminal input while completions are requested
2024-08-10 18:14:10 -07:00
Daniel Imms 310f09f84b Pause terminal input while completions are requested
Fixes #225330
2024-08-10 16:16:54 -07:00
Daniel Imms a3be5f6c23 Merge pull request #225266 from microsoft/tyriar/node-pty-update
node-pty@1.1.0-beta20
2024-08-10 07:17:18 -07:00
Robo 00427fda20 chore: update electron@30.3.1 (#225106)
* chore: update electron@30.3.1

* temp: update distro

* chore: update node.js builds

* temp: update distro

* temp: revert node-pty

* Revert "temp: revert node-pty"

This reverts commit e834f75959ffd0078708db764457e05ec0f3b6b6.

* temp: test with oss electron

* chore: update node.js checksums

* Revert "temp: test with oss electron"

This reverts commit 18506aaa82b2cf44e4b5780eac1b929bbf98ac11.

* temp: disable sandbox for smoke tests

* Revert "temp: disable sandbox for smoke tests"

This reverts commit 8596ef5fcc776cc9a14b4546f9e448ccba2acbad.

* test: skip icon validation task smoke tests

* chore: bump distro
2024-08-09 23:44:42 +00:00
Megan Rogge 022d11417c fix repl find being jumpy bug (#225297) 2024-08-09 15:33:41 -07:00
Joyce Er 8723e832e6 fix: resolve location data for rerun requests (#225299) 2024-08-09 15:26:09 -07:00
Joyce Er fd9ab39ea1 fix: increment attempt for rerun without intent detection 2024-08-09 14:58:33 -07:00
Joyce Er 2bd050b84b fix: set enableCommandDetection: false if VS Code did intent detection 2024-08-09 14:58:33 -07:00
Peng Lyu 77eb6b636c Fix #224437. Move cells command should read cell toolbar context. (#225278)
* Fix #224437. Move cells command should read cell toolbar context.

* adjust move cell actions argument to be INotebookActionContext and fix tests.
2024-08-09 14:02:17 -07:00
Tyler James Leonhardt 8b63eeeb83 Dispose of handlers on dispose in QuickPick API (#225286)
Dispose of handlers on dispose

fixes https://github.com/microsoft/vscode/issues/225158
2024-08-09 13:58:16 -07:00
Michael Lively 24080f954c Support commenting cells outside of viewport + range tracking (#225187)
* commenting off viewport + range tracking

* use `CommandExecutor` + `trackedRanges` directly

* SmartStop, the smarter way to store (your editor comment settings)

* readability

* feedback

* sneaky comment

* unnecessary exports
2024-08-09 13:53:17 -07:00
Justin Chen 9c32d85c03 add issue reporter into table of contents (#225281) 2024-08-09 13:33:02 -07:00
Megan Rogge 4c8198c19f update sounds (#225269) 2024-08-09 13:32:06 -07:00
Tyler James Leonhardt 70d27743ac Ability to use MSAL in the Desktop (#225272)
* Ability to use MSAL in the Desktop

* add comment about MSAL workaround
2024-08-09 12:18:34 -07:00
Peng Lyu 2b8f4b8440 Adjust virtualized editor position when editor content height changes. (#225275) 2024-08-09 12:10:51 -07:00
Benjamin Pasero 79f7411c88 esm - reduce diff (#225220)
* esm - reduce diff

* restore more

* ok

* undo

* .
2024-08-09 10:52:26 -07:00
Megan Rogge e75cca1eaf simplify and fix chat response accessible view logic (#225268) 2024-08-09 10:23:05 -07:00
Anthony Kim 9b803e988b Add Julia as Shell type (#225083)
* Start adding Julia as Shell type

* remove unncessary

* dont touch original

* add julia.exe to windowsShellHelper & clean up

* remove completed TODO

* format
2024-08-09 10:16:54 -07:00
Daniel Imms 6aabf62454 Merge pull request #225267 from microsoft/tyriar/225265
Add exe to file boosts, polish order
2024-08-09 10:04:47 -07:00
Megan Rogge 92feede427 alert SR users of tree find result count (#225264) 2024-08-09 09:52:52 -07:00
Daniel Imms 297cd2325d Merge pull request #225263 from microsoft/tyriar/empty_collection
Remove dummy value in favor of empty collection
2024-08-09 09:51:42 -07:00
Daniel Imms e6300d4fa1 Add exe to file boosts, polish order
Fixes #225265
2024-08-09 09:47:19 -07:00
Daniel Imms 1495b65c64 node-pty@1.1.0-beta20
Brings in https://github.com/microsoft/node-pty/pull/703
2024-08-09 09:41:33 -07:00
Aaron Munger 2d7e6c7bde fix run button to execute REPL input box (#225259)
fix run button exe
2024-08-09 09:32:30 -07:00
Daniel Imms ccbe685538 Remove dummy value in favor of empty collection
This is the right way to handle zero completions, instead of using a dummy ~ value
2024-08-09 09:26:50 -07:00
Raymond Zhao 25006fe8b1 chore: polish APIScan and BinSkim scans (#222106) 2024-08-09 09:19:36 -07:00
Megan Rogge 76c24b3920 Bring filter widget back to debug console (#225261) 2024-08-09 09:18:18 -07:00
Henning Dieterichs e312bc053b Implements command "Developer: Debug Extensions In New Window" 2024-08-09 18:16:06 +02:00
Aiday Marlen Kyzy e4843ae75e Extracting HoverController code into Content Hover Controller and Margin Hover Controller (#225239)
* adding code

* renaming to 2

* polishing the code

* adding code
2024-08-09 15:17:22 +02:00
Alex Ross 7f71c79c95 Refactor GrammarTokens in to AbstractTokens (#225236)
* WIP: super basic highlighting working with layer breaker

* Fix layer breaker

* Add tree sitter "scope" inspection

* Make some reasonable highlights

* Fix event error and more highlights improvements

* Handle offline PR feedback

* Scope change to just AbstractTokens refactor

* Remove tokenization registry from AbstractTokens
2024-08-09 05:51:47 -07:00
Henning Dieterichs dcb70c6b92 Fixes bug in EmitterObserver 2024-08-09 14:45:58 +02:00