Commit Graph

2961 Commits

Author SHA1 Message Date
Alex Dima
8abc9e4a17 more improvements for #78168 2019-08-05 15:47:14 +02:00
Daniel Imms
1e3cc1a30d Don't fail hard when shell/shellArgs vars aren't resolved
Fixes #78307
2019-08-01 16:04:32 -07:00
Rob Lourens
566d77238e Merge pull request #77824 from microsoft/roblou/remoteEnvReconnection
Fix remote EH environment after reconnection
2019-07-31 14:30:26 -07:00
Gabriel DeBacker
5e135c4caf Make exception error more accurate 2019-07-30 08:35:06 -07:00
Gabriel DeBacker
9bbf3f25d5 Make sure that task definition is not changed in resolved task 2019-07-30 08:20:29 -07:00
Gabriel DeBacker
506d55d171 Merge remote-tracking branch 'upstream/master' 2019-07-30 08:06:23 -07:00
Daniel Imms
426bdb6122 Don't fail silently 2019-07-29 15:27:29 -07:00
Logan Ramos
6dfbb7f196 Merge remote-tracking branch 'microsoft/master' into resolve-terminal-cwd 2019-07-29 10:41:43 -07:00
Daniel Imms
e2888839ec Don't throw out ext host proc requests on slow remotes
Fixes microsoft/vscode-remote-release#1031
2019-07-26 16:48:01 -07:00
Daniel Imms
6bb5e193f9 start -> open, exit -> close, remove exit code 2019-07-26 15:30:36 -07:00
Daniel Imms
8f485ebbbb Merge remote-tracking branch 'origin/master' into tyriar/77160 2019-07-26 10:17:24 -07:00
Andre Weinand
be873f7169 pass env and cwd to createTerminal; fixes #77111 2019-07-26 15:16:36 +02:00
Daniel Imms
9b60caf9e0 Improve naming of start/spawn request calls 2019-07-25 16:09:03 -07:00
Daniel Imms
3866deba35 Use pty naming instead of virtual process
Part of #77160
2019-07-25 16:00:41 -07:00
Logan Ramos
68c125c344 Resolve CWD 2019-07-25 15:42:52 -07:00
Andre Weinand
9d8d084129 properly use default terminal for debug; fixes #77110 2019-07-25 19:06:02 +02:00
Daniel Imms
3c71e404fd Merge pull request #77664 from lramos15/shell-path-error-remote
Allows terminal errors to work in the remote case
2019-07-24 15:02:43 -07:00
Logan Ramos
9f5fffe73e More strongly typed telemetry events (#77658)
* More strongly typed events

* Fixed typo
2019-07-24 15:02:16 -07:00
Daniel Imms
0927be89c8 Tweak names, make shellLaunchConfig readonly again 2019-07-24 14:29:24 -07:00
Rob Lourens
70ab0ada55 Fix 'null' exclude for findFiles, add more tests
Fix #77813
2019-07-24 14:24:13 -07:00
Daniel Imms
87a474c36a Merge remote-tracking branch 'origin/master' into pr/lramos15/77664 2019-07-24 14:11:29 -07:00
Daniel Imms
36e08fed41 Merge pull request #77839 from microsoft/tyriar/task_vp_fix
Add CustomExecution2 test and make start fire after onDidOpenTerminal
2019-07-24 11:40:16 -07:00
Logan Ramos
4008ea909e Merge remote-tracking branch 'microsoft/master' into shell-path-error-remote 2019-07-24 11:22:02 -07:00
Martin Aeschlimann
3e98ad5177 add 'remoteName' context key (replaces remoteAuthority) 2019-07-24 17:26:16 +02:00
Johannes Rieken
6a25cfa60c Merge pull request #72345 from hedgerh/command-execute-events
onDidExecuteCommand API
2019-07-24 14:45:33 +02:00
Daniel Imms
9d43802fd4 Create CustomExecution2 test, make start fire after onDidOpenTerminal
Part of #70978
2019-07-23 17:35:11 -07:00
Daniel Imms
f49e26d055 Merge remote-tracking branch 'origin/master' into tyriar/task_vp_fix 2019-07-23 15:31:11 -07:00
Andre Weinand
3caba64433 move handshake to eh 2019-07-23 17:55:59 +02:00
Rob Lourens
c23b8fd5e1 Fix remote EH environment after reconnection
For microsoft/vscode-remote-release#16
2019-07-23 08:37:13 -07:00
Logan Ramos
170beba5db Move resolve shell launch config above fork the process 2019-07-22 07:33:49 -07:00
Gabriel DeBacker
793fc0295c Use correct resolved TDO and task for custom execution 2019-07-22 06:58:16 -07:00
Sandeep Somavarapu
53fe1660c9 Move download command to extension host 2019-07-20 05:17:46 +02:00
Rob Lourens
04c4de6a38 Change remoteEnv extension API to be backwards compatible 2019-07-19 14:56:37 -07:00
Rob Lourens
7ee0e1818a Give remote resolvers a way to set environment variables in the remote EH
Fix #77234, for microsoft/vscode-remote-release#16
2019-07-19 14:56:37 -07:00
Daniel Imms
ce28d57e21 Use async 2019-07-19 12:23:50 -07:00
Logan Ramos
d826dfd943 Allow remote error messages to work 2019-07-19 11:19:00 -07:00
Daniel Imms
26d8b4de8a Merge remote-tracking branch 'origin/master' into tyriar/task_vp_fix 2019-07-19 09:26:42 -07:00
Martin Aeschlimann
6163b86243 add gotoLineMode to IOpenSettings 2019-07-18 16:56:14 +02:00
Logan Ramos
f50a0430c3 More strongly typed telemetry (#77412)
* More strongly typed telemetry

* Updated update service to not duplicate typings
2019-07-17 08:29:25 -07:00
Daniel Imms
48e7c6d927 Fix start cb in CustomExecution2
Fixes #77428
2019-07-16 15:10:17 -07:00
Logan Ramos
0a8ca638f1 Resolve Terminal arguments (#76895)
* Resolved terminal argds

* Move location of resolution

* Fix routing of resolver in extHost

* Remove unnecessary comma

* Compilation errors

* some async stuff

* Undo changes

* Variable resolver in constructor

* Load resolver upon construction of extHostTerminalService

* Utilize last active workspace root

* Reevaluate variableReoslver whenever the workspace gets new folder

* Fix types for string shellArgs

* Use async one level higher

* Fix compile issue

* Initialize resolver when exthost is created

* Fix ext host in remote case with no folder open

* Resolve args that an ecxctension passes in

* Remove TODO

* Resolve extension arguments
2019-07-16 09:23:38 -07:00
Matt Bierner
7411e3f341 Convert many simple getters for events into readonly properties
We seem to use the readonly property way of exposing these values more widely. Standardizing this a bit across the codebase
2019-07-15 16:12:25 -07:00
Matt Bierner
4eb2bf393b Use DisposableStore 2019-07-15 15:03:54 -07:00
Daniel Imms
c9cfc7c5ed Merge remote-tracking branch 'origin/master' into tyriar/77228_dimensionss 2019-07-12 10:42:34 -07:00
Sandeep Somavarapu
b3422b98b7 Merge pull request #76377 from microsoft/sandy081/fix74859
trigger workspace contains activation event on new folders
2019-07-12 16:42:56 +02:00
Alex Dima
498f158475 Small style tweaks 2019-07-12 16:13:27 +02:00
Daniel Imms
3092a1023c Remember dimensions from other terminals
Part of #77228
2019-07-11 21:18:06 -07:00
Daniel Imms
5701770f87 Ensure negative exit codes are not used
Fixes #77250
2019-07-11 15:47:15 -07:00
Johannes Rieken
3a47abace1 create instantiation service in api.impl and create extHostDebug with it, #76570
also tweak some names and types
2019-07-11 17:02:01 +02:00
Rachel Macfarlane
877235c625 Remove old proposed commenting API 2019-07-10 11:11:14 -07:00