Commit Graph

123 Commits

Author SHA1 Message Date
Johannes Rieken
eb2f7c1a35 add secondary inline chat menu and render response commands there (#226621)
fixes https://github.com/microsoft/vscode-copilot/issues/7368
fixes https://github.com/microsoft/vscode-copilot/issues/6650
2024-08-26 16:06:26 +02:00
Johannes Rieken
cd09f4a11e consider cancel state when recomputing response type context key (#226409)
re https://github.com/microsoft/vscode-copilot/issues/7324
2024-08-23 11:46:17 +02:00
Johannes Rieken
149a026ff9 show toggle diff in zone only when it applies (#226257) 2024-08-22 16:18:57 +02:00
Johannes Rieken
f12921b077 fixes https://github.com/microsoft/vscode-copilot/issues/7481 (#226256) 2024-08-22 16:18:40 +02:00
Johannes Rieken
6f13ec62fc chore - inline chat work (#226139)
* chore - prepare inline chat to be started with an existing model that has edits

* debt - remove `SessionExchange` et al.

* Makes inline chat be entirely grounded in the chat model
* Removes the copy recordings command which never got used
2024-08-21 11:55:19 +02:00
Johannes Rieken
3b44b1102b fix https://github.com/microsoft/vscode-copilot/issues/7326 (#226065) 2024-08-20 16:23:56 +02:00
Johannes Rieken
9330962d6b use X icon for discard changes (#226062) 2024-08-20 15:55:01 +02:00
Johannes Rieken
469f45091d add InlineChatController#reviewEdits which allows to reuse the inline code review flow/ui (#225981) 2024-08-19 17:51:14 +02:00
Johannes
4933da3c20 Revert "fix: resolve location data for rerun requests (#225299)"
This reverts commit 8723e832e6.
2024-08-13 17:45:04 +02:00
Johannes Rieken
3218292d9d remove ExpTextButtons setting and logic but keep make buttons more dynamic (#225495) 2024-08-13 16:00:26 +02:00
Joyce Er
8723e832e6 fix: resolve location data for rerun requests (#225299) 2024-08-09 15:26:09 -07:00
Rob Lourens
c21836e428 Enable cmd+up to focus chat list in terminal and inline chat widgets (#224645)
* Enable cmd+up to focus chat list in terminal and inline chat widgets
Fix #218088

* Clean up
2024-08-02 15:20:18 -07:00
Johannes Rieken
e5d157c069 Inline chat fixes (#218318)
* fix https://github.com/microsoft/vscode/issues/218059

* Change enablement of "Toggle Changes" instead of visibility

mitigates/fixes https://github.com/microsoft/vscode/issues/218099

* have padding per part (actions, input, list)

fixes https://github.com/microsoft/vscode/issues/218083

* fixes https://github.com/microsoft/vscode/issues/218021

* fix notebook button groups for inline chat

* tweak inline chat content widget when text btn are enabled
2024-06-26 13:18:47 +02:00
Johannes Rieken
d64446d9a2 filter send and cancel actions from execute toolbar (#216801)
* * fixes https://github.com/microsoft/vscode/issues/216692
* make text-btn with command but with a little color

* * don't show close/view-in-chat while request is in flight

* filter send and cancel actions from execute toolbar

fixes https://github.com/microsoft/vscode/issues/216772
2024-06-21 13:12:27 +02:00
Johannes Rieken
a11602734b inline chat positioning polish (#216630)
* make sure to show close button when having just message responses

* * no more intented rendering of inline chat
* make sure the top of the view zone is always revealed
2024-06-19 18:10:43 +02:00
Johannes Rieken
88d860624c Inline chat UI overhaul (#215927)
* don't dimiss inline chat content widget when already having typed something

https://github.com/microsoft/vscode-copilot/issues/6067

* extract `TextOnlyMenuEntryActionViewItem` for reuse

* remove unused variables

* * show chat input below request/response pairs
* setting for text-only buttons
* more dynamic buttons
* always show the first request, don't repopulate input with last message
* keep progress bar hidden, rely on "Generating..."
* no more special background color

* add `minimal` renderer style for chat renderings

* tweak font-size for details when render mode is minimal

* stable scroll position for inline chat, don't push down the lines chat is editing but push the inline chat upwards

* more buttons more compact, tweak labels

* * add missing service dependency
* repopulate input for some unit test

* allow output from `InteractiveChatController` suite
2024-06-17 11:26:21 +02:00
Johannes Rieken
c0bbf0447e Cleanup and prepare inline chat for UI updates (#215420)
* 💄

* debt - remove `trackEdits` because we have fixup
debt - don't compute diff twice

* allow to pass/use all chat widget options when creating an inline chat widget
2024-06-13 11:24:50 +02:00
Johannes Rieken
b6c1b52bac Remove configure inline chat command from menu because it isn't popular at all and takes space (#213396)
also fixes https://github.com/microsoft/vscode-copilot/issues/5662
2024-05-24 16:50:41 +02:00
Johannes Rieken
e67cdb56b1 clean up dead context keys and other dead code (#213387) 2024-05-24 14:07:41 +02:00
Johannes Rieken
a54e247fba Enable roaming of inflight chat requests (#213239)
This enables to remove the special handling for `/explain`

- fixes https://github.com/microsoft/vscode-copilot/issues/2192
- fixes https://github.com/microsoft/vscode/issues/208706 because inline chat now closes on "view in chat"
- fixes https://github.com/microsoft/vscode-copilot/issues/5288
2024-05-22 18:47:03 +02:00
Johannes Rieken
95ffd765e1 chore - remove dead/stale commands (#213207) 2024-05-22 09:07:35 +02:00
Johannes Rieken
7680db2a11 Move rerun request back to prime spot, return with intent detection back as link (#212775)
* Bring back "Rerun Request" to its prominent spot

https://github.com/microsoft/vscode-copilot/issues/5604

* move rerun without gesture back into title

fixes https://github.com/microsoft/vscode-copilot/issues/5275
2024-05-15 09:31:04 +02:00
Megan Rogge
00bc1553ba create AccessibleViewRegistry, move all applicable views/accessibility help dialogs over to use it (#212138) 2024-05-07 05:48:04 +02:00
Johannes Rieken
10a1ae8d6c fix https://github.com/microsoft/vscode-copilot/issues/5342 (#211295) 2024-04-24 23:41:55 +02:00
Johannes Rieken
7d04d4df43 only have one report bug command (#210802) 2024-04-20 01:34:57 +02:00
Johannes Rieken
6a06de0033 Hook up feedback/user-action events for inline chat participants (#210040)
- add a special user-action
- inline chat controller doesn't call handleFeedback directly anymore
- ReplyResonse knows its chat model response
2024-04-10 13:15:40 +02:00
Johannes Rieken
ef6345ae05 Support for attempt and enableCommandDetection in chat model/service (#209826)
* add `IChatRequestModel#attempt` so that rerun request/response can be supported

* - support to run with/without command detection enabled
- adopt agent brigde to new chat request
- add share rerun-commands (but only enable them for inline chat for now)
2024-04-08 14:08:22 +02:00
Johannes Rieken
1d1c28eed1 Cleanup some inline chat debt (#209009)
* - make inline chat tab-able (fixes https://github.com/microsoft/vscode/issues/208569)
- fix aria label

* - move report issue into widget toolbar
- some todo-cleanup

* remove unused menuid
2024-03-28 13:07:01 +01:00
Johannes Rieken
9757f7c73a Make "Toggle Changes" more prominent and re-run less (#208917)
- add regenerage and regenerate w/o intent detection to response title menu
- have toggle changes command with accept and discard
- add context key for chat widget location
2024-03-27 17:30:18 +01:00
Johannes Rieken
b37d8bc51f show inline chat content widget below the selection (#208907)
* let close cancel/discard a vanilla inline chat session

fixes https://github.com/microsoft/vscode/issues/208585

* show inline chat content widget below the selection

https://github.com/microsoft/vscode/issues/208597
2024-03-27 15:26:11 +01:00
Johannes
ebfbf27d8c - fix layout bugs
- enable terminal history with new world
- fix (most) command group associations
2024-03-21 11:58:28 +01:00
Johannes
6ae696aa56 - first run of cleanup
- update new required services for tests and adjust them
2024-03-20 15:58:55 +01:00
Johannes
6931665097 - fix re-run and re-run with intent detection commands
- add support for tree-rendering detected command/agent in a special way
- first cut of tree-rendering for text edis
2024-03-20 12:38:04 +01:00
Johannes
e5385dac71 - use chat widget also for content widget (shared chat model)
- add TextEdits to chat model
- add IChatTextEdit and IChatUsedSlashCommand to chat progress types
-  hook up ad-hoc agent to inline chat session (no more custom commands)
- add new `State.SHOW_REQUEST` state for when new requests are made
2024-03-18 19:12:44 +01:00
Johannes
0ac95cc1b7 - use chat input part for content widget
- use chat widget over renderer-reuse and custom input
- allow to configure chat menus/actions
- allow to define filter for chat list/tree
2024-03-15 15:44:41 +01:00
Daniel Imms
1a5e878411 Merge remote-tracking branch 'origin/main' into merogge/chatWidget3 2024-03-06 06:40:02 -08:00
Johannes Rieken
b92a5dd3f0 relayout when zone widget width changes (#206963)
* inline - change the input editor to be a normal editor, not an embedded one

https://github.com/microsoft/vscode/issues/206940

* relayout when zone widget width changes
2024-03-06 14:01:19 +01:00
Johannes Rieken
9626fb0cd2 Inline chat widget tweaks (#206954)
* make status menu configurable

https://github.com/microsoft/vscode/issues/206940

* pull inline chat zone widget into its own file

* 💄

* remove expand/crop feature

* make chat message contents scrollable
2024-03-06 12:51:50 +01:00
meganrogge
7d546baaea align start command name with inline chat, get it to show up in command pallette 2024-02-27 10:08:15 -08:00
Henning Dieterichs
0bd70d48ad code editor move (#206074) 2024-02-23 14:35:45 +01:00
Johannes Rieken
7215958b3c add commands to navigate between hunks (#205293)
https://github.com/microsoft/vscode/issues/203349
2024-02-15 15:57:24 +01:00
Tyler James Leonhardt
246a3371b3 Move more strings to localize2 (take 2) (#204180)
* Revert "Revert "Adopt localize2 in more spots" (#204087)"

This reverts commit 5baa693de8.

* Keep only the localize2 changes

* revert accidental change to launch.json
2024-02-02 20:17:56 +01:00
João Moreno
5baa693de8 Revert "Adopt localize2 in more spots" (#204087)
Revert "Adopt localize2 in more spots (#204030)"

This reverts commit 7923151da4.
2024-02-02 09:59:59 +01:00
Matt Bierner
7923151da4 Adopt localize2 in more spots (#204030)
Another pass adopting localize2
2024-02-01 16:36:35 -08:00
Johannes Rieken
6aad7f2ec9 move StartSessionAction back to /browser/, add indirection for holdForSpeech-feature (#203890)
https://github.com/microsoft/vscode-copilot/issues/3857
2024-01-31 15:13:58 +01:00
Matt Bierner
777ea450a1 Adopt localize2 in more places (#203842)
Switches many callers to use `localize2` instead of duplicating strings
2024-01-31 02:16:25 +01:00
Johannes Rieken
cc593a387e inline chat tweaks and tests (#202984)
* update action ids

* detect user edits inside and outside of chat UI, add test for https://github.com/microsoft/vscode-copilot/issues/3523

* fix tests
2024-01-22 14:39:08 +01:00
Johannes Rieken
4217af7696 restore stashed sessions for when accidentially dismissing a session (#203006) 2024-01-22 14:31:23 +01:00
Johannes
481d7bb72d Use hold mode in start inline chat action to enable speech 2024-01-16 18:16:31 +01:00
Johannes
ec9ab00fae Merge branch 'main' into joh/bumpy-bonobo 2024-01-16 15:01:58 +01:00