Commit Graph

44 Commits

Author SHA1 Message Date
Martin Aeschlimann
ec02bcd1cc codicon definitions in browser/ui/codicon/codicon 2020-04-17 13:39:54 +02:00
Benjamin Pasero
a4207f7759 web - allow to contribute navigation entries (#93467) 2020-03-26 16:34:33 +01:00
SteVen Batten
c98a21d84a allow contributing a web menu entry 2020-03-25 19:09:27 -04:00
Benjamin Pasero
c6750ffa87 debt - careful with dispose() and assignments 2020-02-04 08:53:23 +01:00
SteVen Batten
85413004f4 refs #86428 2019-12-13 10:47:57 -08:00
SteVen Batten
f563cecb99 fixes #86428 2019-12-13 10:43:16 -08:00
Miguel Solorio
5854f63f43 Update menu icons to use icon font #86708 2019-12-12 14:42:00 -08:00
SteVen Batten
4565afecb6 fixes #82577 2019-11-01 17:25:05 -07:00
SteVen Batten
9d5a908b68 default prevention on scroll menu 2019-10-17 17:22:51 -07:00
Jean Pierre
d45eaa2f5e Fix scrolling behavior in menu while zoomed in (#80965)
* Fix scrolling behavior in menu while zoomed. Fixes #80047

* 💄

* move scrollbar click detection into menu

* confine preventScroll change to menu

* fix sticky scrollbar
2019-10-17 14:48:59 -07:00
SteVen Batten
a8461cf10f strictPropertyInit
refs #78168
2019-10-16 15:14:16 -07:00
SteVen Batten
a0fd93ac46 dont reposition overflow menu when it doesnt move
fixes #82078
2019-10-14 15:24:00 -07:00
SteVen Batten
346416d6c2 only left click on menubar
fixes #81954
2019-10-10 12:10:20 -07:00
isidor
c2997da2ac Gesture.addTarget returns an IDisposable
fixes #81630
2019-09-30 14:42:58 +02:00
SteVen Batten
56109c8aef fix console error when compact and navigating menu 2019-09-27 15:50:42 -07:00
SteVen Batten
d49dad0e9a Compact menubar option (#80900)
* working on the left side

* flow direction working

* flow direction

* use menubar visibility to set setting

* hide titlebar on the web

* fix hover feedback
2019-09-25 11:16:45 -07:00
Matt Bierner
cf446b9233 Build VS Code using TS 3.6
Fixes #80079

Updates our build to use TS 3.6. Fixes a few changes to dom apis and adds a monkey patch for the node typings break in 3.6
2019-09-02 21:27:52 -06:00
SteVen Batten
d93c8c49cb fixes #69655 2019-08-09 18:13:34 -07:00
SteVen Batten
73f20ecd0a menubar tab fix 2019-06-26 17:25:13 -07:00
SteVen Batten
cc9286cb90 tab menubar nav 2019-06-26 17:19:32 -07:00
SteVen Batten
27f3b675dc fixes #75703 2019-06-19 01:19:57 +00:00
Evgeny Zakharov
1151dab2bf add window.disableMenuBarAltBehavior option (#73258)
* add window.disableMenuBarAltBehavior option

* enable alt behavior when menuBarVisibility is set to 'toggle'

* rename 'window.disableMenuBarAltBehavior' to 'window.disableCustomMenuBarAltBehavior' and change its description

* don't affect mnemonics
2019-06-14 15:16:16 -07:00
Matt Bierner
219fadc70a Use readonly array to track actions in a few more palces in menus
The actions being passed around are generally not expected to be modified. Use ReadonlyArray to prevent this
2019-06-07 10:26:00 -07:00
Johannes Rieken
3a054ddc9f give DisposableStore set character (helps with #74446) 2019-05-28 11:45:30 +02:00
Matt Bierner
0f32f0ef5f Clean up some usages of IDisposable[]
Part of #74250

- Extend `Disposable` in classes where it makes sense
- Use `DisposableStore` for lists of disposables
- Make `combinedDisposable` take arguments instead of an array (so that you can't pass in an array and then modify the array after the fact)
2019-05-23 22:58:16 -07:00
Matt Bierner
bf7f750a19 Add asArray helper 2019-03-19 10:33:39 -07:00
Benjamin Pasero
1f64c12672 Use get/setAttribute() (#70477)
* Use get/setAttribute()

* fix strict null
2019-03-14 11:33:45 -07:00
SteVen Batten
32dc72e557 fixes #70022 2019-03-12 15:47:30 -07:00
SteVen Batten
6770dd762d fix/69830 2019-03-05 16:02:52 -08:00
Matt Bierner
243d3a482b Strict null work in menubar 2019-03-05 10:00:06 -08:00
SteVen Batten
460645a1f5 fix russian mnemonics
fixes #69515
fixes #62449
2019-02-27 11:16:39 -08:00
SteVen Batten
c00e22501c New Accessibility Service depending on new native node module (#68973)
* new reg service and always on mnemonics

* missed one

* use new node module and accessibility service

* add typings

* adopt accessibility service

* make it lazy
2019-02-21 11:10:03 +01:00
SteVen Batten
e5b1616d77 Handle mnemonic escaping (#68196)
* handle mnemonic escapes

* Update src/vs/workbench/electron-browser/main.contribution.ts

* update custom menu and recent items list to support escaped mnemonics

* remove need for &&&

* qfix
2019-02-19 17:47:50 +01:00
Matt Bierner
a1ed35eaaf Fix clicking on webviews does not dismiss custom title bar menu
Fixes #68313

When clicking into a webview, the `relatedTarget` property of the corresponding blur event  fired is `undefined`. This fix makes it so that an empty `relatedTarget` also dismisses menus
2019-02-12 15:14:48 -08:00
Matt Bierner
539c6cc4e1 Marking more emitters as readonly 2019-02-06 15:07:20 -08:00
Matt Bierner
7a7ccce37a Working on strict null checking with Map.get may return undefined 2019-01-09 17:37:42 -08:00
SteVen Batten
ed61ef8249 fixes #64975 2018-12-14 14:42:37 -08:00
SteVen Batten
2025198e44 move modifier key listeners to capture phase
fixes #63084
2018-12-12 16:05:49 -08:00
SteVen Batten
cfc830c3e8 strict null checks for menu and menubar.ts (#64764)
ref #64754
2018-12-11 10:43:36 -08:00
SteVen Batten
fee735ed37 schedule update overflow action due to reflow (#64634)
* schedule update overflow action due to reflow
fixes #64514

* removed disposal
2018-12-07 13:56:55 -08:00
SteVen Batten
6dcd4366c2 initialize focus state
fixes #64500
2018-12-06 11:32:04 -08:00
SteVen Batten
95b5f88657 Fix/64292 (#64365)
* Revert "Revert "Make menubar its own widget and add overflow (#63954)""

This reverts commit fa87e67ebf.

* add checks for whencustom menubar is not present
2018-12-04 09:02:18 -08:00
Benjamin Pasero
fa87e67ebf Revert "Make menubar its own widget and add overflow (#63954)"
This reverts commit aedd4402fb.
2018-12-04 10:10:11 +01:00
SteVen Batten
aedd4402fb Make menubar its own widget and add overflow (#63954)
* working state

* fix keybindings and add compact submenu mode

* fix blur

* fix mnemonics in overflow menu

* fix issues with window resizing

* switch to ellipsis
2018-12-03 06:39:58 -08:00