Commit Graph

2241 Commits

Author SHA1 Message Date
Benjamin Pasero bea40cdd3d esm - more diff reduction (#225666) 2024-08-15 10:34:03 +02:00
Benjamin Pasero 02057b6ec7 "vscode:" URL handler doesn't switch to the file's workspace if it is open (fix #225506) (#225584) 2024-08-14 10:26:54 +02:00
Martin Aeschlimann 831d1f855d Unable to open empty remote workspace using vscode scheme URL (#224949)
* Unable to open empty remote workspace using vscode scheme URL

* don't remove `getRemoteAuthority`

* fix

* polish
2024-08-07 17:13:31 +02:00
Justin Chen 460572ac1f migrate to aux window service for issue reporter (#222315)
* use aux window service for issue reporter (#222313)

* add baseline, errors with styling

* attach window to instantiation

* some more thigns working

* some more decent work

* added title bar workings

* fix css and bordeR

* EVERYTHING FINALLY WORKING PLUS 10000 AURA

* fix import

* first pass cleanup

* more cleanup, css fixes

* better speciicity for issue reproting css

* fix test path

* fix styling for new vs. old issue

* upstream windows.ts for merge conflicts

* revert windows work for upsteram

* fix merge conflict attempt 2

* revert organize import

* clean up hygiene and tests

* remove import

* remove zoom, added type arch and release

* add host service and dialog service
2024-07-22 13:00:22 -07:00
Christof Marti 82104a3a6c Proxy Basic Auth 2024-07-05 00:08:03 +02:00
Benjamin Pasero abe5b7d16f debt - more direct fs use (#219261) 2024-07-01 09:18:40 +02:00
Benjamin Pasero f6f90e0163 Implement NLS without AMD loader (#214588) 2024-06-28 11:55:48 +02:00
Justin Chen 4bbebd8af9 splits up process explorer and issue reporter services (#216766)
* split up process explorer and issue reporter services

* more cleanup

* fix comment

* remove comments
2024-06-20 18:56:01 -07:00
Benjamin Pasero c2e20cb17f Silent warning when argv.json has syntax errors (fix #212671) (#215551) 2024-06-19 10:55:06 +09:00
Benjamin Pasero dee8eaf526 Make sure event subscriptions are stored and disposed (#214234) (#214312)
* Make sure event subscriptions are stored and disposed (#214234)

* fix tests
2024-06-05 14:11:06 +02:00
Logan Ramos cd93de1b0c Rename vsDeviceId (#213261) 2024-05-22 23:13:13 +02:00
Logan Ramos 4ebc77f80a Add VS device id (#213231) 2024-05-22 09:48:44 -07:00
Benjamin Pasero 6317965640 shared process - show notification toast on crash (fix #212103) (#212799) 2024-05-15 13:10:05 +02:00
Benjamin Pasero 18a5c4d21c debt - register disposable fs server (#211830) 2024-05-02 09:38:22 +02:00
Benjamin Pasero 4ee85ac51e Aux window - registration flawed when devtools is opened (fix #209073) (#209130) 2024-04-08 10:57:01 +02:00
Raymond Zhao 0da22a2260 fix: deprecate unity-launch flag (#209471) 2024-04-04 15:18:19 -07:00
Benjamin Pasero 1e38af3424 Opening recent from macOS dock creates a duplicate workspace (fix #208321) (#208372) 2024-03-22 08:42:50 +01:00
Raphael Palma c26343fec9 Fix grammatical error: 'But allow them if the are made from inside an…' (#207584)
Fix grammatical error: 'But allow them if the are made from inside an webview'
2024-03-13 17:12:25 +00:00
Benjamin Pasero 62b22bbe61 code --install-extension not working with roaming profiles (fix #205924) (#206834) 2024-03-04 12:59:51 -08:00
Benjamin Pasero 10a596e4d0 voice - suspend keyword recognition when focus lost (#205336)
* speech - bind stop keyword detection to window focus

* .

* .

* .
2024-02-16 10:02:00 +01:00
Benjamin Pasero 4a318a5df9 Aux window: validate window bounds are on display bounds (fix #204346) (#204399) 2024-02-05 20:53:46 +01:00
Benjamin Pasero c29a6e10b9 aux window - allow a per-window zoom level (#185836) 2023-12-30 01:41:14 +01:00
João Moreno 91a4378f47 allow CORS from PRSS CDN (#200554)
fixes microsoft/vscode-remote-release#9246
2023-12-12 12:49:40 +01:00
Johannes Rieken dff4173df4 Add WindowIdleValue and GlobalIdleValue, likewise runWhenGlobalIdle and runWhenWindowIdle. (#197721)
* Add WindowIdleValue and GlobalIdleValue, likewise runWhenGlobalIdle and runWhenWindowIdle.

Define window things inside dom.ts for more clarity and more correct layering.

Duplicate API definition for idle so that things compile standalone

fixes https://github.com/microsoft/vscode/issues/197661

* fix compile errors

* make treeshaker happy, use correct types
2023-11-08 15:20:40 +01:00
Benjamin Pasero 3453c4f9f0 aux window - avoid/flag more globals (#197614)
* aux window - avoid/flag more globals

* fix access from worker

* allow `queueMicrotask`

* more adoptions

* fix build

* avoid $globalThis
2023-11-07 12:52:20 +01:00
Benjamin Pasero 25ba16e724 vscode://file// links no longer working (fix #197319) (#197511) 2023-11-06 08:23:59 +01:00
Benjamin Pasero 42f5594892 aux window - some focus fixes (#197207)
* aux window - add some logging

* aux window - properly implement focus tracking
2023-11-02 09:36:20 +01:00
Benjamin Pasero 70d0c70e17 aux window - enable some menu actions when aux window has focus 2023-10-30 09:14:45 +01:00
Benjamin Pasero 860056cdc3 💄 protocol confirmation checkbox label (#196193) 2023-10-22 12:34:57 +02:00
Benjamin Pasero 45dda0e1da debt - remove old style voice transcriber (#195883) 2023-10-18 14:42:02 +02:00
Isidor Nikolic 9d32835bd7 add sqm id for windows (#195377)
* add sqm id for windows

* Update src/vs/platform/windows/electron-main/windowsMainService.ts

* Update src/vs/platform/sharedProcess/node/sharedProcess.ts

* react on review comments

* The reg entry is called MachineId not MachineGuid

* fix compile error

* no need for \\ prefix in reg path

* Wait for 1s max (as to not block the startup) to read the SQM value

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-10-12 13:47:40 -07:00
Benjamin Pasero df8c4d4537 Confirm for protocol links opt-out is not being honored (fix #195373) (#195437) 2023-10-12 08:59:22 +02:00
Benjamin Pasero 57b677dbe5 aux window - implement focusWindow via native host service 2023-10-11 11:29:10 +02:00
Benjamin Pasero 5b0739684d aux window - cleanup changes 2023-10-11 10:33:55 +02:00
Benjamin Pasero 0c52fb443b aux window - introduce main process service and use in some cases 2023-10-11 09:23:08 +02:00
Benjamin Pasero 91e59a296e aux window - better focus and reveal handling for editors (#194828)
* first cut focus handling

* 💄

* implement moveToTop

* cleanup
2023-10-05 09:51:10 +02:00
Benjamin Pasero 73cc570f58 Allow for multiple editor parts (#193425)
* demo

* wip

* polish

* allow to toggle

* compile

* enable devtools

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* Avoid using global document, global window

* Fix exception caused by reading the size of the newly created window before it is available

* cleanup

* make it more useful

* apply zoom

* first cut editor parts

* cleanup

* scaffold some services

* preserve view state

* simple label distinction

* introduce accessor

* support dnd

* fix open editors view

* share window options

* cleanup

* 💄

* 💄

* 💄

* 💄

* cleanup on unload

* add todo

* stylescleanup

* avoid instanceof checks

* share more styles

* revert changes partially

* fix custom menus

* more alignment to main window

* codicon does not seem to be needed anymore

* no need for isHTMLElement

* fix icon error on macOS

* prevent `document.createElement`

* close child window when main window closes

* better active groups tracking

* cleanup

* pass along editor parts viewer

* eslint rule for instanceof checks

* add dom tests

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

---------

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2023-10-03 12:20:06 +02:00
Benjamin Pasero 8f382227e0 Add confirm for protocol links but allow to opt-out (#194405)
* wip

* simplify

* 💄
2023-10-02 15:20:30 +01:00
João Moreno 45358184ef Introduce trustedExtensionProtocolHandlers (#194304)
* remove url

* use trustedExtensionProtocolHandlers
2023-09-27 15:35:55 +01:00
Benjamin Pasero c72447e8d8 Cannot read properties of null (reading 'b') (fix #193773) (#193774) 2023-09-22 09:48:12 +01:00
Benjamin Pasero a3c288eea5 debt - keep main services in electron-main (#193516) 2023-09-19 21:46:37 +02:00
Sandeep Somavarapu 3b60c12380 fix #192970 (#193128) 2023-09-15 03:55:43 +10:00
João Moreno 39de20e8a3 ensureNoDisposablesAreLeakedInTestSuite: ipc (#192570)
* ensureNoDisposablesAreLeakedInTestSuite: ipc

related to #190503

* debt - proxy services need to ask for disposables

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-09-11 21:01:46 +02:00
Tyler James Leonhardt 5134662139 Remove CredentialsService & keytar (#192224)
* Remove CredentialsService & keytar

ref https://github.com/microsoft/vscode/issues/115215
fixes https://github.com/microsoft/vscode/issues/143395

* compile

* remove imports

* rip the bandaid
2023-09-05 17:47:30 -07:00
Benjamin Pasero 14555a5123 app - ensure to remove windowId=_blank from protocol links (fix #191902) (#191990) 2023-09-01 16:40:42 +02:00
Benjamin Pasero 4f424db46e debt - ensure file scheme when using .fsPath (#191960) 2023-09-01 15:33:06 +02:00
Benjamin Pasero d8f9194040 voice - limit media permission to insiders 2023-08-25 07:23:07 +02:00
Benjamin Pasero bb61acf43c Merge branch 'main' into ben/voice 2023-08-10 08:53:24 +02:00
Matt Bierner 6e251255fb withNullAsUndefined(x) -> x ?? undefined (#189987)
Follow up on #189983

Replaces `withNullAsUndefined` with uses of `??`
2023-08-08 16:45:52 -07:00
Benjamin Pasero 707bffbdae voice - scaffold a basic voice recorder service 2023-08-08 17:08:44 +02:00