Commit Graph

50 Commits

Author SHA1 Message Date
Rachel Macfarlane
9623b3441d Add setting to control when comments panel opens (#64941) 2018-12-13 16:34:31 -08:00
rebornix
8d78edddaa render pending comment 2018-11-28 16:05:16 -08:00
rebornix
11d48f122e first cut 2018-11-27 16:02:39 -08:00
Rachel Macfarlane
af1b4ebded Refactoring comment service to not be keyed on handle 2018-11-08 14:13:43 -08:00
Ramya Achutha Rao
784750fb94 Remove trailing comma 2018-11-01 13:33:47 -07:00
Rachel Macfarlane
36dc10c9f7 Add log for registering workspace comment provider 2018-10-29 15:16:18 -07:00
rebornix
2c777c0fc4 comments contribution takes care of comment fetching itself 2018-10-24 14:40:19 -07:00
Matt Bierner
3cf3e16284 Explicitly type simple array
Add typings for the pattern: `let x = []` which defaults to `let x: any[] = []`

#60565
2018-10-17 16:39:23 -07:00
Benjamin Pasero
74f09acca9 editor - remove code that is handled by cancellation token (for #60163) 2018-10-17 08:25:20 +02:00
Benjamin Pasero
3b95170b06 remove console.log 2018-10-12 08:11:31 +02:00
rebornix
e05b33163c Re #261. Update comments only when visible editor changes. 2018-10-11 17:05:15 -07:00
Matt Bierner
8087b0a8d8 Remove use strict directives in main vs code ts files (part 2)
We compile using the alwaysStrict flag so these directives are not needed

This part removes most `use strict` directives that are right after the file header
2018-10-02 16:11:05 -07:00
Rachel Macfarlane
d1dbe4d53c Add support for deleting comments, #58078 2018-09-18 16:45:41 -07:00
Rachel Macfarlane
1d1105e96b Add support for editing comments, #58078 2018-09-17 11:22:41 -07:00
Johannes Rieken
2d452e0a7e uri - replace usages of default export with named export 2018-09-03 10:54:50 +02:00
rebornix
9f864bac0d Re microsoft/vscode-pull-request-github#70. Open the comments panel only for the first session. 2018-08-27 11:56:16 -07:00
Benjamin Pasero
56980850c5 use absolute imports 2018-06-15 16:28:51 +02:00
rebornix
7b31076554 fix build. 2018-06-13 16:10:18 -07:00
rebornix
f83a748a8e show comments in diff view sidebyside. 2018-06-13 15:48:25 -07:00
Rachel Macfarlane
915bbb2db3 Support multiple workspaceCommentsProvider contributions in comments panel, fixes #51622 2018-06-11 09:33:29 -07:00
Benjamin Pasero
dbc578db5d fix #51598 2018-06-11 18:32:40 +02:00
Benjamin Pasero
a3ba24d849 fix npe 2018-06-11 13:05:38 +02:00
rebornix
4c11f8ca7f handle diff editor for comments population. 2018-06-08 11:59:30 -07:00
Peng Lyu
f921e1910f re #38746. Implement dispose method 2018-06-05 12:50:05 -07:00
rebornix
d835b9c226 move comments service into comments part instead of registering it as a global service. 2018-06-04 15:24:36 -07:00
Benjamin Pasero
311e44fa4c adopt new grid APIs 2018-06-04 11:15:15 -07:00
Rachel Macfarlane
e9f5dc85a4 Unregister data providers from comment service 2018-05-23 11:33:46 -07:00
Rachel Macfarlane
f86589cd3f Workaround for comments panel not opening 2018-05-21 15:11:29 -07:00
Peng Lyu
5d6cca6013 update comments in editor when a data provider is registered. 2018-05-18 10:03:59 -07:00
Peng Lyu
41f1722166 use explict api instead of commands for commenting. 2018-05-16 19:14:24 -07:00
Peng Lyu
6889469054 reveal and expand comments 2018-04-23 11:31:05 -07:00
Peng Lyu
faa4bd1fff null check 2018-04-23 10:09:13 -07:00
Rachel Macfarlane
1920a28289 Separate WorkspaceCommentProvider and DocumentCommentProvider 2018-04-20 15:15:50 -07:00
Peng Lyu
5a3c4d1930 commentProvider can control collapse state of a thread 2018-04-20 15:04:00 -07:00
Peng Lyu
55198cb554 huge refactoring, remove getNewCommentRange 2018-04-19 11:49:45 -07:00
Peng Lyu
5c25f5001f rough incremental update. 2018-04-18 15:05:45 -07:00
Rachel Macfarlane
e1bb620efd Fix build 2018-04-17 17:11:35 -07:00
Peng Lyu
aed94aee0c comment service fetch 2018-04-17 17:07:29 -07:00
Rachel Macfarlane
801d3eaacf Add onDidCommentThreadsChange 2018-04-17 16:48:56 -07:00
Rachel Macfarlane
d15c0dce25 Display message when PR has no comments 2018-04-17 09:01:27 -07:00
Rachel Macfarlane
3a297dc5b4 Add provideAllComments method to comments provider 2018-04-16 17:47:17 -07:00
Peng Lyu
8107cbff1c move comment widget out of editor 2018-04-16 14:45:34 -07:00
Peng Lyu
64fb9e85f4 refactor 2018-04-16 14:21:15 -07:00
Peng Lyu
36672be949 add new comment. 2018-04-16 14:18:03 -07:00
Rachel Macfarlane
f3d38c3f41 Associate comments with files, open editor when selecting top-level node in comments panel 2018-04-12 12:08:24 -07:00
Peng Lyu
58a859e8c1 unregister comment provider when dispose, otherwise we see duplicates. 2018-04-11 19:05:55 -07:00
Rachel Macfarlane
159234d3fd Add comments panel 2018-04-11 17:58:00 -07:00
Matt Bierner
bd83b6da57 Removing webview widget api. Will go with more declarative approach 2018-04-10 15:32:55 -07:00
Peng Lyu
b3ef6d4ba2 Show comments in problem panel. 2018-04-05 15:39:22 -07:00
Matt Bierner
094a469d51 Working on adding comment api 2018-04-03 18:00:28 -07:00