Commit Graph

2284 Commits

Author SHA1 Message Date
Daniel Imms
ece3a90fb5 Tweak setLocaleVariables setting
- False now really means false
- The default is true for all platforms

Fixes #65037
2018-12-13 18:07:20 -08:00
Matt Bierner
986f924ad5 Prefer using Array<T> for complex array types
Use `Array<T | U>` when dealing with union types instead of  `(T | U)[]`
2018-12-13 16:40:44 -08:00
Matt Bierner
d40fa4a27e Review uses of Promise.resolve(null)
Many `Promise.resolve(null)` should actually be `Promise.resolve(void 0)`. In other cases, we were missing a null return annotation.
2018-12-13 15:41:13 -08:00
Matt Bierner
68a4e01246 Use resolve(void 0) instead of resolve(null) for void promises
Fixes a common type error
2018-12-13 15:20:46 -08:00
Daniel Imms
e6254db320 Recreate pid promise when reusing terminals 2018-12-13 10:02:17 -08:00
Daniel Imms
461bf7207b Merge remote-tracking branch 'origin/master' into pr/g-arjones/60111 2018-12-13 09:33:42 -08:00
Daniel Imms
e7102b1824 Send terminal name with id when it's ready
Fixes #64390
2018-12-13 08:07:55 -08:00
Dirk Baeumer
51f7beb40c Fixes #64918: Remove old task conversion code 2018-12-13 14:45:51 +01:00
Johannes Rieken
c6c7edaa9f debt - asThenable -> asPromise because it returns a promise 2018-12-13 11:45:48 +01:00
Johannes Rieken
653280d133 debt - Thenable -> Promise 2018-12-13 11:31:54 +01:00
Alex Dima
29dd4e77de Keep track of activating extensions 2018-12-13 11:22:26 +01:00
Matt Bierner
0b1d0da7af Prefer to use .then(void 0, ..) over .then(null, ..)
ES6 promises like using undefined as their first argument instead of null. Both should behave the same behavior
2018-12-11 21:59:32 -08:00
Johannes Rieken
48a452dcee towards strict null and completion model, #63454 2018-12-11 17:00:19 +01:00
Joao Moreno
408e03220c event namespace consolidation & docs 2018-12-11 10:14:38 +01:00
Matt Bierner
100adeb3e9 Use more generic word pattern for markdown
Try to better support handle of unicode in markdown by using a word definition that use unicode character class

Fixes #15177
2018-12-10 18:24:10 -08:00
Matt Bierner
0928a6d348 Prefer coalesce over filter
Coalesce has the correct return type of `T[]`. Filter may return `(T | undefined)[]`
2018-12-07 16:32:45 -08:00
Matt Bierner
e2cf8ebc5d Enable strictBindCallApply for VS Code
Fixes #64633
2018-12-07 14:25:14 -08:00
Rob Lourens
9be224980c Make LogLevel converters safer and consistent with other converters, from @jrieken feedback 2018-12-06 11:02:09 -08:00
Rob Lourens
514217add5 Fix #64273 - EH log levels start at 1 2018-12-05 13:29:38 -08:00
Rob Lourens
6f9b2d7593 Fix #59922 - changes needed to support a cache in a FileSearchProvider 2018-12-03 16:19:37 -08:00
Matt Bierner
64117e8fb5 Rename TriggerReason -> TriggerKind
Fixes #64216
2018-12-03 13:53:53 -08:00
Johannes Rieken
3bb5ce5d52 remove sample function proposed api 2018-12-03 18:14:43 +01:00
Johannes Rieken
daae50ab21 ensure a range contains its previous range, #63935 2018-12-03 12:05:50 +01:00
Johannes Rieken
2baa14fcf2 tests and api command for smart select api, #63935 2018-12-03 11:51:53 +01:00
Johannes Rieken
07be58bbad add proposed api for smart select, #63935 2018-12-03 11:29:12 +01:00
Johannes Rieken
253a4f6d17 log provider failure as errors, #63831 2018-12-03 08:47:39 +01:00
Alex Dima
aa3ea85b0a Explorations 2018-11-30 15:54:40 +01:00
Alex Ross
e16c62b315 Move rerun behavior api out of proposed (#63511)
Fixes #62789
2018-11-30 15:31:13 +01:00
Andre Weinand
f168d88224 final tracker API; for #62843 2018-11-30 15:17:40 +01:00
Johannes Rieken
5637f24b29 uri tweaks in md strings 2018-11-30 11:45:13 +01:00
Sandeep Somavarapu
34b655147e - Remove proposed api check for collpaseAll
- Add proposed api check for treeview message and globalStorage
2018-11-30 10:48:11 +01:00
rebornix
9eb6d908e3 remove unused method 2018-11-29 10:38:42 -08:00
rebornix
52811a3a48 Merge remote-tracking branch 'origin/master' into rebornix/commentsgrouping 2018-11-29 10:33:39 -08:00
rebornix
e877e5c820 comment thread can be updated by draft mode change. 2018-11-29 10:27:27 -08:00
rebornix
8d78edddaa render pending comment 2018-11-28 16:05:16 -08:00
Sandeep Somavarapu
37037eac8a #23251 Expose global storage path in proposed API 2018-11-28 16:33:59 +01:00
rebornix
11d48f122e first cut 2018-11-27 16:02:39 -08:00
Andre Weinand
4201f517b1 finalize DebugAdapterDescriptorFactory API: fixes #62977 2018-11-26 23:54:30 +01:00
Daniel Imms
daf4deaf0c Terminal process request improvements 2018-11-26 14:42:35 -08:00
Andre Weinand
8780c7b4f8 finalize DA & Tracker Debug APIs 2018-11-25 16:29:00 +01:00
Dirk Bäumer
63f9e09b78 Strict null checks for Task in extHostTypes 2018-11-23 12:48:41 +01:00
Andre Weinand
115ea4afe3 fix strict null error for debug 2018-11-21 00:09:02 +01:00
Alex Ross
6bb77146c4 Add a rerun last task command (#62645)
Fixes #25310
2018-11-20 09:40:54 +01:00
Andre Weinand
509f1233e4 Debug API: add registerDebugAdapterTracker 2018-11-20 00:49:42 +01:00
Andre Weinand
e40df5770d adopt DAP attribute "runInTerminal.shellProcessId"; fixes #63434 2018-11-19 16:02:25 +01:00
Sandeep Somavarapu
15ab767a1d #62795 Add proposed api to render description of a tree item 2018-11-19 14:29:19 +01:00
Johannes Rieken
58d5205e5a naming and doc tweak for #62839 2018-11-16 16:05:58 +01:00
Johannes Rieken
988f7683df Merge pull request #63150 from YisraelV/customNameForOutline
custom name when there are multiple outline providers - feature request #62839
2018-11-16 16:02:01 +01:00
Johannes Rieken
0ac0c45b29 strict null work in extHostTypes, #61543 2018-11-16 15:57:06 +01:00
Johannes Rieken
917a2c58ce Revert "strict null work in extHostTypes, #61543"
This reverts commit 714b18d16c.
2018-11-16 15:53:35 +01:00