Commit Graph
82 Commits
Author SHA1 Message Date
isidor c704881abb Validate dynamic configurations only on launch
fixes #110318
2020-11-16 16:33:41 +01:00
Benjamin Pasero b07d19a768 storage - remove store2 (#109967) 2020-11-13 08:42:59 +01:00
isidor d10b4cc81e polish when selecting config 2020-11-10 15:47:51 +01:00
isidor ad88db1031 fixes #110304 2020-11-10 12:21:35 +01:00
isidor 8335fcc3fc debug: do not auto pick dynamic launch configs 2020-11-06 17:22:31 +01:00
isidor 0cc93f5c48 debug: split ConfigurationManager into ConfigurationManager and AdapterManager 2020-11-06 14:34:54 +01:00
isidor 4b0855f292 Improve the dynamic launch config UI
fixes #110009
2020-11-06 13:21:48 +01:00
isidor 267817cf46 debug: adopt storageService.store2
#109967
2020-11-04 18:09:49 +01:00
isidor 46f60b7b27 debug: Do a late activation so extensions are not activated too early
fixes #108578
2020-10-26 15:10:29 +01:00
isidor 84fc56e347 debug: use uriIdentityService for uri comparison
fixes #107830
2020-10-23 16:33:26 +02:00
Andre Weinand 118db31ea6 Merge branch 'master' into launch-input-variables 2020-10-23 11:06:28 +02:00
isidor 3565fba49a fixes #96293 2020-10-01 13:44:55 +02:00
isidor e45ca3642c fixes #107728 2020-09-30 13:43:56 +02:00
isidor 292001621a do not use hasClass and first
#103454
2020-09-11 17:01:45 +02:00
Matt Bierner 5cdf679c44 Add explicit undefined parameters / types
These errors come from the new stricter types for Promises in TS 4.1
2020-09-09 10:57:05 -07:00
isidor b1a66b59b8 debug: dynamic launch configurations should be stored properly
fixes #96293
2020-09-08 11:54:05 +02:00
isidor 7f79730cb6 Revert "Run menu does not remember dynamic launch configurations"
This reverts commit d4248f3df5.
2020-08-31 20:27:33 +02:00
isidor d4248f3df5 Run menu does not remember dynamic launch configurations
fixes #96293
2020-08-31 16:45:39 +02:00
isidor 2a9a512ee4 debug: react on registration to update context keys 2020-08-28 14:54:31 +02:00
isidor da818d13fe debug: introduce debuggersAvailable context 2020-08-24 20:59:29 +02:00
isidor 02cd863122 debug: display launch name when showing dynamic configurations
fixes #103471
2020-08-21 11:21:48 +02:00
isidor aa094f11a8 fixes #104773 2020-08-18 11:49:35 +02:00
isidor f04ef75438 debug: register contributions only once debug adapter extension got registered 2020-08-12 18:47:34 +02:00
Connor Peet a1f0d54563 fixup! pr comments 2020-06-23 10:13:33 -07:00
Connor Peet 3a9d44e8c3 debug: allow a single debug extension to provide multiple configs
Previously if a debug extension provided multiple dynamic
configurations, we would just use the first debugger -- whatever that
was. This change now shows all configurations for which dynamic configs
are registered.

I also adjusted the picker to automatically select the first item if
there's only a single configuration provided. This works well for the
debug terminal, but also means that the user doesn't see the name of
the selected item, which might not be desirable. Open to pushback.

Together these finish the request for a separate top-level contribution
for the terminal in  #98054

Finally, with that adjustment I made a tweak so that the picker shows
up in a `busy` state while extensions are activating. Previously you
would select a dynamic configuration title and could have a few seconds
of delay before the picker came up, which is probably not desirable.
2020-06-22 15:01:43 -07:00
isidor 1d2432f094 debug: only store dynamic configs in memory 2020-06-17 12:48:48 +02:00
isidor 1fad9a4d94 debug: do not store configurations in storage
#100265
2020-06-16 11:00:47 +02:00
isidor 929b9f0ce8 fixes #100160 2020-06-15 15:59:47 +02:00
Andre Weinand e3df1e23cc fix naming 2020-06-11 22:59:16 +02:00
isidor dca516e9d1 fixes #99430 2020-06-08 11:32:12 +02:00
Borja Zarco 63ccc69f08 Fix launch configuration input variable resolution.
When resolving launch configuration variables during a debug session, the configuration target was not being specified, always defaulting to reading workspace folder inputs. This made it impossible for user or workspace file launch configurations to use input variables, as the inputs list was never found.

This change forwards the launch configuration source to the configurationResolverService, so that it looks for the inputs list in the right place.

Forwarding the source fixed single-root workspaces, but multi-root workspaces were skipping the inputs lookup, since they pass an undefined workspace folder... In this case, the workspace folder is not relevant, as the config and inputs are defined in the workspace file, and allowing resolution to continue yields the desired behavior.
2020-05-20 22:51:40 -04:00
isidor 37950f15cb debug: only show dynamic configurations that have a label 2020-05-14 14:48:00 +02:00
isidor f432c0e060 debug: rename to "edit debug configuration"
#95836
2020-05-14 10:43:34 +02:00
isidor 8f7eecc243 Show quickpick when selecting dynamic debug configuration container
fixes #96778
fixes #96293
2020-05-13 17:10:52 +02:00
isidor 1de3cce95e debug: update pin action to be called configure
fixes #95836
2020-05-13 12:29:57 +02:00
isidor 7edfb1d419 Add pinning support for dynamic launch configurations
#95836
2020-05-13 12:29:57 +02:00
jeanp413 972c55d9e4 Merge branch 'master' into fix-96567 2020-05-13 00:42:52 -05:00
jeanp413 c1bed7af3d Address feedback 2020-05-13 00:20:17 -05:00
isidor 13df275761 debug: remove support to open config file to the side
fixes #97470
2020-05-11 11:12:12 +02:00
jeanp413 35fe597487 Fixes #96567 2020-05-08 21:40:21 -05:00
isidor caa19dc534 debug: use .find not .filter .pop() 2020-05-05 15:35:47 +02:00
isidor e6bd1d1ae7 fixes #96905 2020-05-04 15:23:53 +02:00
isidor e79707e2d7 fixes #96297 2020-04-29 14:19:48 +02:00
Andre Weinand 8ec6ec7dc1 rename "Trigger" to "TriggerKind"; see #88230 2020-04-27 16:07:26 +02:00
Andre Weinand 78b071d803 proposed dynamic launch config API: rename 'scope' to 'trigger' 2020-04-26 19:00:47 +02:00
isidor c4e3627e4b Allow debug extensions to provide configurations to display in Select and Start Debugging
#88230
2020-04-21 16:51:37 +02:00
Andre Weinand 1451fab698 add dynamic debug config API 2020-04-20 13:26:20 +02:00
isidor 3ba047f634 fixes #93833 2020-04-01 18:59:20 +02:00
isidor 32d52f3f47 debug: report source of progress
#92253
2020-03-19 17:48:31 +01:00
isidor 42e26ac5bb Debug: make sure to open json settings when openning global configurations
fixes #92264
2020-03-10 10:53:53 +01:00