Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 19:18:59 +01:00
Code Issues Packages Projects Releases Wiki Activity
131,056 Commits 3,674 Branches 359 Tags
f1dc8d3d03274e230f0683f4e052d8a4afc98c71
Commit Graph

187 Commits

Author SHA1 Message Date
Johannes Rieken
c04ac5a5df add property-init-order-check and run during CI (just like valid layers check) (#243042) 
Enable ignore list which capture current violations and todo list
 2025-03-10 10:22:18 +01:00
João Moreno
c6863f35ba fix "skip tests" (#241100) 2025-02-18 16:52:29 +01:00
Ladislau Szomoru
a1c32cb7db Engineering - switch Compile stage to macOS ARM64 (#240676) 2025-02-14 18:09:27 +09:00
João Moreno
a46559966e move to new service connection, remove deprecated storage account upload (#233191) 2024-11-06 14:57:38 +01:00
João Moreno
1f8fd7adef use oidc (#233126) 
* use oidc

* undo dep bump

* use ClientAssertionCredential

* temporarily disable mangle

* adopt oidc
 2024-11-05 21:50:01 +01:00
Benjamin Pasero
332b89f198 esm - remove AMD build scripts, tests and variables 2024-09-27 08:04:01 +02:00
Robo
b5a6aa14a8 feat: switch to npm as default package manager (#226927) 
* feat: move from yarn to npm

* chore: skip yarn.lock files

* fix: playwright download

* chore: fix compile and hygiene

* chore: bump vsce@2.17.0

Refs 8b49e9dfdf

* test: update results for bat and sh colorizer tests

* fix: add missing lock files for windows

* fix: switch to legacy-peer-deps

* chore: update markdown-it@14.1.0

Refs 737c95a129

esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.

* ci: increase pr timeout for windows integration tests

* chore: fix product build

* build: ignore extension dev dependency for rcedit

* build: fix working directory inside container

* build: fix dependency generation

* npm: update dependencies

* ci: use global npmrc

* ci: update cache

* ci: setup global npmrc for private npm auth

* build: fix extension bundling

* chore: sync npm dependencies

* ci: debug env variables for container

* ci: fix win32 cli pipeline

* build: fix npmrc config usage for build/ and remote/ dirs

* fix: windows build

* fix: container builds

* fix: markdown-language-features tests and bundling

```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds userland package based on beed9aee2c

* fix: container builds for distro

* chore: update yarn occurrences

* fixup! chore: bump vsce@2.17.0

Uses the closest version to `main` branch that does not
include d3cc84cdec
while still having the fix 8b49e9dfdf

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: throw error when yarn is used for installation

* chore: add review feedback

* chore: switch exec => run where needed

* chore: npm sync dependencies

* fix: markdown-language-features bundling

```
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0

* ci: rename no-yarn-lock-changes.yml

* chore: sync npm dependencies

* ci: restore no-yarn-lock-changes.yml

We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.

* chore: sync npm dependencies

* ci: rebuild cache

* ci: fix no-package-lock-changes.yml

* chore: bump distro

* chore: rm yarn.lock files

* chore: rm yarn.lock files without dependencies

* chore: add vscode-selfhost-import-aid to postinstall dirs

* chore: bump distro
 2024-09-06 22:18:02 +09:00
Kevin Cui
d1eab2bcf4 ci: ensure retry logic consistency (#226038) 
Related PR: #171489

Signed-off-by: Kevin Cui <bh@bugs.cc>
 2024-09-04 04:51:19 +00:00
Ladislau Szomoru
310f0a3d85 Engineering - upgrade AzureKeyVault task (#227191) 2024-08-30 11:10:44 +02:00
Benjamin Pasero
6b924c5152 ESM merge to main (#227184) 
Co-authored-by: Johannes Rieken <jrieken@microsoft.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
 2024-08-30 10:31:46 +02:00
Benjamin Pasero
0dea4804f4 esm - introduce VSCODE_BUILD_ESM variable (#225586) 2024-08-14 14:49:26 +02:00
João Moreno
addd445017 upload sourcemaps to CDN instead of ticino (#214141) 2024-06-03 16:10:01 +02:00
Robo
5216c04428 chore: update to electron 29 (#209818) 
* chore: update electron@29.1.0

* chore: update typings to 20.x

* chore: bump electron@29.1.5

* ci: fix crash in compiling extensions-ci

* chore: disable .d.ts check for build/

$ ../node_modules/.bin/tsc -p tsconfig.build.json
node_modules/@types/chokidar/index.d.ts:21:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/@types/chokidar/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

21 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
                ~~~~~~~~~

node_modules/chokidar/types/index.d.ts:8:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/chokidar/types/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

8 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
               ~~~~~~~~~

Found 2 errors in 2 files.

Errors  Files
     1  node_modules/@types/chokidar/index.d.ts:21
     1  node_modules/chokidar/types/index.d.ts:8

Refs a0f9e09f64

* chore: update core types

* temp: fix layer validation

* chore: update nodejs checksums

* ci: use latest v20 LTS for missing node-gyp

Refs eacec5f490

* ci: define LIBCPP_HARDENING_MODE

* ci: fix crash in vscode-web-min-ci

* chore: update rpm deps-list

* chore: bump tree-sitter-typescript@0.20.5

* chore: bump electron@29.3.0

* chore: bump electron@29.3.1

* chore: update rpm deps-list for x86_64

* ci: disable io_uring UV backend on linux

* ci: disable io_uring backend for oss as well

* chore: update typings to 20.x

* ci: add TODO for io_uring workaround

* chore: bump distro

* chore: update preinstall node version checks

* chore: update @types/gulp

Refs https://github.com/microsoft/vscode/issues/212442

* ci: disable io_uring in more test suites
 2024-05-11 01:20:28 +09:00
João Moreno
e5515ac702 Adopt 1ES PT (#207844) 
* extend 1es pipeline template

* oops

* fix template references

* argh

* hmm

* hm

* hm

* use outputs for compilation artifact

* this

* use 1ES.PublishPipelineArtifact@1 instead of publish

* more 1ES.PublishPipelineArtifact@1 adoption

* provide windows pool for sdl sources

* sdl

* fix pools

* fix macos

* disable sbom for intermediate artifacts

* use mariner linux

* try inline tsa options

* fix credscan

* hm

* sudo it

* more suppressions

* be explicit with SBOM build drop paths

* fix indentation

* fix file extensions

* fix cli sbom build drop paths

* fix more build

* fix unzip cli

* careful with _manifest in artifacts

* do not close file

* add logging

* debug

* use snapcraft container

* remove size check

* fix macos cli step

* fix snap permissions

* fix macos

* better logs

* fix snap

* more cred scan suppressions

* even more supressiong

* alpine-arm64: try using x64

* Revert "alpine-arm64: try using x64"

This reverts commit bf2003bf60.

* test docker

* I wonder

* logs

* hm

* fix indentation

* hm

* hm

* fix snap finds

* remove auth

* use hostArchitecture

* snap: limit find

* hm

* sudo

* Add validateToolOutput: None to the build pipeline

* bring back sdl-scan

* try all tools: true

* use release

* Update Azure Pipelines YAML file for Linux product build and test

* hm

* hm

* same for win32

* hm

* hm

* Revert "hm"

This reverts commit 1b9dcae85b.

* use branch

* fix template file

* fix template paths
 2024-03-21 14:16:32 +01:00
João Moreno
417e17038c Use NodeJS mirror for more reliable downloads (#196038) 
get node from mirror
 2023-10-20 09:53:57 +02:00
Raymond Zhao
18a25cd5d6 Clarify pipeline actions (#195197) 2023-10-11 09:05:00 -07:00
Rob Lourens
7d4027b62b Test using nvmrc in CI (#194836) 
* Test using nvmrc in CI

* Force run yarn

* fix

* Bump nvmrc to latest

* Revert "Force run yarn"

This reverts commit af741f37d5.

* Make all jobs use node from nvmrc
And install node-gyp where needed
 2023-10-04 19:08:50 -07:00
Rob Lourens
c9740ad40f Try with node 18.17 (#194663) 
* Try with node 18.17

* And change product compile

* Use 18.15, same as the local version
 2023-10-02 15:04:23 -07:00
Robo
1f40d64450 fix: deb and rpm dependency after keytar removal (#192275) 
* fix: deb and rpm dependency after keytar removal

* chore: rm libsecret-1-dev from CI

* ci: update cache
 2023-09-06 05:24:39 -07:00
Robo
ea490e5545 chore: update to Electron 25 (#188268) 
* chore: update electron@25.3.0

* ci: update NodeTool version

* chore: update @types/node

* add more common types to layers checker

* chore: update debian dependencies

* chore: update rpm dependencies

* fix: use legacy dns result order of Node.js

* ci: remove deprecated always-auth npm config

Refs npm/cli@72a7eeb

* chore: update deb and rpm dependencies

* chore: update armhf rpm dependencies

* chore: update x64 debian dependencies

* chore: update x64 rpm dependencies

* chore: update electron@25.3.1

* chore: update electron@25.4.0

* chore: bump distro

* chore: bump distro

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
 2023-08-07 21:46:27 +09:00
Christof Marti
6ae441b56f Kerberos auth for proxies (#188130) 2023-07-19 20:11:00 +02:00
Ladislau Szomoru
cad3a1c656 Engineering - skip property mangling in PR builds (#184584) 2023-06-08 12:42:40 +02:00
João Moreno
14ea89e7ca build: quieter node module cache logging (#180709) 2023-04-25 08:26:56 +02:00
João Moreno
19f5801470 fix CI by always installing prebuilt extensions (#179247) 
fix CI by installing prebuilt extensions
 2023-04-05 14:24:51 +02:00
João Moreno
aac80c3f0a Adopt new distro format (#178689) 
* Simplify distro

Also a ton of drive-by fixing around builds:
- simplified many oneliners
- fixed missing custom npm registry call setups
- remove unnecessary and duplicate work during builds
- many many fixes
 2023-04-02 09:35:39 +02:00
SteVen Batten
174600ec07 fix build (#174596) 2023-02-16 17:56:20 +01:00
SteVen Batten
a28dc84d88 warn on CG alerts (#174591) 2023-02-16 17:30:16 +01:00
João Moreno
e8fa61d2fc retry terrapin 5 times (#171489) 
fixes #170935
 2023-01-17 13:48:02 +01:00
Alexandru Dima
ba91a81c16 Always patch the npm registry in yarn.lock files and compute the node modules cache key after having patched them (#164795) 2022-10-27 12:31:15 +02:00
João Moreno
8fe6f3e917 Allow custom npm registries at build time (#163629) 
* use azure artifacts as new terrapin solution

* debug

* skip npm auth

* bring back

* also configure yarn

* custom npm registry

* oops

* powershell

* use none instead of empty string

* uff
 2022-10-24 09:24:44 +02:00
João Moreno
ac9aff3521 reenable terrapin (#163622) 
* drop npx for terrapin

* enable terrapin by default
 2022-10-14 01:35:15 -07:00
Connor Peet
665eb030a6 Merge remote-tracking branch 'origin/main' into build-integrated-cli 2022-09-23 13:33:35 -07:00
Alexandru Dima
869fd7bbfb Only do the /build/ folder check on OSS, where we don't mixin (#161381) 2022-09-21 01:59:57 -07:00
Alexandru Dima
7041b71cd6 Retire basic checks GH action (#161376) 
* Add /build/ folder checks (just like GH action)

* Add more checks that were only present in the GH action

* Disable basic checks GH action
 2022-09-21 00:58:06 -07:00
Connor Peet
e02895941d build: include the integrated CLI in product builds 2022-09-19 23:16:19 -07:00
Connor Peet
fbda011715 build: do proper hashing for built-in dependencies (#157295) 
Fixes #157244
 2022-08-05 13:00:33 -07:00
Connor Peet
c9df538b06 build: apply built-in ext cache to the rest of the pipeline (#156939) 2022-08-02 16:26:17 -07:00
Connor Peet
ca48c64699 build: cache built-in extensions to avoid rate limiting (#156918) 2022-08-03 00:27:16 +02:00
Ladislau Szomoru
34f1bc679d Engineering - update Code OSS pipeline (#155610) 2022-07-19 13:40:33 +00:00
Ladislau Szomoru
2a9f19d36f Engineering - create pull request pipeline (#149171) 2022-05-11 03:08:54 -07:00
Connor Peet
5e86e40fab extensions: pull from github in OSS build (#146863) 
* extensions: pull from github in OSS build

* fixup! address pr comment
 2022-04-10 22:36:12 -07:00
João Moreno
c5902c4e2b hm 2022-03-21 14:46:14 +01:00
João Moreno
726eeffa71 introduce distro private builds 2022-03-21 14:40:00 +01:00
Joao Moreno
29ef778b1c fixes #145397 2022-03-18 13:54:12 +01:00
Robo
32d40cf44e chore: update to electron 17 (#143223) 
* chore: bump electron@17.0.0

* Revert "chore: revert to electron@13 (#143851)"

This reverts commit df645f1450.

* chore: bump electron@17.1.0

* Revert "ci: fix build with latest node-gyp"

This reverts commit c3e948aa30.

* chore: revert ci changes for node v16

* chore: update yarn.lock

* chore: bump electron@17.1.1
 2022-03-11 00:51:37 +09:00
Robo
df645f1450 chore: revert to electron@13 (#143851) 
* Revert "chore: update to electron 16 (#137241)"

This reverts commit 01df559c18.
This reverts commit 46301339b7

* ci: fix remote compiler for sdl-scan

* chore: fix remote/.yarnrc

* chore: fix build/npm/postinstall.js

* chore: rm crash reporter from shared process

* chore: rm crash reporter from ext host

* chore: fix build/lib/layersChecker.ts

* :chore: preserve some more changes

* fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
 2022-02-24 17:49:49 +01:00
Robo
01df559c18 chore: update to electron 16 (#137241) 
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488dd8f.

* Revert "watcher - enable crash reports on linux (#136264)"

This reverts commit af261488f8.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix #137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs https://github.com/microsoft/vscode/issues/137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs 797723ec83

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs https://github.com/microsoft/vscode/issues/137659

* ci: switch to buster for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs #137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf37c.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73951.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3732.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
 2022-02-08 20:09:00 +01:00
Joao Moreno
4ecbef411b fixes #141067 2022-01-24 12:10:28 +01:00
João Moreno
37f68b4803 Revert "builds: disable caching" 
This reverts commit 2ec3bfc440.
 2021-11-24 13:04:43 +01:00
João Moreno
6f2ad1994c More RBAC usage (#137579) 
* ci: 👷 remove secret references

* inline web storage account

* remove unused reference

* inline storage accounts

* formatting

* formatting

* drop ticino-storage-key, web-storage-key

* remove leftovers

* fix build

* fix build

* catch errors on all upload* scripts

* bump gulp-azure-storage
 2021-11-20 09:01:39 -08:00