Commit Graph

75 Commits

Author SHA1 Message Date
Johannes Rieken
f2d6da27d0 make sure appendOutputItems and replaceOutputItems return something 2021-06-02 08:44:01 +02:00
Rob Lourens
ef28d1663d Inline parameters to execution task start and end 2021-06-01 16:13:27 -07:00
Johannes Rieken
2031df2653 rename hasExecutionOrder to supportsExecutionOrder 2021-05-31 16:09:05 +02:00
Johannes Rieken
f2fb2b8cbe rename viewType to notebookType, https://github.com/microsoft/vscode/issues/122922 2021-05-31 15:55:15 +02:00
Johannes Rieken
355df0eccb move renderer script and IPC into proposed and merge with general renderer IPC, https://github.com/microsoft/vscode/issues/123601 2021-05-31 13:38:17 +02:00
Johannes Rieken
4202ab071a rename NotebookCellOutput#outputs to #items 2021-05-28 17:57:50 +02:00
Johannes Rieken
04e09dacdf refine output modifications of NotebookCellExecution 2021-05-28 11:15:56 +02:00
rebornix
5338cc32da fix build. 2021-05-27 11:17:01 -07:00
Johannes Rieken
4c5a061df6 rename NotebookKernelPreload to NotebookRendererScript 2021-05-27 15:21:48 +02:00
Johannes Rieken
da1193950a some jsdoc for NotebookCellExecution 2021-05-27 12:59:47 +02:00
Johannes Rieken
9d907212ba rename NotebookCellExecutionTask to NotebookCellExecution 2021-05-27 12:14:20 +02:00
Johannes Rieken
d63a69abf3 some enforcement of unique mime types in the extension host, https://github.com/microsoft/vscode/issues/124357 2021-05-26 12:18:46 +02:00
Matt Bierner
9847783f62 Remove uuid from webview resource uris
This is no longer be needed. We still serve the webview code itself from a unique subdomain

This also removes the need for `serviceWorkerFetchIgnoreSubdomain`
2021-05-21 09:28:43 -07:00
Matt Bierner
07a2aab8f2 Remove duplication around checking isRemote 2021-05-20 16:00:40 -07:00
Matt Bierner
18ea5ac15e Use isRemote instead of remote authority to determine where to load from 2021-05-20 11:30:43 -07:00
Matt Bierner
2270c36cff Use extension location instead of remote for asWebviewUri 2021-05-20 10:32:47 -07:00
Matt Bierner
1ddc623e58 Simplify logic for webview resource uris (#123740)
* Simplify logic for webview resource uris

This change attempts to simplify the logic around webview resource uris by doing the following:

- Hard code the resource origin. We always will be hitting a service worker for these paths so they don't need to be dynamic (although in the future we may want to pull them from `product.json`)

    This lets us remove these properties from the environment service

- Move remote handling from the resource loader in `asWebviewUri`.

- Remove the handling of http and https paths from the resource loader.

    I don't think these cases can be hit any longer (although I need to confirm this with more testing for the web case). Instead I added a check to `asWebviewUri` so that we return the original uri if a http(s) uri is passed in

* Restore normalizeResourcePath

We still need to convert between a remote uri and one that our remote file system can read

* Fix test

* Restore passing in remote on extension side

* Remove only
2021-05-19 17:26:51 -07:00
Rob Lourens
5b13f40b47 Remove NotebookCellExecutionState.Idle 2021-05-13 11:34:02 -07:00
Rob Lourens
dfb8c467ca Separate extension metadata from execution metadata
Fix #123235
2021-05-12 17:26:00 -07:00
Johannes Rieken
2f2ca2ea19 more trace logging, https://github.com/microsoft/vscode/issues/123700 2021-05-12 20:02:53 +02:00
Johannes Rieken
c6beaef489 added logging for https://github.com/microsoft/vscode/issues/123700 2021-05-12 19:46:11 +02:00
Johannes Rieken
2f282bbefb Log which extension creates what controller when, https://github.com/microsoft/vscode/issues/122409#issuecomment-833448914 2021-05-12 19:28:19 +02:00
Matt Bierner
b847eb35e7 Add remote-authority to webview uri 2021-05-11 18:14:13 -07:00
Matt Bierner
4177014a1c Revert "Put authority into webview resource uri"
This reverts commit 3d978d4dde.
2021-05-10 23:01:26 -07:00
Matt Bierner
3d978d4dde Put authority into webview resource uri
This lets us handle the case where a webview needs to load both local and remote resources
2021-05-10 20:40:07 -07:00
Johannes Rieken
f7f1dbd5be 💄 2021-05-07 15:08:40 +02:00
Johannes Rieken
fa378cd02a move NotebookCellExecutionTask into extHostNotebookKernels, fyi @roblourens 2021-05-07 14:27:07 +02:00
Johannes Rieken
f9b5f8f624 💄 2021-05-07 14:16:00 +02:00
Johannes Rieken
b177753668 check that a cell is still "alive" and only iff so start executing it, fixes https://github.com/microsoft/vscode/issues/123269 2021-05-07 14:14:14 +02:00
Johannes Rieken
2fe990d12d throw error when creating an execution task for a notebook that the controller isn't associated to, https://github.com/microsoft/vscode/issues/122877 2021-05-05 08:41:16 +02:00
Connor Peet
d639345791 notebooks: improve renderer message passing
Fixes https://github.com/microsoft/vscode/issues/122944
2021-05-04 12:35:06 -07:00
Johannes Rieken
42754baf3a relax uniqueness requirement for controller ids, must only be unique per extension, not globally, https://github.com/microsoft/vscode/issues/121902 2021-04-26 14:38:04 +02:00
Johannes Rieken
f68a7e7778 add NotebookDocument to executeHandler 2021-04-22 17:34:51 +02:00
Johannes Rieken
97344537a5 Use affinity over priority 2021-04-22 16:43:36 +02:00
Johannes Rieken
5390ec0e7c remove isPreferred as instance property, replace selector with only viewType, allow controller to set a notebook priority instead 2021-04-22 16:13:42 +02:00
Johannes Rieken
dab0e063bc mark supportedLanguages as optional, some todos 2021-04-22 14:50:53 +02:00
Johannes Rieken
12741ed7d8 add notebook instance to interrupt handler, https://github.com/microsoft/vscode/issues/121912 2021-04-22 14:17:04 +02:00
Johannes Rieken
2e0214b364 rename ExecutionHandler to ExecuteHandler 2021-04-22 08:03:31 +02:00
Johannes Rieken
e2c9703995 prefix api object with api-prefix, like apiCell 2021-04-21 15:34:44 +02:00
Johannes Rieken
4f9ac638ff extension contributed kernels fall back to all languages when supportedLanguages isn't set, https://github.com/microsoft/vscode/issues/121329 2021-04-21 11:34:48 +02:00
Johannes Rieken
b2b45e1005 execute by cell-handle, kernel manager has only execute/cancel cells, also "fix" isNotebookCellData fyi @rebornix 2021-04-20 14:39:19 +02:00
Johannes Rieken
fe7951dd7a remove kernel provider from core, adopt kernel service, merge kernel2 and kernel interface, extract context keys from kernel manager, make context key manager only for execution/cancellation 2021-04-20 11:30:31 +02:00
Johannes Rieken
11c3ba58af remove NotebookKernelProvider API and its implementation 2021-04-19 16:19:23 +02:00
Johannes Rieken
f9fec24b45 make INotebookKernel2 extends INotebookKernel 2021-04-19 11:56:18 +02:00
Johannes Rieken
6b9bd78998 add NotebookController#detail 2021-04-19 08:58:01 +02:00
Johannes Rieken
93dbc7ac44 remove NotebookControllerOptions and simplify createNotebookController-signature 2021-04-16 15:23:34 +02:00
Johannes Rieken
95932045c7 check that notebook controller are unique per id 2021-04-16 14:22:44 +02:00
Johannes Rieken
98f69856ea extract types for execute/interrupt handler, interrupt in not per document but per controller 2021-04-16 11:45:04 +02:00
Johannes Rieken
c074bf897c make preload a creation argument, no editor needed when calling asWebviewUri 2021-04-16 11:29:28 +02:00
Johannes Rieken
8877d8ca94 hook up execution task cancellation from controllers 2021-04-16 10:51:45 +02:00