Daniel Imms
f329ef3753
Merge dimensions into awaiting object
2019-11-17 12:54:38 -08:00
Daniel Imms
6d7f763548
Only set _extensionTerminalAwaitingStart when deferred start is needed
2019-11-17 12:52:17 -08:00
Daniel Imms
1004d51605
Merge branch 'master' into pty_bug
2019-11-17 12:35:57 -08:00
Konstantin Solomatov
b07e52a4ed
200 -> 2 * EXT_HOST_CREATION_DELAY * 2
...
remove dead code
2019-11-09 20:29:27 -08:00
Konstantin Solomatov
b145048e2c
Remove pointless code
2019-11-09 20:15:40 -08:00
Konstantin Solomatov
794ed4ff1c
Fixed test
2019-11-08 11:55:23 -08:00
Konstantin Solomatov
ed52435fe5
Fixing tests
2019-11-08 11:29:09 -08:00
Konstantin Solomatov
bde2d42430
Code review comments
2019-11-08 10:12:41 -08:00
Konstantin Solomatov
c60c6c1c57
Fix bug with hanged pseudoterminal
2019-11-07 17:41:31 -08:00
Daniel Imms
e41c71b0d0
Merge branch 'master' into tyriar/63052
2019-11-05 10:32:42 -08:00
Daniel Imms
1d60909d1f
Implement Terminal.creationOptions API
...
Fixes #63052
2019-11-05 10:30:43 -08:00
Daniel Imms
7215e5e9f5
Pass through undefined exit codes
2019-11-05 09:17:57 -08:00
Daniel Imms
2a0d3d0140
Support Terminal.exitStatus API
...
Fixes #62103
2019-11-05 09:09:39 -08:00
Daniel Imms
82c348326c
Merge remote-tracking branch 'origin/master' into tyriar/integration_test
2019-10-31 11:28:31 -07:00
Daniel Imms
3f3527dedb
Null check terminal processes before calling on them in ext host
...
Fixes #81821
2019-10-31 09:12:32 -07:00
Benjamin Pasero
33cc09da7a
Revert "Removing EXT_HOST_CREATION_DELAY hacks" ( #83422 )
...
This reverts commit 2b61a8817b
2019-10-28 12:08:07 +01:00
Daniel Imms
2b61a8817b
Removing EXT_HOST_CREATION_DELAY hacks
...
This one was a bit tricky to figure out what was going on, but this is how it
was working before: Terminals that use extension processes calls
$createTerminal from the ext host, this returns a promise with an ID that gets
returned asynchronously after the process has been setup (ie. an ext host process
proxy was created).
The reason we needed the timeout was because the process initialization is async
as we need a layout to occur so that we have the dimensions of the terminal to
give to the process. The fix could have been setTimeout(..., 0) as well but that
feels hacky as well, the fix in this commit is to pipe an event through from
the process manager which is the actual time when we are good to start telling
ext hosts are the new terminals.
Fixes #77655
2019-10-25 12:57:30 -07:00
Eric Amodio
1ab47af535
Fixes #48513 - updated from review comments
2019-10-23 18:28:16 -04:00
Eric Amodio
e887486e4d
Fixes #48513 - buffers terminal onData events
2019-10-23 18:28:16 -04:00
Daniel Imms
a30e88aca1
Revert "Fix strictFunctionTypes errors in terminal proxy"
...
This reverts commit 7f5a4a3f5b
2019-10-13 10:55:54 -07:00
Daniel Imms
7f5a4a3f5b
Fix strictFunctionTypes errors in terminal proxy
...
Part of #81574
2019-10-04 17:39:05 -07:00
Daniel Imms
678abfe8b2
Remove Terminal.onDidWriteData
...
Replaced by vscode.window.onDidWriteTerminalData
Fixes #78574
2019-09-12 19:09:12 -07:00
Daniel Imms
63a0da438b
Have ExtHostTerminalService extend Base service
2019-09-11 09:54:27 -07:00
Daniel Imms
b5a3125123
Move most of ExtHostTerminalService to common
2019-09-11 09:35:51 -07:00
Johannes Rieken
dedf0de944
change type of _serviceBrand from any to undefined, #79918
2019-08-30 15:40:46 +02:00
Daniel Imms
37e0b8e229
Add terminal.integrated.automationShell
...
Fixes #78497
2019-08-09 09:40:38 -07:00
Johannes Rieken
2cf97fc2e5
add service brand to terminal service
2019-08-07 16:19:25 +02:00
Johannes Rieken
ebd96071d1
make extHost-things services, setup injector
2019-08-07 16:11:00 +02:00
