Commit Graph

222 Commits

Author SHA1 Message Date
Matt Bierner
f3d70dbf92 Working on sharing models for same custom editor 2019-11-25 15:44:25 -08:00
Matt Bierner
ffe3749d5a Working on hooking up custom editor saveAs 2019-11-25 15:44:25 -08:00
Matt Bierner
9b89cca38e Working on hooking up revert properly for custom editors 2019-11-22 15:18:01 -08:00
Matt Bierner
4cc8710a38 Add CodeAction.disabled
For #85160
2019-11-20 17:10:00 -08:00
Johannes Rieken
eff2320473 check timeout on extension host, blame extension when exceeded, #43768 2019-11-19 12:36:42 +01:00
Johannes Rieken
094fd80e20 adding configurable timeout, #43768 2019-11-19 11:37:36 +01:00
Matt Bierner
8bbe3157f0 Trying to hook up basic save for custom editors 2019-11-18 11:27:45 -08:00
Christof Marti
8031c495a6 Add option to skip sorting QuickPick items (#73904) 2019-11-18 17:09:31 +01:00
Peter Elmers
e9c0aeb8b0 Add optional sortByLabel to QuickPick to control whether to re-sort items when query changes
Summary:
Address issue #73904 by adding an optional `sortByLabel` to the QuickPick class which determines whether the picker re-sorts the result list when the user types in the input field.

If true, the picker applies a sort to order results by the index of the first appearance of the input in the label.

For backwards compatibility, this field is true by default.

https://github.com/microsoft/vscode/issues/73904

Test Plan:
attached video shows behavior both before and after

{F167292605}

note: there aren't any existing tests on what happens when the query input changes in the QuickPick

Reviewers: dalongi, ericblue, hchau

Reviewed By: ericblue

Differential Revision: https://phabricator.intern.facebook.com/D16203434

Signature: 16203434:1562878837:5413e3852f2bd04c8e81b9fe5c4a08127dfe3b65
2019-11-18 17:09:29 +01:00
Alexandru Dima
41be9a6142 Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-18 08:59:14 +01:00
Benjamin Pasero
9727eb6050 untitled - fix save with associated file path 2019-11-18 07:57:48 +01:00
Matt Bierner
27a33ee6fe Hook up very basic undo/redo for webview editors
For #77131
2019-11-15 18:21:46 -08:00
Benjamin Pasero
72c2f506de working copy - introduce first save/revert semantics (#84672) 2019-11-15 15:36:55 +01:00
Johannes Rieken
e80c62bdcb allow $openUri to accept URI and string 2019-11-15 10:53:04 +01:00
Johannes Rieken
e51ef85bcb Revert "allow $openUri to accept a URI and string, adopt consumer but keep the API as is"
This reverts commit 544b0abf5b.
2019-11-15 10:29:29 +01:00
Johannes Rieken
544b0abf5b allow $openUri to accept a URI and string, adopt consumer but keep the API as is 2019-11-15 10:28:03 +01:00
Alex Dima
15beb36ccf Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-14 09:16:10 +01:00
Matt Bierner
278b4f8cfa Hookup experimental undo for customEditors
This currently is not connected to any actual actions in the editor
2019-11-07 17:22:21 -08:00
Matt Bierner
bca7206f59 Forward onEdit from webviewEditor to mainthread 2019-11-07 15:57:47 -08:00
Alexandru Dima
c34e736195 Forward SemanticColoring disposals to the ext host 2019-11-07 16:06:46 +01:00
Johannes Rieken
e5719685cc implement api commands for call hierarchy, #83274 2019-11-07 14:05:50 +01:00
Alex Dima
57995de234 Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-06 08:51:39 +01:00
Daniel Imms
e41c71b0d0 Merge branch 'master' into tyriar/63052 2019-11-05 10:32:42 -08:00
Daniel Imms
1d60909d1f Implement Terminal.creationOptions API
Fixes #63052
2019-11-05 10:30:43 -08:00
Daniel Imms
7215e5e9f5 Pass through undefined exit codes 2019-11-05 09:17:57 -08:00
Daniel Imms
2a0d3d0140 Support Terminal.exitStatus API
Fixes #62103
2019-11-05 09:09:39 -08:00
Alexandru Dima
308ff31f95 Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-05 09:44:55 +01:00
Matt Bierner
dcecb9eea6 Documenting thoughts on direction for custom editor API
This documents the current thinking on the custom editor api. The current api proposal is not actually implemented yet
2019-11-04 15:11:54 -08:00
Johannes Rieken
31160103a3 migrate proposed API onto new events 2019-11-01 12:05:32 +01:00
Benjamin Pasero
b7b21844e7 api - fold app uri creation into asExternalUri (fix #82884) 2019-10-29 07:18:19 +01:00
Jackson Kearl
69fd68da9f Preserve comment thread collapse state across extension host update messages, fixes https://github.com/microsoft/vscode-pull-request-github/issues/1400 2019-10-24 12:00:53 -07:00
Johannes Rieken
15bcf1a8c5 call hierarchy shows root node, also update API proposal for this, #81753 2019-10-24 20:20:27 +02:00
Johannes Rieken
5d6a46cfb5 Merge branch 'master' into joh/completionOverwrite 2019-10-23 17:21:33 +02:00
Daniel Imms
5db496f7cf Fix strictFunctionTypes in terminal proc
Part of #81574
2019-10-22 09:30:00 -07:00
Johannes Rieken
9f474febfe implement API proposal 2019-10-22 16:48:12 +02:00
Matt Bierner
d6ab43118d Create WebviewExtensionDescription in extHostProtocol 2019-10-17 10:50:34 -07:00
Matt Bierner
721886ce10 Allow registerWebviewEditorProvider to pass in a set of initial webview options
Fixes #82128
2019-10-17 10:50:34 -07:00
Matt Bierner
48195455a1 Remove the setExtension helper
Instead pass over the extension when resolving the extension itself
2019-10-15 11:31:24 -07:00
Joao Moreno
d9e93a7067 Merge branch 'joao/fix-82264' 2019-10-15 13:03:24 +02:00
Daniel Imms
a30e88aca1 Revert "Fix strictFunctionTypes errors in terminal proxy"
This reverts commit 7f5a4a3f5b.
2019-10-13 10:55:54 -07:00
Joao Moreno
4a81920398 Revert "scm: make tree rendering opt-in via proposed API"
This reverts commit afa911d942.
2019-10-11 19:10:27 +02:00
Joao Moreno
afa911d942 scm: make tree rendering opt-in via proposed API
fix #82203
2019-10-10 18:37:38 +02:00
Johannes Rieken
50c2639b86 Merge branch 'joh/strict' 2019-10-07 08:30:19 +02:00
Daniel Imms
7f5a4a3f5b Fix strictFunctionTypes errors in terminal proxy
Part of #81574
2019-10-04 17:39:05 -07:00
Johannes Rieken
c06c223ee9 more strict init work 2019-10-04 11:52:05 +02:00
Matt Bierner
8079ff0001 Rename resolveExternalUri to asExternalUri
#81131
2019-09-30 14:22:47 -07:00
Johannes Rieken
111c29c085 Merge pull request #80895 from mjbvz/use-const-enums-for-suggest-dto
Use const enums for minimized ISuggestDataDto field names
2019-09-30 15:34:48 +02:00
Alexandru Dima
45a92a4937 wip 2019-09-30 15:19:07 +02:00
Matt Bierner
e0762af258 Move webview content state into webviewPanel instead of webviewEditor
Split out from #77131

The current webview editor api is very procedural. This model has some problems when it comes to supporting editing resources, but actually does make a lot of sense for webviews that aren't backed by real file system resources. For example, if you have a webview that edits some document in the cloud, you should not be required to implement a custom file system provider just to enable basic saving.

This change moves the `onWillSave` and `webviewEditorState` properties back onto `WebviewPanel` instead of keeping them specific to `WebviewEditor`. The save implementation does not fully work yet, as the will require #81521
2019-09-26 18:05:37 -07:00
Benjamin Pasero
64eed745f5 💄 move a few services around 2019-09-26 18:37:58 +02:00