Commit Graph

4667 Commits

Author SHA1 Message Date
Alex Ross
1e0f19dd3f Actions for simple file picker 2019-03-26 09:55:08 +01:00
Benjamin Pasero
d0211faa28 fix #71118 2019-03-26 08:38:37 +01:00
Rachel Macfarlane
03bdc72755 Update get system status command to get diagnostics 2019-03-25 16:12:40 -07:00
Alex Dima
3ba93e8aac Move more code to /common/ 2019-03-25 19:05:36 +01:00
Martin Aeschlimann
ee2f23192c open new window with reuse 2019-03-25 17:52:42 +01:00
Martin Aeschlimann
0f45c39d97 status from ext host cli 2019-03-25 17:52:42 +01:00
Alex Ross
9eb5669101 File picker undo should work (#70302)
Use execCommand to ensurse that file picker auto complete is added to undo buffer
2019-03-25 17:41:37 +01:00
Alex Dima
8292829248 Explorations 2019-03-25 15:34:08 +01:00
Sandeep Somavarapu
c98431ec76 #59478 Use file service to read user configuration 2019-03-25 14:23:18 +01:00
Alex Dima
2f38e3e72a Minor tweaks 2019-03-25 12:56:33 +01:00
Alex Dima
bef602e832 Extract /common/ code 2019-03-25 11:13:20 +01:00
Benjamin Pasero
2c386fa9a3 Revert "Revert "debugToolbar -> debugToolBar""
This reverts commit 9bb443d153.
2019-03-25 10:55:00 +01:00
SteVen Batten
afafc16dc4 fixes #69597 (#69628)
* fixes #69597

* adopt focusWindow everywhere
2019-03-25 10:53:49 +01:00
Benjamin Pasero
f35466ac34 bulk edit - check for trash capability before using it 2019-03-25 09:24:25 +01:00
Benjamin Pasero
8288794f50 files2 - add trash capability (for #48259) 2019-03-25 09:11:32 +01:00
Alex Dima
eda154a129 Fix compilation error 2019-03-22 22:38:33 +01:00
SteVen Batten
f832022ef6 fix navigation, modality, and confirm (#70937)
* themable dialog service

* add close action

* fix navigation, modality, and confirm

* addressing feedback, minor polish
2019-03-22 11:46:44 -07:00
Alex Dima
8fc88c6dc6 Move ipc.ts to /common/ 2019-03-22 18:03:14 +01:00
Martin Aeschlimann
9bb443d153 Revert "debugToolbar -> debugToolBar"
This reverts commit e7ca7d5889.
2019-03-22 17:30:57 +01:00
Sandeep Somavarapu
91fac10f4e oops - check isEmpty correctly 2019-03-22 17:04:19 +01:00
Sandeep Somavarapu
bed2921b47 Support remote user configuration 2019-03-22 16:52:14 +01:00
Benjamin Pasero
b4f27b843c files2 - implement basic copy of files without copy support via unbuffered solution 2019-03-22 16:21:24 +01:00
Martin Aeschlimann
fa854de2af URI for waitMarkerFilePath 2019-03-22 16:21:10 +01:00
isidor
e7ca7d5889 debugToolbar -> debugToolBar
fixes #70954
2019-03-22 12:40:21 +01:00
Benjamin Pasero
2699f06fb9 less implicit any (#70352) 2019-03-22 08:08:16 +01:00
Matt Bierner
5412e85864 Fix more implict any errors 2019-03-21 13:06:17 -07:00
Matt Bierner
d1e87a2dd5 More implicit any error fixes 2019-03-21 13:06:17 -07:00
Matt Bierner
d58dcf2e40 Replacing null with undefined around ContextKeyExpr 2019-03-21 13:06:17 -07:00
Benjamin Pasero
6982991b24 fix #70388 2019-03-21 19:56:09 +01:00
Matt Bierner
61c369b5ab Replace some instances of || null with withUndefinedAsNull
The latter is more explicit, correctly handles some edge cases, and helps tag places in the code where we should look into replacing null with undefined.
2019-03-21 10:40:43 -07:00
Matt Bierner
8235163d9b More implicitAny fixes 2019-03-21 09:52:43 -07:00
Matt Bierner
53704af475 Fixing no implicit any in some tests 2019-03-21 09:52:43 -07:00
Benjamin Pasero
eeaf5d876e files2 - implement copyFile support (same providers, copy support) 2019-03-21 17:00:20 +01:00
Benjamin Pasero
245ce3ae21 files - proper size for content 2019-03-21 16:00:00 +01:00
Sandeep Somavarapu
95960cc231 expose settings path in remote environment 2019-03-21 12:48:03 +01:00
Martin Aeschlimann
dc925370e6 add IOpenConfiguration.noRecentEntry 2019-03-21 12:16:53 +01:00
Benjamin Pasero
18c7f91484 files2 - implement moveFile() 2019-03-21 10:18:04 +01:00
Benjamin Pasero
50d5be49fd files2 - introduce and adopt resolveMetadata option 2019-03-21 08:51:34 +01:00
Matt Bierner
e7a7248009 Work on implicit any errors
#70352
2019-03-20 16:53:43 -07:00
Sandeep Somavarapu
155eab32e4 Fix #59750 2019-03-20 21:17:50 +01:00
Matt Bierner
e44ea77199 Merge pull request #70798 from mjbvz/type-stub
Avoid any in TestInstantiationService.stub
2019-03-20 11:35:09 -07:00
Martin Aeschlimann
eb169cae3c StatusBarWindowIndicatorMenu 2019-03-20 17:33:31 +01:00
Sandeep Somavarapu
f49b168fa1 Fix #70500 2019-03-20 14:13:09 +01:00
Benjamin Pasero
44ed24d5df files2 - implement resolving 2019-03-20 13:59:02 +01:00
Johannes Rieken
2ab6546e02 debt - make url service contribute to opener service, #70319 2019-03-20 11:26:00 +01:00
Benjamin Pasero
005c5dbda5 files2 - implement existsFile() 2019-03-20 10:00:01 +01:00
Benjamin Pasero
10c0126e4b debt - reduce null | undefined usages 2019-03-20 08:28:19 +01:00
Matt Bierner
a6e6fb201a Avoid any in TestInstantiationService.stub
Use of any in stub was causing a few issues:
- Lots of implicit anys being used
- Methods / properties being stubbed with wrong types
- Non-existant methods/properties being stubbed

The fix is to require that the passed in stub is either a `Function` (the ctor case) or a `partial` of the type being stubbed.
2019-03-19 23:43:42 -07:00
Matt Bierner
eac048313a Add typings for simple _ and other parameters that are missing types
For #70352

Uses `unknown` for parameters that we don't care about the type of. This prevents the type from being used incorrectly (which `any` would allow)
2019-03-19 23:42:28 -07:00
Martin Aeschlimann
619f3201f0 waitMarkerFilePath to URI 2019-03-19 22:42:36 +01:00