Commit Graph

3355 Commits

Author SHA1 Message Date
Peng Lyu
75e711f8a6 seperate acceptInputCommand and additional commands. 2019-03-07 11:34:43 -08:00
Peng Lyu
87b337a8ad Use unique uuid for comment controller. 2019-03-07 10:29:11 -08:00
Benjamin Pasero
eb12756d0c debt - part service => layout service 2019-03-07 10:16:10 +01:00
Benjamin Pasero
ec10e5b273 debt - partService is really in browser 2019-03-07 09:50:50 +01:00
Rob Lourens
a09e7bd128 Fix #64575 - delete FileIndexProvider 2019-03-07 05:33:35 +00:00
Matt Bierner
03c4f88d7f Strict null check mainThreadWebview 2019-03-06 18:54:36 -08:00
Peng Lyu
b64a7295b2 Merge remote-tracking branch 'upstream/master' into rebornix/commentenhancement 2019-03-06 14:54:42 -08:00
Peng Lyu
ba0f67f828 Fix warnings 2019-03-06 14:39:04 -08:00
Peng Lyu
ce1cb8a9fc replace draft properties with labels in CommentThread and Comment 2019-03-06 14:29:02 -08:00
Gabriel DeBacker
6d665482c8 Put back more of the terminal changes 2019-03-06 14:03:16 -08:00
Sandeep Somavarapu
a4b49166d0 Fix #69110 2019-03-06 22:18:01 +01:00
Peng Lyu
905248fa6e comments panel handle new comment thread registration. 2019-03-06 11:57:30 -08:00
Gabriel DeBacker
d5e4009ae9 Remove need for acquiring dimensions for terminal from main thread 2019-03-06 11:47:57 -08:00
Gabriel DeBacker
99cf5e4881 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask 2019-03-06 10:30:14 -08:00
Peng Lyu
42194d82a1 Callback for creating new comments 2019-03-06 10:15:51 -08:00
Gabriel DeBacker
8b1b0763a3 Merge with master 2019-03-06 07:44:35 -08:00
Johannes Rieken
763ae0943d eng - some extHost strict-null work 2019-03-06 16:44:15 +01:00
Sandeep Somavarapu
cd816afcc9 Take static arguments for the view descriptor ctor 2019-03-06 12:33:18 +01:00
Joao Moreno
e6bc6699a4 strict null checks: extHostSCM 2019-03-06 10:50:07 +01:00
Alex Dima
1d345f0737 URI always needs to be revived after crossing ipc boundaries 2019-03-06 10:19:17 +01:00
Rob Lourens
0710a009f8 Fix #69875 2019-03-05 19:17:54 -08:00
Matt Bierner
52556f9742 Auto converting let -> const where possible in mainthread and extHost
Const provides better type guards and can make logic clearer
2019-03-05 16:53:41 -08:00
Matt Bierner
aef80e8070 Auto marking fields as readonly in mainThread files 2019-03-05 16:53:40 -08:00
Matt Bierner
db9a994ded Strict null check extHostDiagnostics 2019-03-05 16:53:40 -08:00
Matt Bierner
14c4fde6d6 Strict null check extHostQuickOpen 2019-03-05 16:53:40 -08:00
Matt Bierner
8f3cda12e4 Strict null check extHostFileSystem 2019-03-05 16:53:40 -08:00
Matt Bierner
bb64391ec4 Strict null work in exthost 2019-03-05 16:53:40 -08:00
Matt Bierner
733a1cd841 Strict null check extHostDocuments 2019-03-05 16:53:40 -08:00
Matt Bierner
480b838ef2 Strict null check apiCommands 2019-03-05 16:53:40 -08:00
Rob Lourens
10fdea204a Fix #69840 2019-03-05 14:52:09 -08:00
Rob Lourens
f3b73b1abc Fix #69862 - don't split comma-separated globs when expandPatterns is disabled (for findFiles) 2019-03-05 14:52:03 -08:00
Matt Bierner
13e394ff45 Strict null fixes for tests 2019-03-05 11:25:32 -08:00
Peng Lyu
20dfc77b84 update inputbox 2019-03-05 10:12:26 -08:00
Matt Bierner
9fa249ae94 Strict null work on mainThreadSaveParticpants test 2019-03-05 10:06:31 -08:00
Peng Lyu
3cf67b0b7d exthost types, avoid using enums 2019-03-05 10:03:07 -08:00
Matt Bierner
7d88452059 Strict null check mainThreadSaveParticpants 2019-03-05 10:00:07 -08:00
Gabriel DeBacker
41d0633196 Address code review feedback 2019-03-05 08:12:29 -08:00
Sandeep Somavarapu
b5b811980f Remove IWorkspaceConfigurationService 2019-03-05 16:56:14 +01:00
Gabriel DeBacker
998b70c7e2 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask 2019-03-05 07:17:22 -08:00
Johannes Rieken
1eb6de1daf clean up some todos 2019-03-05 10:16:07 +01:00
Daniel Imms
437f7f67cb Move TerminalProcessManager, node->browser 2019-03-04 20:10:07 -08:00
Peng Lyu
56303b0c2c Merge remote-tracking branch 'upstream/master' into rebornix/commentenhancement 2019-03-04 18:29:50 -08:00
Peng Lyu
e78c2e2a21 less verbose comment controller api 2019-03-04 17:27:19 -08:00
Daniel Imms
badedf5d7d Move terminalEnvironment, node->common
Part of #69115
2019-03-04 17:25:24 -08:00
Daniel Imms
8afa7773d5 Remove os dep in terminalEnvironment 2019-03-04 17:16:21 -08:00
Peng Lyu
e42c30a294 CommentController. 2019-03-04 11:37:18 -08:00
Gabriel DeBacker
64748589c5 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask 2019-03-04 07:44:54 -08:00
Johannes Rieken
d9aeef5de6 remove hasChanges-check, fixes #68971 2019-03-04 16:31:30 +01:00
Christof Marti
6fad3377f4 Start CLIServer with extension host 2019-03-04 15:01:53 +00:00
Johannes Rieken
44b4f0e967 remove isMalformedUri thing 2019-03-04 15:59:28 +01:00