Commit Graph

998 Commits

Author SHA1 Message Date
Johannes Rieken
9737b1aad1 move INotebookKernelInfoDto2 to protocol, separate kernel from dto, renames 2021-02-11 11:59:32 +01:00
Connor Peet
c36a09929c testing: implement retired test state
Fixes https://github.com/microsoft/vscode/issues/115086
2021-02-10 15:34:42 -08:00
Megan Rogge
da39b7af3e create PersistentTerminalProcess and move terminal and environmentVariable files from workbench -> platform 2021-02-10 15:26:05 -08:00
Daniel Imms
1abb2d9534 Merge remote-tracking branch 'origin/master' into tyriar/74620_2 2021-02-10 11:34:32 -08:00
Johannes Rieken
b881f37fcc Merge branch 'master' into notebook/outputs 2021-02-10 18:20:40 +01:00
Connor Peet
9070508076 Merge branch 'connor4312/refactor-test-states' 2021-02-09 16:15:16 -08:00
Connor Peet
3d4cabb608 testing: refactor to new runState API
Fixes: https://github.com/microsoft/vscode/issues/115101.
See issue for details.

- Adopts the new API
- Test results now persist across reloads (last 64 runs).
- Removed state grouping in favor of sorting option.
- Code lenses are disabled for now
2021-02-09 16:12:37 -08:00
rebornix
11b885de68 Merge remote-tracking branch 'origin/master' into notebook/outputs 2021-02-09 09:27:49 -08:00
Johannes Rieken
efd5a000c0 add InlineHintKind to InlineHint-type 2021-02-09 15:56:24 +01:00
Daniel Imms
6132a763bc Get one way communication happening 2021-02-09 04:07:38 -08:00
Daniel Imms
456841a93b Create createProcess ipc interface 2021-02-08 12:37:10 -08:00
Johannes Rieken
e3d0d9c00c Merge branch 'master' into notebook/outputs 2021-02-08 10:44:34 +01:00
SteVen Batten
afd102cbd2 Trusted Workspaces Feature Branch Merge (#115961)
* draft trusted workspace service / model

* renaming

* add request model and action

* err fix

* add request handlers with mock actions

* some quick fixes

* adding badge icon to activity bar gear

* Add Statusbar item to indicate trust

* Cleanup code

* Add background color

* Use theme color for the status background color

* adding basic editing experience

* observe trust with startup tasks

* Extension enablement

* Add capability to provide a custom message

* Remove old actions

* explorer: if you can not undo, pass undo to editor

fixes #111630

* Remove plug icon from ports view
Part of https://github.com/microsoft/vscode-internalbacklog/issues/1689

* Fixed compilation error

* Handle extension uninstall

* Handle extension install

* Ability to prompt when state is untrusted

* Do not change state is the modal dialog is dismissed or the Cancel button is pressed

* Refactored enablement code

* Prompt when installing from VSIX

* Prompt when installing from the Gallery

* Move file into the browser folder

* fixes and polish

* restructure workspace contributions

* restructure actions and use confirmations

* Initial draft of the proposed APIs

* Added stubs for the proposed api

* Trusted Workspace proposed API

* Fix a regression introduced by merge

* status bar indicator improvements

* remove helper command as we now have hooks

* verbose messaging for the immediate request

* add indication to global activity icon of pending request

* try personal title

* Add configuration setting

* Add additional extension actions

* Fix contributions

* Removed context key that is not needed

* Fixed issue with the dialog

* Reduce arbitrary event limiter from 16ms down to 4.16666 (support for monitors up-to 240hz) #107016

* Fixes #115221: update emoji tests

* Give a higher priority to language configuration set via API call (#114684)

* debug console menu action polish

* Avoid the CSS general sibling combinator ~ for perf reasons

* more notebook todos

* Use label as tooltip fallback properly
Part of #115337

* Fixes microsoft/monaco-editor#2329: Move `registerThemingParticipant` call to `/editor/`

* Fix port label not always getting set
Part of microsoft/vscode-remote-release#4364

* simplify map creation, fyi @bpasero

* Fix #114432: Multiple save dialogs appearing on Windows if Ctrl+S is pressed multiple times (#114450)

* fix multiple save dialogs appearing on Windows when spamming Ctrl+S

* remove old fix and instead keep track of windows with open dialogs in the dialogMainService

* keep initialisation of activeWindowDialogs in constructor

* remove unused variable

* some changes

* queue dialogs based on hash of options

* simplify structure, fix comment typo

* Apply suggestions from code review

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* remove unnecessary async/await for aquireFileDialogLock method

* don't acquire file dialog lock for message boxes

* use MessageBoxReturnValue | SaveDialogReturnValue | OpenDialogReturnValue instead of any type for getWindowDialogQueue

* Apply suggestions from code review

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* 💄 dialog main service locks

* debt - adopt some ? operator

* Better hiding of custom hover in icon label

* Limit to 8ms (120fps)

* more API todos for notebooks

* 💄

* Update grammars

* chore - group notebook specific api proposals together

* added unreleased fixes to endgame notebook

* Add changes back to the modal dialog

* Add back the workspace trust proposed APIs

* Adjust dialog buttons

* Standardize on WorkspaceTrust name across interfaces, classes, variables

* Renamed some of the missing keys

* Add TestWorkspaceTrust stub and fix failing tests

* Add requiresWorkspaceTrust property to fix test failure

* remove notebook change

Co-authored-by: Ladislau Szomoru <lszomoru@microsoft.com>
Co-authored-by: isidor <inikolic@microsoft.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: TacticalDan <gorksorf@gmail.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
Co-authored-by: Cameron <cameron532@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2021-02-06 00:38:32 -08:00
rebornix
5024a7053a convert output exthost/main. not optimized. 2021-02-05 14:34:40 -08:00
rebornix
0a972947a1 no error and stream output anymore 2021-02-05 11:41:41 -08:00
rebornix
175ac0e0e5 OutputDto always has id 2021-02-05 11:25:54 -08:00
Alex Ross
26e6d9e93a Set the remote ext host pid and name (#115891)
Fixes #115213
2021-02-05 17:00:34 +01:00
rebornix
f2b87fd6cd Extensions do not update cell outputs/metadata directly. 2021-02-04 16:35:50 -08:00
rebornix
b5ba200088 output always contains id 2021-02-04 11:44:02 -08:00
Rachel Macfarlane
5115a8eae7 Don't show a modal on 'getSession' for access requests if 'createIfNone' is false, fixes #111529 2021-02-03 09:58:29 -08:00
Johannes Rieken
74937e0a89 Merge pull request #115530 from microsoft/joh/norpc
Hide API implementation proxies, add tests to check for "proxy leakage"
2021-02-03 09:17:56 +01:00
rebornix
66635b8bd6 remove unknown content change in nb text model. 2021-02-02 12:54:11 -08:00
rebornix
04abcc0338 yarn watchd does not detect interface change again. 2021-02-02 11:44:47 -08:00
Connor Peet
3088c27fbd debug: mark terminal as free when the associated debug session ends (#115573) 2021-02-02 08:27:37 -08:00
Johannes Rieken
a60beb9d7a don't leak proxies in editor land, also remove indentSize property which isn't API 2021-02-01 12:01:50 +01:00
rebornix
b112052169 fix #114171 2021-01-25 14:19:59 -08:00
Connor Peet
bd7dff7f07 testing: add test result to proposed api, ids for correlation 2021-01-25 12:20:28 -08:00
rebornix
7468a06012 Revert "fix #114171."
This reverts commit e32e353bfd.
2021-01-25 10:45:27 -08:00
rebornix
9f9d1a76d9 support kernel id and extension 2021-01-21 15:57:28 -08:00
Alexandru Dima
ec1eda0d96 Rename OnEnterRule.oneLineAboveText to previousLineText after API call feedback (#58440) 2021-01-20 17:31:04 +01:00
Johannes Rieken
e9263cc826 some API proposal for open editors 2021-01-20 12:35:18 +01:00
Connor Peet
686cd7df53 testing: clean up actions, add run/debug all, rm duplication
The WorkspaceTestCollectionService duplicated collection logic
unnecessarily. Centralize to the TestService's collection.

This also moves the state updates for discovering tests, and a new
update for adding roots, into the diff, which lets us synchronize those
changes with the changes to test collections.

There's a super crazy bug with the "run all" action that I have
not dove into yet.
2021-01-19 17:44:02 -08:00
Matt Bierner
c42b385bce Disable contributed openers by default in calls to openExternal
Fixes #114543

External and internal callers to openExternal may not expect (or want) their urls to be handled by a contributed opener. This change makes it so you have to explicitly enable using contributed openers when calling openExternal.

It also enables using contributed openers for a few places in our codebase
2021-01-19 12:16:34 -08:00
Alex Ross
c0c033ff4f Use port auto forwarding setting to disable port finding (#114574) 2021-01-19 17:06:06 +01:00
Johannes Rieken
756337d48a Merge branch 'master' into signaure_arguments_label 2021-01-18 16:01:38 +01:00
Wenlu Wang
1c131cf265 Avoid extra fields 2021-01-18 17:48:43 +08:00
Wenlu Wang
3c2c937f99 Merge branch 'master' into signaure_arguments_label 2021-01-18 17:38:35 +08:00
Wenlu Wang
fcc00b29f5 Avoid ts changes (#2)
* Add ts server for inline hints

* Add some feature related configure

* Add more config

* Rename all options

* Support range

* Add new contribution point to allow specific context menu of inline hints.

* Fix filename

* Pass range into command

* Support trigger position and prefix/postfix

* Support hover message and contextValue

* Add event listener

* Avoid demo command

* Avoid ts changes
2021-01-18 17:24:23 +08:00
Rachel Macfarlane
2e89c2d4ba Add 'key' to onDidChange of secrets API, #112249 2021-01-15 17:08:09 -08:00
Alexandru Dima
b64a4ae1aa Scaffold MessageOptions.useCustom 2021-01-15 17:35:47 +01:00
Johannes Rieken
6d50c71f41 add editor command, fyi @dbaeumer 2021-01-15 17:32:07 +01:00
Matt Bierner
cc5e8b22fa Continue work on url opener api
For #109277

- Add `option` opener priority. This means the oper will only be shown if requested but will not replace the default opener
- Persist registered openers for IntelliSense suggestions
2021-01-14 17:06:14 -08:00
rebornix
e32e353bfd fix #114171. 2021-01-14 15:18:16 -08:00
Matt Bierner
5d6cba5cbc Reworking external opener implementation to allow configured openers to be called directly without a canOpen check
If the user has configured a specific external uri opener, we should always try to use that without first calling `canOpen` to filter down the list of openers.

This change also adds `ExternalUriOpenerEnablement` which allows an opener to mark itself as the preferred opener for a given uri. If only a single preferred opener is returned, it will be used automatically for that uri (although user configuration can override this)
2021-01-14 10:37:00 -08:00
Daniel Imms
c972009ef6 Merge pull request #114214 from microsoft/tyriar/flow_control
Implement terminal flow control
2021-01-14 06:44:30 -08:00
Daniel Imms
f8ec60aa06 Add flow control setting, remove fake latency 2021-01-14 06:04:03 -08:00
Matt Bierner
47aa3ad09a Continue work on opener service
- Add error notification if opener throws an exception
- Add public facing id to openers. This is used in settings
- Add intellisense for the opener id setting
2021-01-13 12:53:18 -08:00
Alex Ross
b903748b83 Fix candidate filter and auto forwarding wiring (#114290) 2021-01-13 18:06:31 +01:00
kingwl
9853c8fe6d Fix cr issues 2021-01-13 19:21:51 +08:00
Matt Bierner
47a135e715 Rework opener api proposal
For #109277

- Add more explicit two phase structure to api
- Make opener pass along label when registered
2021-01-12 16:14:42 -08:00