Commit Graph

48 Commits

Author SHA1 Message Date
Johannes Rieken
f9b5f8f624 💄 2021-05-07 14:16:00 +02:00
Johannes Rieken
b177753668 check that a cell is still "alive" and only iff so start executing it, fixes https://github.com/microsoft/vscode/issues/123269 2021-05-07 14:14:14 +02:00
Johannes Rieken
2fe990d12d throw error when creating an execution task for a notebook that the controller isn't associated to, https://github.com/microsoft/vscode/issues/122877 2021-05-05 08:41:16 +02:00
Connor Peet
d639345791 notebooks: improve renderer message passing
Fixes https://github.com/microsoft/vscode/issues/122944
2021-05-04 12:35:06 -07:00
Johannes Rieken
42754baf3a relax uniqueness requirement for controller ids, must only be unique per extension, not globally, https://github.com/microsoft/vscode/issues/121902 2021-04-26 14:38:04 +02:00
Johannes Rieken
f68a7e7778 add NotebookDocument to executeHandler 2021-04-22 17:34:51 +02:00
Johannes Rieken
97344537a5 Use affinity over priority 2021-04-22 16:43:36 +02:00
Johannes Rieken
5390ec0e7c remove isPreferred as instance property, replace selector with only viewType, allow controller to set a notebook priority instead 2021-04-22 16:13:42 +02:00
Johannes Rieken
dab0e063bc mark supportedLanguages as optional, some todos 2021-04-22 14:50:53 +02:00
Johannes Rieken
12741ed7d8 add notebook instance to interrupt handler, https://github.com/microsoft/vscode/issues/121912 2021-04-22 14:17:04 +02:00
Johannes Rieken
2e0214b364 rename ExecutionHandler to ExecuteHandler 2021-04-22 08:03:31 +02:00
Johannes Rieken
e2c9703995 prefix api object with api-prefix, like apiCell 2021-04-21 15:34:44 +02:00
Johannes Rieken
4f9ac638ff extension contributed kernels fall back to all languages when supportedLanguages isn't set, https://github.com/microsoft/vscode/issues/121329 2021-04-21 11:34:48 +02:00
Johannes Rieken
b2b45e1005 execute by cell-handle, kernel manager has only execute/cancel cells, also "fix" isNotebookCellData fyi @rebornix 2021-04-20 14:39:19 +02:00
Johannes Rieken
fe7951dd7a remove kernel provider from core, adopt kernel service, merge kernel2 and kernel interface, extract context keys from kernel manager, make context key manager only for execution/cancellation 2021-04-20 11:30:31 +02:00
Johannes Rieken
11c3ba58af remove NotebookKernelProvider API and its implementation 2021-04-19 16:19:23 +02:00
Johannes Rieken
f9fec24b45 make INotebookKernel2 extends INotebookKernel 2021-04-19 11:56:18 +02:00
Johannes Rieken
6b9bd78998 add NotebookController#detail 2021-04-19 08:58:01 +02:00
Johannes Rieken
93dbc7ac44 remove NotebookControllerOptions and simplify createNotebookController-signature 2021-04-16 15:23:34 +02:00
Johannes Rieken
95932045c7 check that notebook controller are unique per id 2021-04-16 14:22:44 +02:00
Johannes Rieken
98f69856ea extract types for execute/interrupt handler, interrupt in not per document but per controller 2021-04-16 11:45:04 +02:00
Johannes Rieken
c074bf897c make preload a creation argument, no editor needed when calling asWebviewUri 2021-04-16 11:29:28 +02:00
Johannes Rieken
8877d8ca94 hook up execution task cancellation from controllers 2021-04-16 10:51:45 +02:00
rebornix
662ea12128 NotebookCellRange is now NotebookRange. 2021-04-15 13:09:37 -07:00
Johannes Rieken
bbf148b0c6 merge renderer IPC into notebook controller, remove global renderer IPC 2021-04-15 18:41:56 +02:00
Johannes Rieken
68d9e02338 add support for isPreferred for notebook controllers 2021-04-15 16:50:09 +02:00
Johannes Rieken
b2103c79e4 add preloads to notebook controller, fyi @connor4312 NotebookKernel will go out soon 2021-04-15 16:44:43 +02:00
Johannes Rieken
f1d0c30f1e pass cells and controller to execute handler 2021-04-15 13:14:29 +02:00
Johannes Rieken
0aabafd35f NotebookControllerOptions instead of NotebookKernelOptions 2021-04-15 13:00:52 +02:00
Johannes Rieken
02f0f4a0c8 make createNotebookRendererCommunication independent of controller, make it renderer first 2021-04-14 18:33:14 +02:00
Johannes Rieken
c9b2c54231 rename NotebookKernel2 to NotebookController 2021-04-14 15:11:56 +02:00
Johannes Rieken
d6ae97cf97 add Kernel2#createNotebookRendererCommunication 2021-04-14 15:09:06 +02:00
Johannes Rieken
7c946e118a add onDidChangeNotebookAssociation-API and wire everything up using the glue adapter 2021-04-13 15:57:03 +02:00
Johannes Rieken
fcd005ce8c fix compile errors, evolve internal API about kernel selection 2021-04-13 14:29:46 +02:00
Johannes Rieken
e66dbdeb45 default supported languages is plaintext 2021-04-13 12:59:43 +02:00
Johannes Rieken
88006b8437 add (bring back) NotebookKernel#createNotebookCellExecutionTask 2021-04-12 18:43:21 +02:00
Johannes Rieken
ec8c7257ed remove/disable selected and onDidChangeSelection from new kernel world
this need further clarification. we might be able to fold this into the API for communicating with a renderer
2021-04-09 15:05:58 +02:00
Johannes Rieken
edd36fd64c add and adopt implementsExecutionOrder 2021-04-09 13:03:49 +02:00
Johannes Rieken
354c914f67 add NotebookKernelOptions so that createNotebookKernel is simpler 2021-04-08 15:36:45 +02:00
Johannes Rieken
015d5565b7 remove createNotebookCellExecutionTask from NotebookKernel2 because exec-handler is called with executions 2021-04-08 15:25:31 +02:00
Johannes Rieken
be198294e4 execute handler gets notebook cell execution directly 2021-04-08 15:05:39 +02:00
Johannes Rieken
461f09ff78 add extension identifier to kernel 2 2021-04-08 11:22:00 +02:00
Johannes Rieken
72d772b1a1 make execution and interrupt callback instead of commands 2021-04-07 16:35:08 +02:00
Johannes Rieken
84f3054624 add local resource root and cancelCells so that Kernel2 is very similar to Kernel 2021-04-07 15:12:45 +02:00
Johannes Rieken
9221eb9697 don't forward changes for disposed kernels 2021-04-07 14:37:30 +02:00
Johannes Rieken
38e4243e2d add kernel push to proposed API 2021-04-07 12:06:38 +02:00
Johannes Rieken
c3f72be495 add createNotebookCellExecutionTask to kernel object 2021-04-06 17:57:33 +02:00
Johannes Rieken
b47fb7a275 add kernel service and add extension host logic for it 2021-04-06 15:46:01 +02:00