Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-19 16:18:58 +01:00
Code Issues Packages Projects Releases Wiki Activity
39,428 Commits 3,583 Branches 356 Tags
f9d8addc07a0320193b1b277c8ed2f575176dbde
Commit Graph

330 Commits

Author SHA1 Message Date
Alex Dima
f9d8addc07 Merge remote-tracking branch 'origin/master' into pr/limerickgds/51557 2018-09-11 15:30:40 +02:00
Matt Bierner
d33b1c3063 Initial work on signature help context (#58135) 
* Initial work on signature help context

Fixes #54972

Adds `SignatureHelpContext`. This tells providers why signature help was requested

TODO:

- [ ] Better understand semantics of retrigger. Should `retrigger` be an flag instead of a `triggerReason`?
- [ ]  Fix skipped test
- [ ] Add more tests for trigger reasons / trigger characters

* Fix unit test

* Make sure we retrigger sig help if it is already showing

* Add test for dismiss and re-invoke

* Extract some constants

* Extract createMockEditor
 2018-09-10 17:44:21 -07:00
Matt Bierner
5db4761cac Remove unused param 2018-09-10 15:51:55 -07:00
Matt Bierner
d5bd9803bd Change behavior of jt/ts jsdoc completions 
Changes how jsdoc completion works to reduce typing delays and hopefully avoid showing it for fewer false positives. Main changes

- Only show the completion item if typescript's docCommentTemplate returns something. This means that you won't see the completion item in cases like: `/** |a */`  or `/**|` anymore. However in the case of `/**|`, pressing return will still complete to the empty comment as expected

- Get the snippet for the completion early so there is no flash when accepting it
 2018-09-10 15:41:07 -07:00
Matt Bierner
2d4a98842b Rename javascript.nameSuggestions to javascript.suggest.names 
Bring this setting name inline with other suggestions settings

Part of #58385
 2018-09-10 15:41:07 -07:00
Matt Bierner
ae7035dbbf Add setting to disable all path based sugestions in js/ts 
The new  `javascript.suggest.paths` and `typescript.suggest.paths` settings replace `typescript.quickSuggestionsForPaths`. These settings should disable all path based suggestions from js/ts

The old `quickSuggestionsForPath` setting is now marked deprecated and is not being migrated to these new settings as it has different semantics. It was originally designed just to disable quick suggestions for paths but it does not work properly when using TypeScript 2.9+
 2018-09-10 15:41:07 -07:00
Matt Bierner
72581dfca9 Rename typescript.autoImportSuggestions.enabled and allow it to be applied to js or ts separately 
Part of #58385
 2018-09-10 15:41:07 -07:00
Matt Bierner
98894ae9ba Rename typescript.suggestions.enabled to typescript.suggest.enabled to be more consistent with other extensions 2018-09-10 15:41:07 -07:00
Matt Bierner
937cbc186b Split suggestions.enabled into js and ts specific settings 2018-09-10 15:41:07 -07:00
Matt Bierner
3e176b19bc Only wrap rename request in try catch 2018-09-10 12:49:49 -07:00
Dave Williams
b9dbeb90d1 New config to turn off TypeScript autocomplete suggestions (#58011) 
* New config to turn off TypeScript autocomplete suggestions

* add missing semicolon

* Exclude everything, even name suggestions, when suggestions disabled
 2018-09-10 11:06:12 -07:00
Matt Bierner
d140d23129 Disable all commit characters when in spread contexts 
Fixes #55700
 2018-09-10 10:58:34 -07:00
Matt Bierner
567baa4eff Fix some errors around js commit characters 
- Add commit characters for keywords such as `this` and `super`.
- Allow trigger characters on lines with only leading whitespace

Fixes #58048
 2018-09-10 10:44:37 -07:00
Matt Bierner
dc47417f54 Delegate js/ts code lenses back to vs code 
Fixes #43574
 2018-09-07 16:47:26 -07:00
Alex Dima
c36258d23f Use const enums (to inline their values in JS) 2018-09-06 20:39:19 +02:00
Matt Bierner
c78dafa252 Treat ; as a commit character in js/ts 
Fixes #44011
 2018-09-06 10:48:17 -07:00
Johannes Rieken
c2c5819fc8 adopt vscode-nls 4.0.0 2018-09-06 14:44:33 +02:00
Johannes Rieken
74fa1d8994 Merge pull request #57956 from Microsoft/joh/vsce-next 
use packagedDependencies from running vsce#ls
 2018-09-06 11:14:38 +02:00
Matt Bierner
72a24483c4 Use providedCodeActionKinds to avoid calling providers that we know will not return actions of interest 
Part of #57875
 2018-09-05 11:14:28 -07:00
Matt Bierner
a9e93b1055 Try interuprting getErr requests for user actions 
Fixes #57542
 2018-09-05 10:13:28 -07:00
Matt Bierner
420917046b Use events on Reader instead of callbacks 
Also make reader dispoable
 2018-09-05 10:13:28 -07:00
Matt Bierner
c207d5da4c Don't try restarting ts server after extension deactivation 
Fixes #57534
 2018-09-05 10:13:28 -07:00
Johannes Rieken
3885d4613e Merge branch 'master' into joh/vsce-next 2018-09-05 14:06:12 +02:00
Andrew Casey
cd7c7c5fa2 Add GDPR annotation for typescript-language-features/languageserviceerrorresponse (#57182) 2018-09-04 15:37:27 -07:00
Johannes Rieken
ccec2c9543 use vsce packagedDependencies 2018-09-04 12:29:23 +02:00
Johannes Rieken
f82bcb20ed webpack - move __dirname-config up into shared config 2018-09-03 12:38:46 +02:00
Johannes Rieken
a3b6f18ac4 fix #57390 2018-08-28 16:35:27 +02:00
Johannes Rieken
b0f63ff69d Merge pull request #57155 from Microsoft/joh/ts-webpack 
Webpack for ts extension
 2018-08-24 17:00:11 +02:00
Johannes Rieken
1f616aaee8 update ignore file 2018-08-24 16:51:11 +02:00
Johannes Rieken
cdb9c0a8f4 update vscode-nls-dev to fixed version, share more config between extensions 2018-08-24 16:37:10 +02:00
Matt Bierner
cd9beb845c Disable node_modules check for update paths on file rename 
Fixes #55882

This check was originally added to workaround a TS issue which should now be fixed. If it is not fixed, we want to know about it so that we can get TS to fix it upstream
 2018-08-24 16:02:49 +02:00
Matt Bierner
a8d7c6343c Don't request refactorings for empty selections 2018-08-24 16:02:49 +02:00
Johannes Rieken
6ba52f7b25 copy nls 2018-08-24 15:04:36 +02:00
Johannes Rieken
099d99b76c wip 2018-08-24 14:54:50 +02:00
Matt Bierner
ae5fff075d Don't explicitly de-indent on ) in js/ts 
Fixes #56275
 2018-08-24 12:26:44 +02:00
Matt Bierner
7b21b23496 Remove out of date comments 2018-08-24 12:26:44 +02:00
Matt Bierner
ad68ff316c Remove std-fork 2018-08-21 17:05:46 +02:00
Johannes Rieken
27c72d4ea4 remove logDirectory, #43275 2018-08-20 15:42:09 +02:00
Rob Lourens
d505bb4781 Workaround #55649 2018-08-16 09:57:33 +02:00
Rob Lourens
a0764210a8 #55478 - switch all builtin settings to 'markdownDescription' instead of 'description' where needed 2018-08-08 17:01:37 -07:00
Matt Bierner
6bcabdeefe Add enum descriptions to typescript.preferences.importModuleSpecifier 2018-08-03 18:06:50 +02:00
Matt Bierner
7c6c7ac5fe Allow extends to work without json suffix 
Fixes #16905
 2018-08-02 10:36:07 +02:00
SteVen Batten
44f5e55785 oss updates for endgame 2018-07-31 22:40:25 -07:00
Ramya Achutha Rao
1912c5d755 Allow extensions to log telemetry to log files #54001 2018-07-30 16:18:54 -07:00
Matt Bierner
5198030c09 Describe what implementation code lens does 
Fixes #55370
 2018-07-30 15:59:17 +01:00
Matt Bierner
3086c88d21 Don't try closing tags when you type > after another > 2018-07-30 15:57:41 +01:00
isidor
55dfcd730e settings sweep 
#54690
 2018-07-30 16:53:12 +02:00
Rob Lourens
a2767ab649 Setting descriptions 2018-07-28 12:13:36 -07:00
Matt Bierner
eb0688ed63 Remove extra check 
This is already handled by using a resource map
 2018-07-27 14:21:18 -07:00
Matt Bierner
6ffbde1f4a Don't lowercase all file paths on case insensitive file-sysystems for geterr 
Instead, we should always use the casing of the first file we see with a given path
 2018-07-27 14:00:52 -07:00