Commit Graph

139 Commits

Author SHA1 Message Date
Joyce Er
fa4ff1519d Implement and adopt edit session identifier API proposal (#157733)
* Add canonical workspace identifier proposed API

* Use canonical id to store and resume edit sessions

* Add git extension workspace identity provider

* Fix warning incorrectly showing up

* Make auto resume behavior opt in

* * Create a separate service
* Accept WorkspaceFolder instead of URI
* Return string instead of object

* Make edit session restores resilient to provider registration races

* Introduce an activation event
* Activate contributing extension before using provider

* `CanonicalWorkspaceIdentity` -> `EditSessionIdentity`

* Show progress while resuming edit session

* Store edit session even if extension will take care of opening target workspace

* Address most of PR feedback

* `IEditSessionsWorkbenchService` -> `IEditSessionsStorageService`

* Unregister provider in renderer

* Split out proposal into new `editSessionIdentityProvider.d.ts`

* Fix bad merge

* Always show progress in window

* Convert URI schemes
2022-08-19 08:01:43 -07:00
Benjamin Pasero
dced70bbf3 Create editor groups from ViewColumn as needed (refs #123270) (#157640)
* make `createTextEditor` async and create editor groups (refs #123270)

* API docs update
2022-08-10 06:51:07 +02:00
Johannes Rieken
8bada27fdd Merge pull request #155148 from microsoft/joh/double-barnacle
joh/double barnacle
2022-07-18 16:45:00 +02:00
Benjamin Pasero
aeb4a695fc tests - speed up unit tests (#149712) (#155147)
* tests - convert history tracker to in-memory (#149712)

* fix warnings from missing service

* sqlite slowness

* disable flush on write in tests unless disk tests

* more runWithFakedTimers

* disable flush also in pfs

* fix compile
2022-07-15 12:12:56 +00:00
Alex Ross
e06f679dbf MainThreadHostTreeView: [createInstance] First service dependency of CustomTreeView at position 4 conflicts with 2 static arguments (#155160)
Fixes #155155
2022-07-14 09:03:35 +00:00
Johannes
40df705e1b add API proposal for vscode.TabInputTextMerge 2022-07-14 09:33:13 +02:00
Johannes Rieken
f413297170 joh/plastic fowl (#154275)
* * derive workspace dto with util
* be strict when defining reference version ids (must be set to a value or undefined)

* relax `ResourceNotebookCellEdit`
2022-07-06 18:33:04 +02:00
Johannes Rieken
1aaff9ef3d stub activationEventIsDone function, (#154276)
fixes https://github.com/microsoft/vscode/issues/154268
2022-07-06 11:10:43 -04:00
Matt Bierner
2c7201670f Remove use of forEach (#154196)
For #154195
2022-07-05 12:51:28 -07:00
Johannes Rieken
7fb4287727 calling executeCommand for a locally known extension cmd should fire activation event (#153683)
We should always fire the event but when the command is already known (locally) we don't await that.

fixes https://github.com/microsoft/vscode/issues/150293
2022-06-29 16:37:23 +02:00
David Dossett
f148d86fd2 Add "Do Not Disturb" Mode (#149645)
* Add mute icon to notification center toolbar

* Add placeholder mute method

* Add config service support

* Refactor mute toggle behavior

* More refactoring

* Add hack for switching actions on toggle

* Use do-not-disturb icons

* Update status bar icon

* Add comment for hack todo

* Add experimental tag

* Update setting name references

* Fix typo

* Update status bar icon and filter all errors

* Update icons

* Updates icon and toggle behavior

* Update codicons ttf

* cleanups

* Use UI state instead of setting

* Show window progress instead of notification

* Update Storage scopes

* Update Storage scopes

* Refactor to use NotificationService

* Minor fixes

* Update tests

* Address PR feedback

* Update tests

* 💄

* 💄

* zen - use dnd mode for filtering

* set filters right on startup

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-06-27 06:49:10 -07:00
Justin Chen
7cb79a6027 Merge pull request #152383 from justschen/justin/CodeAction-Telemetry
Adding additional telemetry on CodeActions (trigger reasons)
2022-06-23 11:06:21 -07:00
Johannes Rieken
3d6ab7cfe6 passing test for https://github.com/microsoft/vscode/issues/152882 (#152998) 2022-06-23 10:24:31 -07:00
Sandeep Somavarapu
a1e1e307e3 introduce application config model (#152889)
* introduce application config model
- application configuration is active and used only in non default profiles
- read/write application scoped settings only from application layer and not from user layer
- extensions get application scoped values as global values
- settings editor does not show application scoped settings in non default profle
- added unit tests

* fix tests
2022-06-22 11:57:39 -07:00
Justin Chen
081bcdca40 fixed tests in extHostLanguageFeatures 2022-06-17 12:47:59 -07:00
Alexandru Dima
2e91c26f1d Avoid old import syntax (#152471) 2022-06-17 14:15:55 +00:00
Matt Bierner
001d52cf6b Add Symbol.iterator functions for vscode.d.ts collection types (#151806)
* Add entries functions for vscode.d.ts collection types

Fixes #151802

* Spelling

* Enable lib.iterable in vscode.d.ts

* Switch to use `Symbol.iterator` instead of `entries`

* Use extends Iterable in more places

* Fixing testItemCollection types

* Fixing exthost testing
2022-06-15 16:29:50 +00:00
Matt Bierner
354e1a0595 Finalize data file reading API (#152127)
Fixes #147481
Also reverts #150963 since the `kind` field is not being finalized
2022-06-15 07:56:02 -07:00
Johannes Rieken
3d471d2ca9 Merge pull request #151841 from microsoft/joh/cute-bobcat 2022-06-15 08:46:12 +02:00
Alexandru Dima
d8823e67a9 Revert "fix https://github.com/microsoft/vscode/issues/150293 (#151616)" (#152026)
This reverts commit 670c3fd002.
2022-06-14 12:16:18 +02:00
Johannes
0376810398 add API proposal for TextEdit#newText: SnippetString 2022-06-13 11:33:42 +02:00
Johannes
ed9ed45794 Merge branch 'main' into joh/voluminous-lobster 2022-06-10 09:07:30 +02:00
Matt Bierner
f7e12a3a92 Use optional method calls in more places (#151634)
This replaces code like:

```ts
if (foo.bar) {
    foo.bar(cat);
}
```

with:

```ts
foo.bar?.(cat)
```

Which is more concise but has the same meaning
2022-06-09 15:04:28 -07:00
Johannes Rieken
670c3fd002 fix https://github.com/microsoft/vscode/issues/150293 (#151616) 2022-06-09 14:55:46 +00:00
Johannes
43c31079ee manual fixing of prefer-const violations 2022-06-09 10:19:56 +02:00
Johannes
0656d21d11 auto-fixed prefer-const violation 2022-06-08 17:49:21 +02:00
Tomer Chachamu
c6350b3800 Ensure access token comes from correct provider (#150473) 2022-05-27 22:52:12 +00:00
Matt Bierner
d891b49fc0 Enable file DataTransfer on tree views (#150328)
For #147481
2022-05-24 21:38:12 -07:00
Joao Moreno
ffb7b00100 Merge commit 'ae2202631366eea0aaed6f881f87c2b44ae1b647' into sandy081/policy 2022-05-18 20:12:22 +02:00
Johannes
30f5b296ab make getWordAtText-config configurable and use lower budget for speedy tests 2022-05-17 16:53:50 +02:00
Alexandru Dima
6ec996a9b7 Adopt runWithFakedTimers to speed up tests (#149712) (#149720) 2022-05-17 16:21:45 +02:00
Sandeep Somavarapu
5eb8bee367 Merge branch 'main' into sandy081/policy 2022-05-13 08:39:05 +02:00
Matt Bierner
67014adc30 Remove the textDocumentNotebook API proposal (#149277)
* Remove the textDocumentNotebook API proposal

All consumers have now been migrated off of this proposal, so it is safe to remove from our code

* Remove deprecated api usage from test
2022-05-12 08:59:11 +02:00
Sandeep Somavarapu
e4c04ea2e9 - Introduce policy model with file policy
- Introduce policy configuration using policy model
- Use policy configuration while reading, inspecting and writing configuration
- Adopt json settings editor
2022-05-10 13:49:31 +02:00
Tyler James Leonhardt
6c8d8a2654 Have forceNewSession behave like createIfNone if no sessions are present (#148819)
* Have forceNewSession behave like createIfNone if no sessions are present

* include note in vscode.d.ts about forceNewSesssion behavior
2022-05-05 13:30:14 -07:00
Benjamin Pasero
8a39cb9304 labels - make getPathLabel aware of remote OS 2022-04-26 18:09:01 +02:00
Logan Ramos
aa69f3d762 Fix #15178 Finalize tabs API 🎉 2022-04-21 11:08:12 -04:00
Johannes
5931aa8ed6 fix two issues with notebookType and document selectors, (1) make sure that notebookType: * matches only when a notebook is around, (2) include notebookType-property when converting from extHost type to renderer type, fyi @dbaeumer 2022-04-20 09:47:13 +02:00
Matt Bierner
50ea16198d Remove the concat text document api proposal
Fixes #146781
2022-04-14 14:39:44 -07:00
Johannes Rieken
35c34e1a9a add TabGroupChangeEvent-event which is similar to the TabChangeEvent (#147443) 2022-04-14 09:08:28 -04:00
Logan Ramos
27cb4a5934 Add move patching tests 2022-04-11 13:53:27 -04:00
Alex Dima
e02a7747eb Move terminate() to IExtHostExtensionService 2022-04-07 22:23:38 +02:00
Matt Bierner
32acfdde2a Correctly set webview active state on restore
Fixes #145648
2022-04-05 16:43:54 -07:00
Logan Ramos
135a162106 Rename .groups to .all again 2022-04-05 15:06:31 -04:00
Logan Ramos
ef71c65923 Change onDidChangeTab event 2022-04-05 14:56:47 -04:00
Matt Bierner
f2a505a15d Fix type in testing
Missed this in re-build
2022-04-04 09:40:39 -07:00
Logan Ramos
acab001237 Remove active change events 2022-04-01 14:24:35 -04:00
Johannes
909602cf04 remove unused $tryApplyWorkspaceEdit function from mainThreadEditors 2022-03-31 12:37:06 +02:00
Connor Peet
c39c600ff4 testing: fix comp error 2022-03-30 16:01:45 -07:00
Connor Peet
14a318068c testing: disentangle test item collection from exthost for use in tests
Fixes #141921
2022-03-30 14:57:46 -07:00