Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 03:54:24 +01:00
Code Issues Packages Projects Releases Wiki Activity
50,226 Commits 3,673 Branches 359 Tags
fbd7b4920bd425acd8a1daeacebe98992649286e
Commit Graph

3574 Commits

Author SHA1 Message Date
Daniel Imms
fbd7b4920b Merge pull request #75290 from microsoft/75278_finalize_runInBackground 
Finalize TerminalOptions.runInBackground API
 2019-06-17 09:34:59 -07:00
Daniel Imms
a7412fbb2b Pass cwd through to main 2019-06-17 09:32:07 -07:00
Benjamin Pasero
bb0603c573 adopt more DisposableStore/MutableDisposable (#74922) 2019-06-17 09:31:13 +02:00
Peng Lyu
8ef603062f #74846. no CommandsConverter#toInternal 2019-06-14 13:03:41 -07:00
Daniel Imms
97dfc68f39 Merge remote-tracking branch 'origin/master' into alexr00/terminalExitRace 2019-06-14 12:14:40 -07:00
Daniel Imms
10d4256ff5 Remove process usage from terminalEnvironment 
Fixes #75509
 2019-06-14 11:33:37 -07:00
Johannes Rieken
fa71df46e6 remove ExtHostHeapService 2019-06-14 19:19:44 +02:00
Daniel Imms
e08e8b025f Move window.shell to env.shell 
Part of #75091
 2019-06-14 09:15:39 -07:00
Daniel Imms
52a351f8ff Merge pull request #75455 from microsoft/tyriar/75091_default_shell_api 
Implement API to get default shell
 2019-06-14 09:13:28 -07:00
Sandeep Somavarapu
3ccd965ddb Fix #74833 2019-06-14 15:08:45 +02:00
Johannes Rieken
cb865f934a remove extHostHeapService, use normal cache in commands converter, #74846 2019-06-14 13:02:18 +02:00
Johannes Rieken
8e91c0db03 Merge pull request #75461 from microsoft/dev/mjbvz/remote-heap-for-sig-help 
Don't use heap service for signature help
 2019-06-14 12:46:24 +02:00
Benjamin Pasero
c6d9e8ea64 status - push proposed API for statusbar id/name and adopt 2019-06-14 11:52:39 +02:00
Matt Bierner
580bd304c9 Don't use heap service for signature help 
For #74846

Migrates from using the heap service to have an explicit lifecycle
 2019-06-13 17:49:00 -07:00
Matt Bierner
592b91b5cb Use readonly for cache 
This type never modifies the input arrays
 2019-06-13 16:43:09 -07:00
Daniel Imms
976320ddd2 Pass workspace shell permissions to ext host 2019-06-13 15:41:00 -07:00
Daniel Imms
83ba7099ff Default shell API 
Part of #75091
 2019-06-13 15:13:31 -07:00
Matt Bierner
3bb736272e Mark readonly on insertSnippet 
This function does not modify the input array
 2019-06-13 14:11:46 -07:00
Daniel Imms
e3609a9576 Hook up new method 2019-06-12 16:35:29 -07:00
Daniel Imms
86aa7aef36 Allow terminals to launch using clean env on Mac and Linux 
Fixes #70248
 2019-06-12 16:29:02 -07:00
Matt Bierner
a6a376e933 Merge pull request #75092 from microsoft/dev/mjbvz/readonly-diagnostics-api 
Use readonly arrays for the vscode.DiagnosticCollection api
 2019-06-12 14:46:17 -07:00
Matt Bierner
e7a5f9a5e2 Remove the vscode-core-resource scheme 
This is no longer required and complicates loading of resources. Use the standard `vscode-resource` scheme instead
 2019-06-12 11:17:59 -07:00
Johannes Rieken
1ad12b24a6 allow extension resources in editor insets 2019-06-12 18:09:34 +02:00
Sandeep Somavarapu
92fed79878 #74846 Dispose internal commands 2019-06-12 16:49:10 +02:00
Johannes Rieken
34c1f859cf remove gc-signals, heapservice, and mainThreadHeapService, #74846 2019-06-12 16:20:49 +02:00
Joao Moreno
08bb5a13c0 use toInternal2 
related to #74846
 2019-06-12 15:19:44 +02:00
Daniel Imms
a004864bda Finalize TerminalOptions.runInBackground API 
Fixes #75278
 2019-06-11 11:21:02 -07:00
Benjamin Pasero
7bc29bf67c debt - fix command alias (#75242) 2019-06-11 10:02:50 +02:00
Benjamin Pasero
eabd2c51a4 fix #69334 2019-06-11 09:54:48 +02:00
Peng Lyu
63672ffaa7 Merge pull request #74930 from microsoft/rebornix/commentreactions 
Comment Reaction API
 2019-06-10 10:36:21 -07:00
Matt Bierner
1e9fae2fba Partial fix for ExtHost CodeLenses registering commands after they have already been disposed of 
For #75105

This change ensures that we do not try registering a command while resolving a code lens. However it does not fix the issue where we can end up trying to invoke a command that has already been disposed of
 2019-06-07 18:26:19 -07:00
Matt Bierner
8448512143 Use readonly arrays for the vscode.DiagnosticCollection api 
## Problem
The diagnostic collection object is set up so that it does not mutate the arrays of diagnostics you pass to it. It also does not expect or allow mutation of diagnostics that it returns.

However it it currently typed using normal arrays. This means that if an extension (such as JS/TS) wishes to use readonly diagnostics intnernally, it cannot do so without casting.

## Proposed Fix
Use `ReadonlyArray` in diagnostic collection. This should be a safe change for the `set` type methods. The changes to `get` and `forEach` have the risk of breaking the typing of some extensions, but `get` already returned a frozen array of diagnostic so trying to mutate the array itself would have resulted in runtime error.
 2019-06-07 11:41:33 -07:00
Matt Bierner
f8c8531e78 Merge pull request #75048 from mjbvz/add-lifecyle-for-code-actions 
Replace heapservice with lifecycle for code actions
 2019-06-07 10:28:05 -07:00
Johannes Rieken
5f91328fb1 fix layer breaker with credentials service, #74997 2019-06-07 12:02:42 +02:00
Matt Bierner
b4a00ca33f Replacing heapservice with lifecycle for code actions 
Part of #74846

Code Actions can use commands internally, which must be disposed of. We were previously using the heap service for this but this will not work for the web. Add a custom lifecycle instead
 2019-06-06 22:12:56 -07:00
Benjamin Pasero
eddc3f4a23 status - fix empty extension 2019-06-06 18:38:42 +02:00
Johannes Rieken
078da2bca6 This partially reverts "extends Disposable" changes 2019-06-06 16:01:15 +02:00
Johannes Rieken
2cd36100c4 Revert "Update more places where we are using an IDispoable[]" 
This reverts commit 869e5921d8.
 2019-06-06 15:31:23 +02:00
Benjamin Pasero
12fb60ec2e status - make id/name a static thing that cannot change 2019-06-06 10:27:07 +02:00
Benjamin Pasero
8a97df9520 status - change to id/name instead of category 2019-06-06 10:12:27 +02:00
Alex Ross
21a464bc1c Merge branch 'master' into alexr00/terminalExitRace 2019-06-06 09:43:15 +02:00
Alex Ross
2e89762237 Add initial cwd to onProcessReady event 2019-06-06 09:35:27 +02:00
Benjamin Pasero
943b78238b paper cut - offer a menu to control visibility of status bar entries 2019-06-06 07:36:06 +02:00
Peng Lyu
cae0668a0e reactions handler 2019-06-05 21:08:41 -07:00
Matt Bierner
bd39f3d7a1 Revert disposing of emitter change for extHostQuickOpen since it was breaking integration tests 2019-06-05 19:30:04 -07:00
Matt Bierner
a1c5ded681 Remove n-arg version of dispose 
This overload was not heavily used and added complexity
 2019-06-05 15:41:46 -07:00
Matt Bierner
6b7b5c0e0c Extend lifecycle/Disposable in more places instead of re-implementing it 
`lifecycle/Disposable` includes some important fixes that can help catch common programming mistakes
 2019-06-05 15:41:46 -07:00
Matt Bierner
88e7b22359 Use clearer name 2019-06-05 15:41:46 -07:00
Matt Bierner
a6ea8be992 Make sure we dispose of emitters in a few more places 
Emitters should be disposed of properly in order to help prevent leaks
 2019-06-05 15:41:45 -07:00
Matt Bierner
2c8de04126 Fix merge error related to disposables 2019-06-05 15:41:45 -07:00