Commit Graph

138 Commits

Author SHA1 Message Date
Megan Rogge
fc9962bc88 move find out of terminal service and get find to work in terminal editors (#127100) 2021-06-24 22:10:26 +00:00
Daniel Imms
f97906dfb1 Disallow setting active instance to undefined outside services 2021-06-18 13:38:15 -07:00
Daniel Imms
74243095bf Make set active instance a setter 2021-06-18 08:09:08 -07:00
Daniel Imms
1c55ecdcc9 Introduce term instance host interface 2021-06-18 06:58:00 -07:00
meganrogge
377131da05 migrate createTerminal to use CreateTerminalOptions everywhere 2021-06-15 13:26:00 -07:00
Daniel Imms
465759bc58 Prevent other extensions registering terminal profiles 2021-06-11 06:45:36 -07:00
Daniel Imms
5eddbd9d20 Properly support splitting ext profiles 2021-05-26 11:48:32 -07:00
Daniel Imms
bf5f7dd5ec Get split terminals working 2021-05-26 11:34:11 -07:00
Daniel Imms
3ff91e7621 Merge remote-tracking branch 'origin/main' into tyriar/profile_api 2021-05-26 11:09:35 -07:00
Daniel Imms
e29194ad0d Activation event, register api 2021-05-26 07:41:16 -07:00
Daniel Imms
43b7187c3d Force inheritEnv in ext debug terminals
Fixes #124041
2021-05-25 04:55:02 -07:00
Daniel Imms
514d3162bc Persist title source and set after reconnect
Fixes #123783
2021-05-20 11:51:23 -07:00
Daniel Imms
09d22f9bbb Remote ext host ready from terminal service 2021-05-13 05:36:18 -07:00
Daniel Imms
6d70e727d0 Set default profile in exthost from renderer
Fixes #121760
Related microsoft/vscode-python#16175
2021-05-12 17:14:18 -07:00
Daniel Imms
84abba8754 Clean up 2021-05-12 05:37:21 -07:00
Daniel Imms
8e5b3b5aff Merge branch 'main' into hbibkrim/114898_terminal_name_change_event 2021-05-04 08:39:30 -07:00
Daniel Imms
c2f8abb4d2 Remove onRequestDefaultShellAndArgs 2021-05-03 23:01:16 -07:00
Daniel Imms
3ae9ec0051 Adopt requireTrust in terminal 2021-04-16 05:29:28 -07:00
Connor Peet
22dd903084 terminal: fix swapped cols/rows
Fixes #121260
2021-04-14 12:48:23 -07:00
Connor Peet
964ad75846 fix build 2021-04-12 12:41:43 -07:00
Connor Peet
8e183f0d2e terminal: standardize on customPtyImplementation
I initially was doing a larger refactor where the `onInstanceRequestStartExtensionTerminal`
event was removed from the terminalService and instead events would only
be fired in the proxy instance itself, which would be encapsulated better.
However, the task system depends on the global even firing so that the
MainThreadTerminalService can get the terminal for tasks that create
pseudoterminals, so this didn't work out. Kept a more focus refactor
for now.
2021-04-12 11:03:54 -07:00
Daniel Imms
f8810116c6 Add terminal icon ext api
Part of #120538
2021-04-05 02:42:39 -07:00
Daniel Imms
c8ccd07d0f Add initialText proposed API
Part of #120368
2021-04-01 12:27:13 -07:00
Daniel Imms
d0c8b51a83 Merge branch 'main' into hbibkrim/114898_terminal_name_change_event 2021-04-01 08:13:12 -07:00
Daniel Imms
e664085b70 Use optional chaining in MainThreadTerminalService 2021-04-01 07:52:14 -07:00
Daniel Imms
9437d13aa6 Add comment explaining Process->Api event change 2021-04-01 07:44:39 -07:00
Daniel Imms
6751472731 Merge remote-tracking branch 'origin/main' into pr/habibkarim/115276 2021-04-01 07:18:36 -07:00
Megan Rogge
4ccad80121 fix #119322 (#120143) 2021-03-30 09:39:10 -07:00
Daniel Imms
02d3809824 Allow undefined in terminal env map, unify interfaces
Note that this adds undefined as an option to TerminalOptions.env which could end up
causing compile errors, but they will be more correct and could reveal a bug in an
extension since some key could return undefined.

Fixes #119046
2021-03-26 14:40:12 -07:00
Daniel Imms
d02a4aacba Remove quick launch terminology from code
Fixes #119815
2021-03-26 09:56:20 -07:00
Megan Rogge
7a9844238d terminal profile fixes (#119267)
This PR fixes #119200
fixes #119275
fixes #119277
fixes #119283
fixes #119141
2021-03-18 20:16:07 -07:00
Megan Rogge
e8e6d64105 Terminal profiles (#118790)
* get basics working in current dropdown

* filter profiles based on what we want in the dropdown and other info

* add copywright

* terminal.ts -> terminalProfile.ts

* seperate linux distro code

* improve terminalConfig setting description

* add passing tests and fix #79572

* add test for login args

* add wsl stuff

* fix #77652

* lengthen throttle time to 10s

* shell -> process and fire update profiles so dropdown is updated

* consolidate code in terminalProfile

* change profile selection logic

* change profile config structure

* use <ProfileName, IterminalProfileObject> and get wsl distro names to look normal

* provide terminalConfig to terminalProfiles

* move detection/validation to terminalProfiles

* isWorkspaceShellAllowed

* add quickPickOnly so Select Default Profiles returns all and otherwise filters based on config

* Add logs for errors within terminalProfiles

* change return type

* use sync

* fix bug, get custom generated to work

* workspace shell permissions

* add some comments and clean up

* when ext host ready update profiles

* improve terminalProfileObjectEqual check

* don't use windows powershell unless no other powershell
2021-03-16 17:02:59 -07:00
Daniel Imms
a5c28d0ca0 Merge remote-tracking branch 'origin/main' into tyriar/remove_flow_control 2021-03-04 08:02:36 -08:00
meganrogge
ba117e60c2 fix #118043 2021-03-03 16:49:38 -08:00
Megan Rogge
cf3faa4046 Don't relaunch extension owned terminals (#117987)
Co-authored-by: Daniel Imms <daimms@microsoft.com>
2021-03-02 13:55:38 -08:00
Daniel Imms
647773d7e6 Rename terminal id to instance id
Part of #117978
2021-03-02 11:08:12 -08:00
Daniel Imms
a418778243 Merge remote-tracking branch 'origin/main' into tyriar/remove_flow_control 2021-02-26 13:08:09 -08:00
Daniel Imms
91a246998c Remove flow control setting
Flow control is enabled for all non-extension terminals

Fixes #117418
2021-02-26 05:59:58 -08:00
Daniel Imms
df5d7c257d Remove exthost terminal processes
Fixes #116864
2021-02-26 04:35:03 -08:00
Megan Rogge
68a47518f8 move things back to platform and delete duplicate code 2021-02-11 12:19:25 -08:00
Megan Rogge
a35338b250 move things back to the workbench and leave only necessary items in platform 2021-02-11 11:02:03 -08:00
Megan Rogge
da39b7af3e create PersistentTerminalProcess and move terminal and environmentVariable files from workbench -> platform 2021-02-10 15:26:05 -08:00
Daniel Imms
6132a763bc Get one way communication happening 2021-02-09 04:07:38 -08:00
Daniel Imms
456841a93b Create createProcess ipc interface 2021-02-08 12:37:10 -08:00
Habib Karim
3db5cd54e1 Implement Pseudoterminal.onDidChangeName 2021-02-01 00:45:19 +00:00
Megan Rogge
dac8d916d5 fix #110936 2021-01-25 11:21:57 -08:00
Daniel Imms
f8ec60aa06 Add flow control setting, remove fake latency 2021-01-14 06:04:03 -08:00
Daniel Imms
0a19f7702a Rename ackId to charCount 2021-01-12 11:36:21 -08:00
Daniel Imms
bf52d50a0a Remove ackId from data events going to client 2021-01-12 11:27:51 -08:00
Daniel Imms
6430ee1efc Basic flow control for ext host processes
Part of #113827
2021-01-12 09:39:45 -08:00