Commit Graph
594 Commits
Author SHA1 Message Date
Matt Bierner fd245fcda0 Fix method name 2019-06-20 18:13:06 -07:00
Matt Bierner 362ca1d638 Also include format in the syntax commands 2019-06-20 18:01:49 -07:00
Matt Bierner ec191a08f4 Make execute command a configuration object 2019-06-20 18:01:49 -07:00
Matt Bierner 1958209daf Include server id in TS server errors 2019-06-20 18:01:49 -07:00
Matt Bierner 87b8402b59 Add experimental dual TS server
Fixes #75866
2019-06-20 17:11:20 -07:00
Matt Bierner 8ec2559029 Move getQueueingType into class 2019-06-20 17:11:20 -07:00
Matt Bierner 45ea4703c2 Renames 2019-06-20 17:11:20 -07:00
Matt Bierner 4a053c9d6d Extract server spanwer to own file 2019-06-20 17:11:20 -07:00
Matt Bierner ccf4a04d5a extract server error to own file 2019-06-20 17:11:20 -07:00
Matt Bierner 7e1f8d4f1d Extract ITypeScript server interface 2019-06-20 17:11:20 -07:00
Matt Bierner 8b93c01655 Re-queue canceled geterr requests before remaining buffers
We should give higher priority to files that have previously had geterr triggered on them but did not have their request completed
2019-06-20 10:27:36 -07:00
Matt Bierner 459939b905 Provide full TS symbol range when previewing definitions in VSCode
Fixes #72017

Has two fixes:

- Hooks up the JS/TS extension to consume the full symbol range provided by https://github.com/microsoft/TypeScript/pull/31587

- Makes the go the definition mouse implementation use the locationLink to compute the preview range. If a`targetSelectionRange` is provided, this means we use the normal `range` to get the preview range
2019-06-17 15:39:56 -07:00
Matt Bierner e3294dc7b1 Fix exception if extension is not installed 2019-06-14 16:30:05 -07:00
Matt BiernerandGitHub c419355b5b Merge pull request #75375 from microsoft/dev/mjbvz/vscode-api-readonly-events
Mark events as readonly in VS Code api
2019-06-14 11:59:57 -07:00
Benjamin Pasero c6d9e8ea64 status - push proposed API for statusbar id/name and adopt 2019-06-14 11:52:39 +02:00
Andrius 2ac8fbb7d0 notify tsserver about changes in external files. 2019-06-13 19:20:33 +03:00
Matt Bierner b4f6130fe4 Fix some compile errors resutling from readonly change 2019-06-12 16:54:16 -07:00
Matt BiernerandGitHub a6a376e933 Merge pull request #75092 from microsoft/dev/mjbvz/readonly-diagnostics-api
Use readonly arrays for the vscode.DiagnosticCollection api
2019-06-12 14:46:17 -07:00
Matt Bierner 1f4e2a21fc Add support for loading contributed TS version
Fixes https://github.com/microsoft/vscode/issues/75222
Fixes https://github.com/microsoft/TypeScript/issues/31623
2019-06-10 15:42:35 -07:00
Matt Bierner a1c33c6c12 Don't try creating untitled files in a refactoring
Fixes #75132
2019-06-10 11:11:12 -07:00
Matt Bierner 8448512143 Use readonly arrays for the vscode.DiagnosticCollection api
## Problem
The diagnostic collection object is set up so that it does not mutate the arrays of diagnostics you pass to it. It also does not expect or allow mutation of diagnostics that it returns.

However it it currently typed using normal arrays. This means that if an extension (such as JS/TS) wishes to use readonly diagnostics intnernally, it cannot do so without casting.

## Proposed Fix
Use `ReadonlyArray` in diagnostic collection. This should be a safe change for the `set` type methods. The changes to `get` and `forEach` have the risk of breaking the typing of some extensions, but `get` already returned a frozen array of diagnostic so trying to mutate the array itself would have resulted in runtime error.
2019-06-07 11:41:33 -07:00
Matt Bierner dc2245f164 Use readonlyArray for diagnostics 2019-06-07 11:25:16 -07:00
Matt Bierner dc8e21138f Extend disposable 2019-06-07 11:23:14 -07:00
Matt Bierner 69a7b7ef24 Extract areLanguageDiagnosticSettingsEqual 2019-06-07 11:22:06 -07:00
Matt Bierner a87c73527e Remove extra work in DiagnosticSettings ctor
The langauges map is written so that it is lazy. We do not need to pre-populate it
2019-06-07 11:21:22 -07:00
Matt Bierner 5b01e094c2 Use includes instead of indexOf 2019-06-07 11:12:54 -07:00
Matt Bierner 809386b670 Working on getting ts server class in a testable state 2019-06-05 15:41:45 -07:00
Matt Bierner 76e774e4bd Add arrays.empty
This helps with `a === b` checks  in arrays.equals
2019-05-30 17:22:38 -07:00
Matt Bierner 015f1c7909 Use array prototype instead of creating instance 2019-05-30 17:13:10 -07:00
Matt Bierner a8a0fa763f Use every for equals 2019-05-30 17:01:10 -07:00
Matt Bierner 55d6317a4f Don't update js/ts diagnostics if they have not changed
Fixes #74633

This was the indirect cause of  #74633. See that issue for an explaination of why it was problematic.  In summary, updating diagnostics can retrigger code actions even if the user facing diagnostics have not actually changed
2019-05-30 16:59:32 -07:00
Matt Bierner c62a6aa38a Set extract kind for type alias refactoring
This lets you set up a single keybinding that applies to both extract constant and extract type
2019-05-29 14:22:45 -07:00
Matt Bierner a9e31b19d7 Make sure we don't de-prioritize this. member suggestions
Fixes #74164
2019-05-23 16:06:34 -07:00
Matt Bierner a4532de9af Make sure we reset editors being iterations of test 2019-05-23 16:06:34 -07:00
Matt Bierner 1db653c59e Simplify setting of preselect and sort text 2019-05-22 15:25:48 -07:00
Howard Hung 4582ec149c Fix typo: assigments -> assignments 2019-05-22 01:23:12 +08:00
Khaja NizamuddinandAlex Ross 36e7f1871a Normalize tsconfig path (#73001)
Fixes #68812
2019-05-21 04:01:54 -07:00
Matt Bierner b1aad4b755 Supress potential null errors related to updated @types/node 2019-05-17 16:14:49 -07:00
Matt Bierner 12cf3eb0f8 Pick up latest TS@next 2019-05-17 13:39:55 -07:00
Logan RamosandGitHub ca9887459b Delete vscode-typescript upon close of VS Code (#73801)
* Cleans up vs-typescript temp directoy upon VS code close

* Fixed typing errors preventing build from succeeding

* Moved deletion to the deactivate method. Added folders per extension host

* Removed yarn watch script used in testing
2019-05-17 18:55:31 +00:00
Matt Bierner fd1ac7561b Fix TS 3.5 compile errors
Fixing errors related to https://github.com/microsoft/TypeScript/issues/31380
2019-05-13 18:00:52 -07:00
Matt BiernerandGitHub 60cd4bd73b Merge pull request #73132 from hwhung0111/Fix
Fix two typos
2019-05-10 16:25:49 -07:00
kieferrm c87ce98c9c fix gdpr annotation 2019-05-01 17:24:00 +00:00
Howard Hung 778b92f459 Fix typo in functionCallSnippet.test.ts 2019-05-01 23:35:02 +08:00
Matt Bierner 017a497259 spell 2019-04-24 11:01:35 -07:00
Matt Bierner 24ff03f627 Pick up ts 3.4.5 2019-04-23 10:50:51 -07:00
Matt Bierner f56b18a9f7 Pass validateDefaultNpmLocation to ts 3.4.4
https://github.com/Microsoft/TypeScript/pull/30910/
2019-04-22 11:44:16 -07:00
Matt Bierner a538f095af Organize imports should interupt geterr
UI operations like organize imports have higher priority than geterr
2019-04-22 11:44:16 -07:00
Matt BiernerandGitHub 16944f3c4a Merge pull request #72553 from tony-xia/makeRandomHexString
Update makeRandomHexString() to remove duplicate character
2019-04-22 10:57:16 -07:00
Tony Xia 697c8901a9 Update makeRandomHexString() to remove duplicate character 2019-04-18 23:20:45 +10:00