* Fix some always true/false errors in codebase
Testing out latest TS nightly that can identify when an expression is always true/false. This caught a few likely coding mistakes in our codebase
Unsure about the intent in some of these cases but I've tried my best to understand them. Pinging relevant code owners for the confusing cases
* Bump TS version
* Fix unreachable in build scripts
* Bump versions
* restore intent
* Revert package.json change
* Fixing a few new layer checker errors
These are global in node now
* Skip lib check in integration project
* One more skiplibcheck
* More skip lib
---------
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
* profiles editor feedback
* more polish
* fix margin
* fix outline
* fix hc theme styleing
* Show new profile action in open profile menu
* update options on name change
* don't dimiss inline chat content widget when already having typed something
https://github.com/microsoft/vscode-copilot/issues/6067
* extract `TextOnlyMenuEntryActionViewItem` for reuse
* remove unused variables
* * show chat input below request/response pairs
* setting for text-only buttons
* more dynamic buttons
* always show the first request, don't repopulate input with last message
* keep progress bar hidden, rely on "Generating..."
* no more special background color
* add `minimal` renderer style for chat renderings
* tweak font-size for details when render mode is minimal
* stable scroll position for inline chat, don't push down the lines chat is editing but push the inline chat upwards
* more buttons more compact, tweak labels
* * add missing service dependency
* repopulate input for some unit test
* allow output from `InteractiveChatController` suite
* Tabs Multi Select v1
* Color
* Only rerender selections
* Improve drag and drop and tab border top drawing
* Improved multi select behaviour
* Open With Editor multiple "support"
* 💄
* tests
* Move down to model
* Fix tests
* Sync selection and active in model
* Make unselect async
* async unselect in interface
* Model update event when unselecting with closeEditor
* async fir selectEditor
* Fix tests and 💄
For /fixTestFailures, I want to get more 'real world' tests and test
fixes. This makes a change in the selfhost test provider such that when
a test fails and is then fixed, we record the code changes into a JSON
file in the `.build` directory. In a few days I'll follow up with team
members to collect their test failures and use them as evaluation tests
for copilot. The FailureTracker will be removed when I've gotten enough
data.
The typescript-formatter package isn't being maintained (lots of old PRs) and has broken in the most recent version of TS
Long term we may explore switching to another formatter, but for now I've hook up the basic formatter logic for our hygiene scripts
* theme: fix unthemable icons in several areas
We manually used icon characters in several areas. These are/were entire unthemable. Fixing this required people to manually listen to the theme service and apply rules to their elements when icons change. This PRs adds theme variables that people can use instead.
Fixes#208343
* implement review comments
* fix font-family variable
---------
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
