mirror of
https://github.com/microsoft/vscode.git
synced 2026-07-02 20:46:18 +01:00
Josh Spicer
35054242b4
* Document GitHub Copilot managed settings in add-policy skill Add a github-managed-settings.md sub-file covering the new enterprise managed-settings modality (native MDM / file / GitHub server -> the canonical IPolicyData.managedSettings bag) and the policyReference mechanism (one policy governing many settings). Update SKILL.md to link the sub-file and refresh the policy-sources and key-files tables. Grounded in PRs #318623, #320991, #321218, #321515. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Tighten managed-settings skill after council fact-check Cross-checked every claim against the source and the four PRs: - Correct the channel count: VS Code feeds the bag from native MDM + server endpoint only; managed-settings.json is external-schema-only and not read by VS Code. - Fix "JSON.parse" -> PolicyConfiguration.parse() (lenient JSONC visitor). - Quote ManagedSettingValue verbatim (= PolicyValue). - Clarify native MDM is a separate input merged in getPolicyData, not on policyData; document MDM-wins merge order precisely. - Note schema is nested vs the flattened bag key; add the extraKnownMarketplaces github/git-only divergence alongside the strict boolean one. - Soften the catalog claim: referencedSettings only captures references loaded at export time (sessions Claude ref absent from policyData.jsonc). - Fix example file path (chat.shared.contribution.ts) and restore the chat_preview_features_enabled OR in the ChatToolsAutoApprove sample. - Make the main.ts wiring snippet match the real two-step structure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address PR review: annotate example minimumVersion values Mark the concrete minimumVersion values in example blocks as historical values transcribed from existing policies, with an inline note that new policies derive minimumVersion from package.json major.minor (Step 1). The file-based-channel and JSON.parse review comments were already resolved in the prior council-fix commit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clarify policy multiplexing in add-policy skill After another pass through the policy wiring, clarify that MultiplexPolicyService is used in two places: main-process OS/file policy reader multiplexing, and renderer/session multiplexing of the main policy channel with AccountPolicyService. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Promote policyReference guidance to main add-policy skill policyReference is a general policy mechanism, not specific to Copilot managed settings. Make the main SKILL.md section self-contained with the owner/reference model, validation rules, export behavior, IPC-safe serialization, and diagnostics notes. Keep the managed-settings sub-file as a cross-reference only for managed-settings-specific examples. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>