mirror of
https://github.com/microsoft/vscode.git
synced 2026-07-09 00:05:28 +01:00
Sandeep Somavarapu
97eab22fc9
Commit c385fd3 introduced IAgentSessionsService.model.observeSession(...)
calls into the provider-agnostic sessions workbench (sessionsList renderer
and the visible-sessions grid) for lazy loading. IAgentSessionsService is a
Copilot-provider internal and must only be consumed by the Copilot chat
sessions provider.
Revert those observeSession triggers and the IAgentSessionsService
dependency from sessionsList.ts and visibleSessions.ts, and update the
affected tests to assert on provider-agnostic signals (open-promise
resolution / visibleSessions) instead of observation. Remove the now
vestigial IAgentSessionsService stub from the agent feedback test.
To prevent recurrence, add an ESLint no-restricted-imports ban on
**/agentSessions/agentSessionsService scoped to src/vs/sessions/** (the
Copilot provider folder is exempted), and document the rule in SESSIONS.md
and the sessions skill.
Follow-up for re-implementing lazy loading correctly: #320480
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>