mirror of
https://github.com/microsoft/vscode.git
synced 2026-09-30 18:46:00 +01:00
301c31b679
* feat: add connected tabs support with custom styling and layout adjustments * style: adjust connected tab styles and add tests for stroke behavior * feat: introduce connected editor tab style with customizable border * feat: enhance connected editor tabs with clipping and overflow handling - Added functionality to manage connected tab clipping and overflow edges in MultiEditorTabsControl. - Introduced new CSS styles for connected editor tabs to improve visual consistency and interaction. - Updated tests to validate the behavior of connected tabs, including clipping and overflow scenarios. - Refactored tab rendering logic to accommodate new connected tab features and ensure proper layout. * feat: enhance connected tab behavior with left-shoulder clipping and update tests * feat: implement connected tab layout invalidation and enhance test coverage for connected tabs * feat: enhance connected tab layout and alignment with auxiliary window support * feat: refactor connected tab styling and update related tests for improved surface handling * feat: implement connected tab theming participant and update color variable handling for improved UI consistency * feat: strengthen connected editor tab hierarchy Align the selected tab with the editor surface, move the remaining strip to the editor header background, and remove gutters at tab and row boundaries. This makes the active document well unambiguous and follows the adjacency treatment from Visual Studio and Edge.\n\nRefs #331104 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * style: connect editor tabs across the full strip Remove the shared pill gutters from connected editor tabs so active and inactive fills align with every strip boundary. Preserve row-specific spacing for wrapped and separate pinned rows, and keep the active surface overlapping the document well by one stroke. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat: refine connected document tab geometry and readability Preserve filename identity and recover icons under compression, keep wrapped row heights consistent, and join the selected tab to a single HC document-well outline. Refine default strip palettes and cover bundled themes and viewport-edge states.\n\nRefs #331104 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: preserve connected tab selection and HC editor frames Use native scroll coordinates after tab removal clamps the viewport. Suppress the HC editor card only when the effective editor part options show multiple tabs, preserving single and hidden-tab frames. Refs #331104 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address connected tab review feedback Distinguish active multi-selection in high contrast with an inset stroke that stays inside the tab strip. Restore explicit pill-color fixtures and test intrinsic content-only badge sizing. Refs #331104 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: isolate component fixture styles by theme identity Prevent additional tab themes from leaking colors into later fixtures sharing the same light or dark scheme. Cover theming participants and nested editor variables in both installation orders; retain the existing screenshot baselines. Refs #335605 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: refresh baselines after fixture theme isolation Verify workbench-only theming does not paint nested editor scrollers. Accept 30 visually reviewed Ubuntu baselines that remove the old fixture-only background artifacts; the original Solarized contamination remains rejected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: load editor styles in fixture isolation regression The full test suite loads Monaco CSS, so editor roots correctly use the editor background rather than transparency. Load those styles explicitly and use distinct workbench/editor colors to keep the regression independent of test discovery order while still checking nested scrollers remain transparent. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: improve Quiet Light document tab contrast Separate the inactive strip from the selected document surface while preserving readable inactive, hover, and warning labels. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: retain Dark Modern tab coverage after rebase Keep an explicit Dark Modern fixture variant now that upstream uses Dark 2026 for the default Dark fixture. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address connected tab review feedback Use the existing editor frame color variable without escalating the cascade, and cover floating and non-floating HC layouts. Remove the duplicated Dark 2026 fixture while retaining all fifteen distinct themes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: fully reveal connected tab left shoulders Budget both connected shoulders using outward-rounded bounds when checking whether a tab fits. Preserve the flush first-tab and row-start exception. Cover leftward reveal, narrow fitting tabs, oversized tabs and first-tab alignment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: only protect resource-backed tab extensions Keep arbitrary dotted editor titles in the ellipsizing name container instead of interpreting their trailing text as a file extension. Preserve actual filename extensions and full accessible names, including dotfiles and resource-less titles. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: refresh isolated fixture theme baselines Update the 21 CI-provided hashes reviewed against old/new images. Theme isolation corrects response/input backgrounds and corner blending without changing dimensions or layout. All2161 fixtures rendered successfully and43 Playwright tests passed in the source-head run. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: preserve fixture scopes after upstream rebase Keep upstream nested-root color variable handling while limiting workbench theming participants to their fixture root. Adapt isolation regressions and restore two inline-chat baselines to verified upstream values. Validated 104 targeted tests and 33 connected fixture checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: remove duplicate theme import after rebase Retain upstream's Light 2026 import and remove the duplicate introduced by replaying the theme-gallery commit. Client type checking passes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: unify connected tab hover surfaces and address review feedback Keep upper-row action masks on the pill hover surface, preserve high-contrast empty and sticky boundaries, and correct row-end and sticky layering. Preserve complete initial filename graphemes and suffix styling, and prevent hidden close slots from intercepting pointer input. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>