mirror of
https://github.com/microsoft/vscode.git
synced 2026-05-23 00:29:35 +01:00
4600d99b2b
* Improve Configure Keybindings Support * fix test
446 lines
17 KiB
TypeScript
446 lines
17 KiB
TypeScript
/*---------------------------------------------------------------------------------------------
|
|
* Copyright (c) Microsoft Corporation. All rights reserved.
|
|
* Licensed under the MIT License. See License.txt in the project root for license information.
|
|
*--------------------------------------------------------------------------------------------*/
|
|
|
|
import { WorkbenchActionExecutedClassification, WorkbenchActionExecutedEvent } from 'vs/base/common/actions';
|
|
import { CancellationToken } from 'vs/base/common/cancellation';
|
|
import { toErrorMessage } from 'vs/base/common/errorMessage';
|
|
import { isCancellationError } from 'vs/base/common/errors';
|
|
import { matchesContiguousSubString, matchesPrefix, matchesWords, or } from 'vs/base/common/filters';
|
|
import { createSingleCallFunction } from 'vs/base/common/functional';
|
|
import { Disposable, DisposableStore, IDisposable } from 'vs/base/common/lifecycle';
|
|
import { LRUCache } from 'vs/base/common/map';
|
|
import { TfIdfCalculator, normalizeTfIdfScores } from 'vs/base/common/tfIdf';
|
|
import { localize } from 'vs/nls';
|
|
import { ILocalizedString } from 'vs/platform/action/common/action';
|
|
import { ICommandService } from 'vs/platform/commands/common/commands';
|
|
import { IConfigurationChangeEvent, IConfigurationService } from 'vs/platform/configuration/common/configuration';
|
|
import { IDialogService } from 'vs/platform/dialogs/common/dialogs';
|
|
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
|
|
import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
|
|
import { ILogService } from 'vs/platform/log/common/log';
|
|
import { FastAndSlowPicks, IPickerQuickAccessItem, IPickerQuickAccessProviderOptions, PickerQuickAccessProvider, Picks } from 'vs/platform/quickinput/browser/pickerQuickAccess';
|
|
import { IQuickAccessProviderRunOptions } from 'vs/platform/quickinput/common/quickAccess';
|
|
import { IQuickPickSeparator } from 'vs/platform/quickinput/common/quickInput';
|
|
import { IStorageService, StorageScope, StorageTarget, WillSaveStateReason } from 'vs/platform/storage/common/storage';
|
|
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
|
|
|
|
export interface ICommandQuickPick extends IPickerQuickAccessItem {
|
|
readonly commandId: string;
|
|
readonly commandWhen?: string;
|
|
readonly commandAlias?: string;
|
|
readonly commandDescription?: ILocalizedString;
|
|
tfIdfScore?: number;
|
|
readonly args?: any[];
|
|
}
|
|
|
|
export interface ICommandsQuickAccessOptions extends IPickerQuickAccessProviderOptions<ICommandQuickPick> {
|
|
readonly showAlias: boolean;
|
|
suggestedCommandIds?: Set<string>;
|
|
}
|
|
|
|
export abstract class AbstractCommandsQuickAccessProvider extends PickerQuickAccessProvider<ICommandQuickPick> implements IDisposable {
|
|
|
|
static PREFIX = '>';
|
|
|
|
private static readonly TFIDF_THRESHOLD = 0.5;
|
|
private static readonly TFIDF_MAX_RESULTS = 5;
|
|
|
|
private static WORD_FILTER = or(matchesPrefix, matchesWords, matchesContiguousSubString);
|
|
|
|
private readonly commandsHistory = this._register(this.instantiationService.createInstance(CommandsHistory));
|
|
|
|
protected override readonly options: ICommandsQuickAccessOptions;
|
|
|
|
constructor(
|
|
options: ICommandsQuickAccessOptions,
|
|
@IInstantiationService private readonly instantiationService: IInstantiationService,
|
|
@IKeybindingService protected readonly keybindingService: IKeybindingService,
|
|
@ICommandService private readonly commandService: ICommandService,
|
|
@ITelemetryService private readonly telemetryService: ITelemetryService,
|
|
@IDialogService private readonly dialogService: IDialogService
|
|
) {
|
|
super(AbstractCommandsQuickAccessProvider.PREFIX, options);
|
|
|
|
this.options = options;
|
|
}
|
|
|
|
protected async _getPicks(filter: string, _disposables: DisposableStore, token: CancellationToken, runOptions?: IQuickAccessProviderRunOptions): Promise<Picks<ICommandQuickPick> | FastAndSlowPicks<ICommandQuickPick>> {
|
|
|
|
// Ask subclass for all command picks
|
|
const allCommandPicks = await this.getCommandPicks(token);
|
|
|
|
if (token.isCancellationRequested) {
|
|
return [];
|
|
}
|
|
|
|
const runTfidf = createSingleCallFunction(() => {
|
|
const tfidf = new TfIdfCalculator();
|
|
tfidf.updateDocuments(allCommandPicks.map(commandPick => ({
|
|
key: commandPick.commandId,
|
|
textChunks: [this.getTfIdfChunk(commandPick)]
|
|
})));
|
|
const result = tfidf.calculateScores(filter, token);
|
|
|
|
return normalizeTfIdfScores(result)
|
|
.filter(score => score.score > AbstractCommandsQuickAccessProvider.TFIDF_THRESHOLD)
|
|
.slice(0, AbstractCommandsQuickAccessProvider.TFIDF_MAX_RESULTS);
|
|
});
|
|
|
|
// Filter
|
|
const filteredCommandPicks: ICommandQuickPick[] = [];
|
|
for (const commandPick of allCommandPicks) {
|
|
const labelHighlights = AbstractCommandsQuickAccessProvider.WORD_FILTER(filter, commandPick.label) ?? undefined;
|
|
const aliasHighlights = commandPick.commandAlias ? AbstractCommandsQuickAccessProvider.WORD_FILTER(filter, commandPick.commandAlias) ?? undefined : undefined;
|
|
|
|
// Add if matching in label or alias
|
|
if (labelHighlights || aliasHighlights) {
|
|
commandPick.highlights = {
|
|
label: labelHighlights,
|
|
detail: this.options.showAlias ? aliasHighlights : undefined
|
|
};
|
|
|
|
filteredCommandPicks.push(commandPick);
|
|
}
|
|
|
|
// Also add if we have a 100% command ID match
|
|
else if (filter === commandPick.commandId) {
|
|
filteredCommandPicks.push(commandPick);
|
|
}
|
|
|
|
// Handle tf-idf scoring for the rest if there's a filter
|
|
else if (filter.length >= 3) {
|
|
const tfidf = runTfidf();
|
|
if (token.isCancellationRequested) {
|
|
return [];
|
|
}
|
|
|
|
// Add if we have a tf-idf score
|
|
const tfidfScore = tfidf.find(score => score.key === commandPick.commandId);
|
|
if (tfidfScore) {
|
|
commandPick.tfIdfScore = tfidfScore.score;
|
|
filteredCommandPicks.push(commandPick);
|
|
}
|
|
}
|
|
}
|
|
|
|
// Add description to commands that have duplicate labels
|
|
const mapLabelToCommand = new Map<string, ICommandQuickPick>();
|
|
for (const commandPick of filteredCommandPicks) {
|
|
const existingCommandForLabel = mapLabelToCommand.get(commandPick.label);
|
|
if (existingCommandForLabel) {
|
|
commandPick.description = commandPick.commandId;
|
|
existingCommandForLabel.description = existingCommandForLabel.commandId;
|
|
} else {
|
|
mapLabelToCommand.set(commandPick.label, commandPick);
|
|
}
|
|
}
|
|
|
|
// Sort by MRU order and fallback to name otherwise
|
|
filteredCommandPicks.sort((commandPickA, commandPickB) => {
|
|
// If a result came from tf-idf, we want to put that towards the bottom
|
|
if (commandPickA.tfIdfScore && commandPickB.tfIdfScore) {
|
|
if (commandPickA.tfIdfScore === commandPickB.tfIdfScore) {
|
|
return commandPickA.label.localeCompare(commandPickB.label); // prefer lexicographically smaller command
|
|
}
|
|
return commandPickB.tfIdfScore - commandPickA.tfIdfScore; // prefer higher tf-idf score
|
|
} else if (commandPickA.tfIdfScore) {
|
|
return 1; // first command has a score but other doesn't so other wins
|
|
} else if (commandPickB.tfIdfScore) {
|
|
return -1; // other command has a score but first doesn't so first wins
|
|
}
|
|
|
|
const commandACounter = this.commandsHistory.peek(commandPickA.commandId);
|
|
const commandBCounter = this.commandsHistory.peek(commandPickB.commandId);
|
|
|
|
if (commandACounter && commandBCounter) {
|
|
return commandACounter > commandBCounter ? -1 : 1; // use more recently used command before older
|
|
}
|
|
|
|
if (commandACounter) {
|
|
return -1; // first command was used, so it wins over the non used one
|
|
}
|
|
|
|
if (commandBCounter) {
|
|
return 1; // other command was used so it wins over the command
|
|
}
|
|
|
|
if (this.options.suggestedCommandIds) {
|
|
const commandASuggestion = this.options.suggestedCommandIds.has(commandPickA.commandId);
|
|
const commandBSuggestion = this.options.suggestedCommandIds.has(commandPickB.commandId);
|
|
if (commandASuggestion && commandBSuggestion) {
|
|
return 0; // honor the order of the array
|
|
}
|
|
|
|
if (commandASuggestion) {
|
|
return -1; // first command was suggested, so it wins over the non suggested one
|
|
}
|
|
|
|
if (commandBSuggestion) {
|
|
return 1; // other command was suggested so it wins over the command
|
|
}
|
|
}
|
|
|
|
// both commands were never used, so we sort by name
|
|
return commandPickA.label.localeCompare(commandPickB.label);
|
|
});
|
|
|
|
const commandPicks: Array<ICommandQuickPick | IQuickPickSeparator> = [];
|
|
|
|
let addOtherSeparator = false;
|
|
let addSuggestedSeparator = true;
|
|
let addCommonlyUsedSeparator = !!this.options.suggestedCommandIds;
|
|
for (let i = 0; i < filteredCommandPicks.length; i++) {
|
|
const commandPick = filteredCommandPicks[i];
|
|
|
|
// Separator: recently used
|
|
if (i === 0 && this.commandsHistory.peek(commandPick.commandId)) {
|
|
commandPicks.push({ type: 'separator', label: localize('recentlyUsed', "recently used") });
|
|
addOtherSeparator = true;
|
|
}
|
|
|
|
if (addSuggestedSeparator && commandPick.tfIdfScore !== undefined) {
|
|
commandPicks.push({ type: 'separator', label: localize('suggested', "similar commands") });
|
|
addSuggestedSeparator = false;
|
|
}
|
|
|
|
// Separator: commonly used
|
|
if (addCommonlyUsedSeparator && commandPick.tfIdfScore === undefined && !this.commandsHistory.peek(commandPick.commandId) && this.options.suggestedCommandIds?.has(commandPick.commandId)) {
|
|
commandPicks.push({ type: 'separator', label: localize('commonlyUsed', "commonly used") });
|
|
addOtherSeparator = true;
|
|
addCommonlyUsedSeparator = false;
|
|
}
|
|
|
|
// Separator: other commands
|
|
if (addOtherSeparator && commandPick.tfIdfScore === undefined && !this.commandsHistory.peek(commandPick.commandId) && !this.options.suggestedCommandIds?.has(commandPick.commandId)) {
|
|
commandPicks.push({ type: 'separator', label: localize('morecCommands', "other commands") });
|
|
addOtherSeparator = false;
|
|
}
|
|
|
|
// Command
|
|
commandPicks.push(this.toCommandPick(commandPick, runOptions));
|
|
}
|
|
|
|
if (!this.hasAdditionalCommandPicks(filter, token)) {
|
|
return commandPicks;
|
|
}
|
|
|
|
return {
|
|
picks: commandPicks,
|
|
additionalPicks: (async (): Promise<Picks<ICommandQuickPick>> => {
|
|
const additionalCommandPicks = await this.getAdditionalCommandPicks(allCommandPicks, filteredCommandPicks, filter, token);
|
|
if (token.isCancellationRequested) {
|
|
return [];
|
|
}
|
|
|
|
const commandPicks: Array<ICommandQuickPick | IQuickPickSeparator> = additionalCommandPicks.map(commandPick => this.toCommandPick(commandPick, runOptions));
|
|
// Basically, if we haven't already added a separator, we add one before the additional picks so long
|
|
// as one hasn't been added to the start of the array.
|
|
if (addSuggestedSeparator && commandPicks[0]?.type !== 'separator') {
|
|
commandPicks.unshift({ type: 'separator', label: localize('suggested', "similar commands") });
|
|
}
|
|
return commandPicks;
|
|
})()
|
|
};
|
|
}
|
|
|
|
private toCommandPick(commandPick: ICommandQuickPick | IQuickPickSeparator, runOptions?: IQuickAccessProviderRunOptions): ICommandQuickPick | IQuickPickSeparator {
|
|
if (commandPick.type === 'separator') {
|
|
return commandPick;
|
|
}
|
|
|
|
const keybinding = this.keybindingService.lookupKeybinding(commandPick.commandId);
|
|
const ariaLabel = keybinding ?
|
|
localize('commandPickAriaLabelWithKeybinding', "{0}, {1}", commandPick.label, keybinding.getAriaLabel()) :
|
|
commandPick.label;
|
|
|
|
return {
|
|
...commandPick,
|
|
ariaLabel,
|
|
detail: this.options.showAlias && commandPick.commandAlias !== commandPick.label ? commandPick.commandAlias : undefined,
|
|
keybinding,
|
|
accept: async () => {
|
|
|
|
// Add to history
|
|
this.commandsHistory.push(commandPick.commandId);
|
|
|
|
// Telementry
|
|
this.telemetryService.publicLog2<WorkbenchActionExecutedEvent, WorkbenchActionExecutedClassification>('workbenchActionExecuted', {
|
|
id: commandPick.commandId,
|
|
from: runOptions?.from ?? 'quick open'
|
|
});
|
|
|
|
// Run
|
|
try {
|
|
commandPick.args?.length
|
|
? await this.commandService.executeCommand(commandPick.commandId, ...commandPick.args)
|
|
: await this.commandService.executeCommand(commandPick.commandId);
|
|
} catch (error) {
|
|
if (!isCancellationError(error)) {
|
|
this.dialogService.error(localize('canNotRun', "Command '{0}' resulted in an error", commandPick.label), toErrorMessage(error));
|
|
}
|
|
}
|
|
}
|
|
};
|
|
}
|
|
|
|
// TF-IDF string to be indexed
|
|
private getTfIdfChunk({ label, commandAlias, commandDescription }: ICommandQuickPick) {
|
|
let chunk = label;
|
|
if (commandAlias && commandAlias !== label) {
|
|
chunk += ` - ${commandAlias}`;
|
|
}
|
|
if (commandDescription && commandDescription.value !== label) {
|
|
// If the original is the same as the value, don't add it
|
|
chunk += ` - ${commandDescription.value === commandDescription.original ? commandDescription.value : `${commandDescription.value} (${commandDescription.original})`}`;
|
|
}
|
|
return chunk;
|
|
}
|
|
|
|
protected abstract getCommandPicks(token: CancellationToken): Promise<Array<ICommandQuickPick>>;
|
|
|
|
protected abstract hasAdditionalCommandPicks(filter: string, token: CancellationToken): boolean;
|
|
protected abstract getAdditionalCommandPicks(allPicks: ICommandQuickPick[], picksSoFar: ICommandQuickPick[], filter: string, token: CancellationToken): Promise<Array<ICommandQuickPick | IQuickPickSeparator>>;
|
|
}
|
|
|
|
interface ISerializedCommandHistory {
|
|
readonly usesLRU?: boolean;
|
|
readonly entries: { key: string; value: number }[];
|
|
}
|
|
|
|
interface ICommandsQuickAccessConfiguration {
|
|
readonly workbench: {
|
|
readonly commandPalette: {
|
|
readonly history: number;
|
|
readonly preserveInput: boolean;
|
|
};
|
|
};
|
|
}
|
|
|
|
export class CommandsHistory extends Disposable {
|
|
|
|
static readonly DEFAULT_COMMANDS_HISTORY_LENGTH = 50;
|
|
|
|
private static readonly PREF_KEY_CACHE = 'commandPalette.mru.cache';
|
|
private static readonly PREF_KEY_COUNTER = 'commandPalette.mru.counter';
|
|
|
|
private static cache: LRUCache<string, number> | undefined;
|
|
private static counter = 1;
|
|
private static hasChanges = false;
|
|
|
|
private configuredCommandsHistoryLength = 0;
|
|
|
|
constructor(
|
|
@IStorageService private readonly storageService: IStorageService,
|
|
@IConfigurationService private readonly configurationService: IConfigurationService,
|
|
@ILogService private readonly logService: ILogService
|
|
) {
|
|
super();
|
|
|
|
this.updateConfiguration();
|
|
this.load();
|
|
|
|
this.registerListeners();
|
|
}
|
|
|
|
private registerListeners(): void {
|
|
this._register(this.configurationService.onDidChangeConfiguration(e => this.updateConfiguration(e)));
|
|
this._register(this.storageService.onWillSaveState(e => {
|
|
if (e.reason === WillSaveStateReason.SHUTDOWN) {
|
|
// Commands history is very dynamic and so we limit impact
|
|
// on storage to only save on shutdown. This helps reduce
|
|
// the overhead of syncing this data across machines.
|
|
this.saveState();
|
|
}
|
|
}));
|
|
}
|
|
|
|
private updateConfiguration(e?: IConfigurationChangeEvent): void {
|
|
if (e && !e.affectsConfiguration('workbench.commandPalette.history')) {
|
|
return;
|
|
}
|
|
|
|
this.configuredCommandsHistoryLength = CommandsHistory.getConfiguredCommandHistoryLength(this.configurationService);
|
|
|
|
if (CommandsHistory.cache && CommandsHistory.cache.limit !== this.configuredCommandsHistoryLength) {
|
|
CommandsHistory.cache.limit = this.configuredCommandsHistoryLength;
|
|
CommandsHistory.hasChanges = true;
|
|
}
|
|
}
|
|
|
|
private load(): void {
|
|
const raw = this.storageService.get(CommandsHistory.PREF_KEY_CACHE, StorageScope.PROFILE);
|
|
let serializedCache: ISerializedCommandHistory | undefined;
|
|
if (raw) {
|
|
try {
|
|
serializedCache = JSON.parse(raw);
|
|
} catch (error) {
|
|
this.logService.error(`[CommandsHistory] invalid data: ${error}`);
|
|
}
|
|
}
|
|
|
|
const cache = CommandsHistory.cache = new LRUCache<string, number>(this.configuredCommandsHistoryLength, 1);
|
|
if (serializedCache) {
|
|
let entries: { key: string; value: number }[];
|
|
if (serializedCache.usesLRU) {
|
|
entries = serializedCache.entries;
|
|
} else {
|
|
entries = serializedCache.entries.sort((a, b) => a.value - b.value);
|
|
}
|
|
entries.forEach(entry => cache.set(entry.key, entry.value));
|
|
}
|
|
|
|
CommandsHistory.counter = this.storageService.getNumber(CommandsHistory.PREF_KEY_COUNTER, StorageScope.PROFILE, CommandsHistory.counter);
|
|
}
|
|
|
|
push(commandId: string): void {
|
|
if (!CommandsHistory.cache) {
|
|
return;
|
|
}
|
|
|
|
CommandsHistory.cache.set(commandId, CommandsHistory.counter++); // set counter to command
|
|
CommandsHistory.hasChanges = true;
|
|
}
|
|
|
|
peek(commandId: string): number | undefined {
|
|
return CommandsHistory.cache?.peek(commandId);
|
|
}
|
|
|
|
private saveState(): void {
|
|
if (!CommandsHistory.cache) {
|
|
return;
|
|
}
|
|
|
|
if (!CommandsHistory.hasChanges) {
|
|
return;
|
|
}
|
|
|
|
const serializedCache: ISerializedCommandHistory = { usesLRU: true, entries: [] };
|
|
CommandsHistory.cache.forEach((value, key) => serializedCache.entries.push({ key, value }));
|
|
|
|
this.storageService.store(CommandsHistory.PREF_KEY_CACHE, JSON.stringify(serializedCache), StorageScope.PROFILE, StorageTarget.USER);
|
|
this.storageService.store(CommandsHistory.PREF_KEY_COUNTER, CommandsHistory.counter, StorageScope.PROFILE, StorageTarget.USER);
|
|
CommandsHistory.hasChanges = false;
|
|
}
|
|
|
|
static getConfiguredCommandHistoryLength(configurationService: IConfigurationService): number {
|
|
const config = <ICommandsQuickAccessConfiguration>configurationService.getValue();
|
|
|
|
const configuredCommandHistoryLength = config.workbench?.commandPalette?.history;
|
|
if (typeof configuredCommandHistoryLength === 'number') {
|
|
return configuredCommandHistoryLength;
|
|
}
|
|
|
|
return CommandsHistory.DEFAULT_COMMANDS_HISTORY_LENGTH;
|
|
}
|
|
|
|
static clearHistory(configurationService: IConfigurationService, storageService: IStorageService): void {
|
|
const commandHistoryLength = CommandsHistory.getConfiguredCommandHistoryLength(configurationService);
|
|
CommandsHistory.cache = new LRUCache<string, number>(commandHistoryLength);
|
|
CommandsHistory.counter = 1;
|
|
|
|
CommandsHistory.hasChanges = true;
|
|
}
|
|
}
|