Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-06 05:38:13 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
5ff54cc2d00a12e8c9dcff010a494f44269d87fa
vscode/.github/CODENOTIFY
T
Bryan ChenandCopilot 4b5f3abeb4 Move the scenario runner out of the MCP server (#331862) 
* Move the scenario runner out of the MCP server

The validate-ui-scenario skill runs `runScenario`, which drives VS Code through
`test/automation` and writes an evidence bundle. None of that is MCP: the runner
loads no MCP module at runtime, and the SDK import it inherited was type-only, so
TypeScript already elided it. It only lived under `test/mcp` because that is where
the evidence pipeline was first written.

That matters now: deleting the MCP server would take the skill with it.

Move the six files that have nothing to do with MCP into a new `test/scenario`
package, and leave `test/mcp` as one of its consumers alongside the skill. The MCP
evidence tools move to `test/mcp/src/evidenceTools.ts`, where the server-specific
schemas belong. Deleting `test/mcp` now removes only MCP code.

Drop the step banner along with it. `showOverlay` appended a banner to the DOM of
the product under test, which can shift layout and influence focus, so the runner
always opted out via VSCODE_EVIDENCE_CLEAN_CAPTURE. With the runner as the only
caller that opinion is unanimous, so the overlay and its opt-out both go and the
capture is unconditionally faithful. Step titles are still rendered onto the
finished recording by renderEvidenceChapters.

The new package emits declarations, matching `test/automation`, so the MCP server
keeps real types rather than silently degrading to `any`.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: adb443eb-11e5-40a1-8608-7f593fa79485

* Add the lockfile for the new scenario package

Registering `test/scenario` in `build/npm/dirs.ts` makes the root install run npm
in that directory, and CI uses `npm ci`, which requires a lockfile. Every other
package registered there has one, so a clean CI install failed immediately with
ENOENT on `test/scenario/package-lock.json` before anything compiled.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: adb443eb-11e5-40a1-8608-7f593fa79485

* Notify on the extracted scenario package

`test/mcp/**` notifies @TylerLeonhardt, so moving the runner to `test/scenario`
silently dropped notifications for it. Point the new path at the owner of the
validate-ui-scenario skill.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: adb443eb-11e5-40a1-8608-7f593fa79485

* Do not re-declare @types/node in the scenario package

The root package already declares `@types/node` as a devDependency, so the
extracted package inherits it through normal ancestor resolution; declaring it
again added a dependency that the OSS license check cannot cover, because
`@types/node` ships no LICENSE file and is not in ClearlyDefined or
cglicenses.json.

Verified against the state CI produces: `npm ci` in `test/scenario` installs no
`@types/node`, and both packages still compile, so the types resolve from the
repository root as intended.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: adb443eb-11e5-40a1-8608-7f593fa79485

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: adb443eb-11e5-40a1-8608-7f593fa79485
2026-08-20 14:47:55 -07:00

97 lines
3.8 KiB
Plaintext
Raw Blame History

# Base Utilities
src/vs/base/common/oauth.ts @TylerLeonhardt
src/vs/base/browser/domSanitize.ts @mjbvz
src/vs/base/parts/quickinput/** @TylerLeonhardt
# Base Widgets
src/vs/base/browser/ui/grid/** @benibenj
src/vs/base/browser/ui/list/** @benibenj
src/vs/base/browser/ui/sash/** @benibenj
src/vs/base/browser/ui/splitview/** @benibenj
src/vs/base/browser/ui/table/** @benibenj
src/vs/base/browser/ui/tree/** @benibenj
# Platform
src/vs/platform/agentHost/node/claude/** @TylerLeonhardt
src/vs/platform/browserView/** @kycutler @jruales
src/vs/platform/quickinput/** @TylerLeonhardt
src/vs/platform/secrets/** @TylerLeonhardt
src/vs/platform/terminal/common/** @anthonykim1
src/vs/platform/terminal/electron-main/** @anthonykim1
src/vs/platform/terminal/node/** @anthonykim1
# Electron Main
src/vs/code/** @deepak1556
# Workbench Layout & Editor Parts
src/vs/workbench/browser/parts/** @benibenj
src/vs/workbench/services/editor/** @benibenj
src/vs/workbench/services/layout/** @benibenj
# Workbench Services
src/vs/workbench/services/authentication/** @TylerLeonhardt
src/vs/workbench/services/browserView/** @kycutler @jruales
src/vs/workbench/services/dialogs/** @alexr00
src/vs/workbench/services/languageDetection/** @TylerLeonhardt
src/vs/workbench/services/views/** @sandy081 @benibenj
# Workbench Contributions
src/vs/workbench/contrib/authentication/** @TylerLeonhardt
src/vs/workbench/contrib/browserView/** @kycutler @jruales
src/vs/workbench/contrib/chat/browser/chatListRenderer.ts @roblourens
src/vs/workbench/contrib/chat/electron-browser/builtInTools/fetchPageTool.ts @TylerLeonhardt
src/vs/workbench/contrib/localization/** @TylerLeonhardt
src/vs/workbench/contrib/quickaccess/browser/commandsQuickAccess.ts @TylerLeonhardt
src/vs/workbench/contrib/scm/** @lszomoru
src/vs/workbench/contrib/terminal/** @anthonykim1
src/vs/workbench/contrib/terminalContrib/** @anthonykim1
src/vs/workbench/contrib/update/browser/releaseNotesEditor.ts @alexr00
src/vs/workbench/contrib/preferences/** @rzhao271
# Sessions Contributions
src/vs/sessions/contrib/browserView/** @kycutler @jruales
# Build
build/azure-pipelines/** @lszomoru
build/azure-pipelines/common/sanity-tests.yml @dmitrivMS
build/lib/i18n.ts @TylerLeonhardt
resources/linux/debian/** @rzhao271
resources/linux/rpm/** @rzhao271
# Editor contrib
src/vs/editor/standalone/browser/quickInput/** @TylerLeonhardt
# Workbench API
src/vs/workbench/api/common/extHostLocalizationService.ts @TylerLeonhardt
src/vs/workbench/api/browser/mainThreadAuthentication.ts @TylerLeonhardt
src/vs/workbench/api/common/extHostAuthentication.ts @TylerLeonhardt
src/vs/workbench/api/node/extHostAuthentication.ts @TylerLeonhardt
src/vs/workbench/api/common/extHostMcp.ts @TylerLeonhardt
src/vs/workbench/api/browser/mainThreadMcp.ts @TylerLeonhardt
src/vs/workbench/api/common/extHostQuickOpen.ts @TylerLeonhardt
src/vs/workbench/api/browser/mainThreadSecretState.ts @TylerLeonhardt
# Extensions
extensions/copilot/src/extension/chatSessions/claude/** @TylerLeonhardt
extensions/copilot/src/extension/chatSessions/vscode-node/claudeChatSession* @TylerLeonhardt
extensions/microsoft-authentication/** @TylerLeonhardt
extensions/github-authentication/** @TylerLeonhardt
extensions/git/** @lszomoru
extensions/git-base/** @lszomoru
extensions/github/** @lszomoru
extensions/vscode-api-tests/src/singlefolder-tests/browser*.test.ts @kycutler @jruales
# Testing
test/mcp/** @TylerLeonhardt
test/scenario/** @bryanchen-d
test/sanity/** @dmitrivMS
# Agents Workbench
# Ensure the Agents workbench team is aware of changes to the sessions model and services
src/vs/sessions/services/sessions/** @sandy081 @lszomoru
# Ensure the Agents workbench team is aware of changes to the core workbench layout
src/vs/sessions/contrib/layout/** @benibenj
src/vs/sessions/browser/parts/** @benibenj
src/vs/sessions/browser/workbench.ts @benibenj
Reference in New Issue View Git Blame Copy Permalink