mirror of
https://github.com/microsoft/vscode.git
synced 2026-06-08 08:36:46 +01:00
Dmitriy Vasyura
3405918741
* Fix BYOK regression for non-OAuth Copilot token pathways Introduce hasCopilotTokenSource on IAuthenticationService, defaulted to !!anyGitHubSession in BaseAuthenticationService and overridden to true in StaticGitHubAuthenticationService (proxy/HMAC, eval harness). Replace PR-introduced anyGitHubSession guards added in #317428 at sites that gate on 'can we mint a Copilot token?' so the eval proxy pathway is no longer short-circuited: - languageModelAccess._getToken - authentication.contribution.waitForChatEnabled - copilotCli (3 sites) - remoteEmbeddingsComputer Group-B sites that intentionally gate on a real signed-in GitHub user (conversationFeature search/intent provider registration, byokUtilityModel notification) keep using anyGitHubSession. * PR feedback: clarify log message; fall back to empty embeddings in proxy scenarios - Update languageModelAccess log to say 'Copilot token source' (matches the new gate). - In remoteEmbeddingsComputer, return empty embeddings instead of throwing when the Dotcom path lacks a GitHub access token (proxy/HMAC eval harness), matching the rest of the function's empty-fallback behavior.