Files
vscode/src/vs/workbench/contrib/debug/test/browser/debugConfigurationManager.test.ts
Walter Erquinigo e3b1073902 Handle errors from Dynamic Debug Configuration providers (#202622)
* Handle errors from Dynamic Debug Configuration providers

If a Dynamic Configuration provider, via its method `provideDebugConfigurations`, returns `undefined` or throws an Error, the selector in the Debug Tab is left in a borked state instead of going back to the last selected item. 
This was initially reported in https://github.com/microsoft/vscode/issues/198798, whose fix handled some cases, but not all. This commit attempts to handle all the remaining cases.

* Use logservice to report error

* Fix build

---------

Co-authored-by: Rob Lourens <roblourens@gmail.com>
2024-07-29 09:39:36 -07:00

133 lines
5.7 KiB
TypeScript

/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import assert from 'assert';
import { CancellationToken } from 'vs/base/common/cancellation';
import { Event } from 'vs/base/common/event';
import { DisposableStore } from 'vs/base/common/lifecycle';
import { URI } from 'vs/base/common/uri';
import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils';
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
import { TestConfigurationService } from 'vs/platform/configuration/test/common/testConfigurationService';
import { ContextKeyService } from 'vs/platform/contextkey/browser/contextKeyService';
import { FileService } from 'vs/platform/files/common/fileService';
import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection';
import { TestInstantiationService } from 'vs/platform/instantiation/test/common/instantiationServiceMock';
import { NullLogService } from 'vs/platform/log/common/log';
import { UriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentityService';
import { ConfigurationManager } from 'vs/workbench/contrib/debug/browser/debugConfigurationManager';
import { DebugConfigurationProviderTriggerKind, IAdapterManager, IConfig, IDebugAdapterExecutable, IDebugSession } from 'vs/workbench/contrib/debug/common/debug';
import { IPreferencesService } from 'vs/workbench/services/preferences/common/preferences';
import { TestQuickInputService } from 'vs/workbench/test/browser/workbenchTestServices';
import { TestHistoryService, TestContextService, TestExtensionService, TestStorageService } from 'vs/workbench/test/common/workbenchTestServices';
suite('debugConfigurationManager', () => {
const configurationProviderType = 'custom-type';
let _debugConfigurationManager: ConfigurationManager;
let disposables: DisposableStore;
const adapterManager = <IAdapterManager>{
getDebugAdapterDescriptor(session: IDebugSession, config: IConfig): Promise<IDebugAdapterExecutable | undefined> {
return Promise.resolve(undefined);
},
activateDebuggers(activationEvent: string, debugType?: string): Promise<void> {
return Promise.resolve();
},
get onDidDebuggersExtPointRead(): Event<void> {
return Event.None;
}
};
const preferencesService = <IPreferencesService>{
userSettingsResource: URI.file('/tmp/settings.json')
};
const configurationService = new TestConfigurationService();
setup(() => {
disposables = new DisposableStore();
const fileService = disposables.add(new FileService(new NullLogService()));
const instantiationService = disposables.add(new TestInstantiationService(new ServiceCollection([IPreferencesService, preferencesService], [IConfigurationService, configurationService])));
_debugConfigurationManager = new ConfigurationManager(
adapterManager,
new TestContextService(),
configurationService,
new TestQuickInputService(),
instantiationService,
new TestStorageService(),
new TestExtensionService(),
new TestHistoryService(),
new UriIdentityService(fileService),
new ContextKeyService(configurationService),
new NullLogService());
});
teardown(() => disposables.dispose());
ensureNoDisposablesAreLeakedInTestSuite();
test('resolves configuration based on type', async () => {
disposables.add(_debugConfigurationManager.registerDebugConfigurationProvider({
type: configurationProviderType,
resolveDebugConfiguration: (folderUri, config, token) => {
assert.strictEqual(config.type, configurationProviderType);
return Promise.resolve({
...config,
configurationResolved: true
});
},
triggerKind: DebugConfigurationProviderTriggerKind.Initial
}));
const initialConfig: IConfig = {
type: configurationProviderType,
request: 'launch',
name: 'configName',
};
const resultConfig = await _debugConfigurationManager.resolveConfigurationByProviders(undefined, configurationProviderType, initialConfig, CancellationToken.None);
assert.strictEqual((resultConfig as any).configurationResolved, true, 'Configuration should be updated by test provider');
});
test('resolves configuration from second provider if type changes', async () => {
const secondProviderType = 'second-provider';
disposables.add(_debugConfigurationManager.registerDebugConfigurationProvider({
type: configurationProviderType,
resolveDebugConfiguration: (folderUri, config, token) => {
assert.strictEqual(config.type, configurationProviderType);
return Promise.resolve({
...config,
type: secondProviderType
});
},
triggerKind: DebugConfigurationProviderTriggerKind.Initial
}));
disposables.add(_debugConfigurationManager.registerDebugConfigurationProvider({
type: secondProviderType,
resolveDebugConfiguration: (folderUri, config, token) => {
assert.strictEqual(config.type, secondProviderType);
return Promise.resolve({
...config,
configurationResolved: true
});
},
triggerKind: DebugConfigurationProviderTriggerKind.Initial
}));
const initialConfig: IConfig = {
type: configurationProviderType,
request: 'launch',
name: 'configName',
};
const resultConfig = await _debugConfigurationManager.resolveConfigurationByProviders(undefined, configurationProviderType, initialConfig, CancellationToken.None);
assert.strictEqual(resultConfig!.type, secondProviderType);
assert.strictEqual((resultConfig as any).configurationResolved, true, 'Configuration should be updated by test provider');
});
teardown(() => disposables.clear());
});