mirror of
https://github.com/microsoft/vscode.git
synced 2026-09-10 03:44:24 +01:00
Connor PeetandCopilot
710b8c0cb4
- Add a "bang command" feature: in any chat agent, a message starting with `!` runs as a terminal command (via the existing agent-host terminal/shell integration) instead of being sent to the model. The host emits a transcript-only tool-call response for the command. - Persist host-injected "local turns" (`!command` and `/rename`) so they survive reload; fork/truncate/rename resolve them to the preceding concrete SDK turn. Handled uniformly per-chat (default, peer and subagent chats). - Refactor local command handling into a pluggable `LocalChatCommandRegistry` with self-contained `AgentHostLocalCommands` dispatcher, extracting the logic out of `AgentSideEffects`. Add `renameLocalCommand` and `bangLocalCommand`. - Extract shared helpers: `shellCommandExecution` (agent-agnostic shell exec core) and `persistSessionMetadata`. - Fix peer-chat truncation routing: `truncateSession` now takes the chat URI and routes peer chats to their own backing session. - Fix truncate no-op after forking into a second peer chat: `SessionDataService` keyed every peer chat of a session onto one data dir/DB (chat id lives in the URI authority, which `AgentSession.id` dropped), so a second fork's `vacuumInto` failed with "output file already exists" and the forked chat never inherited its turn event IDs. Key now includes the authority; both fork copy sites also clear any stale target DB first. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
71 lines
3.7 KiB
TypeScript
71 lines
3.7 KiB
TypeScript
/*---------------------------------------------------------------------------------------------
|
|
* Copyright (c) Microsoft Corporation. All rights reserved.
|
|
* Licensed under the MIT License. See License.txt in the project root for license information.
|
|
*--------------------------------------------------------------------------------------------*/
|
|
|
|
import assert from 'assert';
|
|
import { NullLogService } from '../../../log/common/log.js';
|
|
import { ensureNoDisposablesAreLeakedInTestSuite } from '../../../../base/test/common/utils.js';
|
|
import { MessageKind, TurnState, type Turn } from '../../common/state/sessionState.js';
|
|
import { AgentHostLocalTurns } from '../../node/agentHostLocalTurns.js';
|
|
import { TestSessionDatabase, createSessionDataService } from '../common/sessionTestHelpers.js';
|
|
|
|
suite('AgentHostLocalTurns', () => {
|
|
|
|
ensureNoDisposablesAreLeakedInTestSuite();
|
|
|
|
const session = 'mock:/session-1';
|
|
|
|
function turn(id: string): Turn {
|
|
return { id, message: { text: id, origin: { kind: MessageKind.User } }, responseParts: [], usage: undefined, state: TurnState.Complete };
|
|
}
|
|
|
|
test('records, resolves anchors, persists, and deletes local turns', async () => {
|
|
const db = new TestSessionDatabase();
|
|
const registry = new AgentHostLocalTurns(createSessionDataService(db), new NullLogService());
|
|
const chat = 'ahp-chat://default/xyz';
|
|
|
|
// Two locals: one anchored to a real turn, one anchored before any real turn.
|
|
registry.record(session, chat, turn('local-a'), 'real-1');
|
|
registry.record(session, chat, turn('local-b'), undefined);
|
|
|
|
assert.strictEqual(registry.isLocal(chat, 'local-a'), true);
|
|
assert.strictEqual(registry.isLocal(chat, 'real-1'), false);
|
|
// Local resolves to its concrete anchor; a concrete turn resolves to itself.
|
|
assert.strictEqual(registry.resolveConcreteTurnId(chat, 'local-a'), 'real-1');
|
|
assert.strictEqual(registry.resolveConcreteTurnId(chat, 'local-b'), undefined);
|
|
assert.strictEqual(registry.resolveConcreteTurnId(chat, 'real-1'), 'real-1');
|
|
assert.deepStrictEqual(new Set(registry.getLocalTurnIds(chat)), new Set(['local-a', 'local-b']));
|
|
|
|
// Persisted to the database with the chat discriminator.
|
|
const persisted = await db.getLocalTurns();
|
|
assert.deepStrictEqual(persisted.map(r => ({ turnId: r.turnId, chatUri: r.chatUri, anchorTurnId: r.anchorTurnId })), [
|
|
{ turnId: 'local-a', chatUri: chat, anchorTurnId: 'real-1' },
|
|
{ turnId: 'local-b', chatUri: chat, anchorTurnId: undefined },
|
|
]);
|
|
|
|
// Delete removes from memory and the database.
|
|
registry.deleteLocals(session, ['local-a']);
|
|
assert.strictEqual(registry.isLocal(chat, 'local-a'), false);
|
|
assert.deepStrictEqual((await db.getLocalTurns()).map(r => r.turnId), ['local-b']);
|
|
});
|
|
|
|
test('load re-populates the in-memory index from the database, scoped per chat', async () => {
|
|
const db = new TestSessionDatabase();
|
|
const chatA = 'ahp-chat://default/a';
|
|
const chatB = 'ahp-chat://peer/b';
|
|
await db.insertLocalTurn({ turnId: 'local-x', chatUri: chatA, anchorTurnId: 'real-9', seq: 3, payload: JSON.stringify(turn('local-x')) });
|
|
await db.insertLocalTurn({ turnId: 'local-y', chatUri: chatB, anchorTurnId: undefined, seq: 4, payload: JSON.stringify(turn('local-y')) });
|
|
|
|
const registry = new AgentHostLocalTurns(createSessionDataService(db), new NullLogService());
|
|
const recordsA = await registry.loadForChat(session, chatA);
|
|
|
|
// loadForChat returns only the requested chat's records...
|
|
assert.deepStrictEqual(recordsA.map(r => r.turnId), ['local-x']);
|
|
// ...but the in-memory index is populated for every chat in the session.
|
|
assert.strictEqual(registry.isLocal(chatA, 'local-x'), true);
|
|
assert.strictEqual(registry.resolveConcreteTurnId(chatA, 'local-x'), 'real-9');
|
|
assert.strictEqual(registry.isLocal(chatB, 'local-y'), true);
|
|
});
|
|
});
|