2 Commits

Include renames

Author	SHA1	Message	Date
Dominik	9e81373ec4	fix: accept punycode domains that libidn2 rejects under IDNA2008 ... When adding or searching for exact domains, the API unconditionally passes the input through idn2_to_ascii_lz() for IDN normalization. This round-trips punycode domains: decode to Unicode, validate against IDNA2008, re-encode to ASCII. Characters like emoji are disallowed by IDNA2008 (RFC 5892), so valid punycode domains such as xn--4ca0bs45142c.com (äöü😀.com) are rejected with "string contains a disallowed character" even though they are perfectly valid DNS names. Fix by checking whether the input is already pure ASCII before calling idn2_to_ascii_lz(). If every byte is <= 0x7F, skip IDN conversion entirely — the domain is already in a DNS-compatible form and only needs lowercasing and valid_domain() validation. Non-ASCII input (actual Unicode domains) still goes through the IDN conversion path. Applied to both the list API (src/api/list.c) and the search API (src/api/search.c). Fixes: https://github.com/pi-hole/FTL/issues/2837 Signed-off-by: Dominik <dl6er@dl6er.de>	2026-04-06 11:08:42 +02:00
Dominik	cc33fbc545	test: add PUT/DELETE, batch delete, query filter, and auth tests ... Add ~80 new pytest API integration tests covering previously untested endpoints and HTTP methods: - DELETE 204/404 for groups, domains, clients, lists, config array items, network devices, and info messages - PUT create/replace round-trips for groups, domains, clients, lists - PUT error cases (missing body, invalid domain type) - Batch delete (POST :batchDelete) for groups, domains, clients, lists - DNS blocking toggle (POST disable + re-enable) - Auth session logout (DELETE /api/auth) and delete-by-ID - GET endpoints: clients, config, network gateway/routes, info host/sensors/metrics, query filters (domain, client_ip, upstream, blocklist pseudo-upstream), query suggestions, query cursor pagination, stats database with time ranges, history database with time ranges - Search with partial matching - TOTP credential suggestion (GET /api/auth/totp) - Config PATCH round-trip (bool and integer, change + verify + restore) - NTP server protocol-level test (UDP NTPv4 request/response) - Update test_final.bats known-warning patterns and config write counts Signed-off-by: Dominik <dl6er@dl6er.de>	2026-03-30 21:26:16 +02:00